Turn on filter only if it was used during printing.

[tehniemer]

I noticed my nevermore would run for 10 minutes after every print regardless of if it was used during the print, I think adding this conditional logic makes sense.

[tehniemer]

Again, sorry for the messy commit history, I don't know what I'm doing that's merging my branches the wrong direction sometimes.

[Frix-x]

Thanks for this PR. It's also ok for me, good idea :)
Just a slight change asked to keep the max speed during this last cleaning process in order to filter efficiently the chamber air before opening the doors.

[Surion79]

how about adding a variable describing the functionality to be activated? So it can be either the new logic or the old

[Frix-x]

how about adding a variable describing the functionality to be activated? So it can be either the new logic or the old

No I think this small changes makes sense for everyone and do not need another new specific variable for it. I'll prefer to keep it simple and merge it like that

[Benoitone]

doesn't work for me...

[tehniemer]

Can you provide a few more details?

[Benoitone]

I can't make more test now but when I print ABS (filter fan speed 30%) at the end of the print filter speed stay at 30% instead of 100%...

[tehniemer]

I tested this morning and can confirm that it runs at the speed it ran during the print, maybe because it was never stopped?

Is this behavior different than what happened before the change? I don't see how my modification would have made this difference.

[tehniemer]

On second look, it seems that the filter is stuck on, I think I might be improperly trying to pull a variable from START_PRINT, I'm guessing I have to figure out a different way to tell the END_PRINT macro the fan was running during the print.

{% set filter_speed = printer["gcode_macro START_PRINT"].material.filter_speed|default(0)|int %}

[tehniemer]

Is there a way to poll the current SPEED value of a fan? This was my first choice on how to implement this because it won't require any extra variables to be passed. Maybe something like this:

    {% if filter_enabled and printer['fan_generic filter'].speed > 0 %}
        {% set FILTER_TIME = params.FILTER_TIME|default(filter_default_time)|int %}
        START_FILTER SPEED=1
        UPDATE_DELAYED_GCODE ID=_STOP_FILTER_DELAYED DURATION={FILTER_TIME}
    {% endif %}

[tehniemer]

Darn, printer['fan_generic filter'].speed causes an error if a filter isn't enabled. Anyone else have an idea?

[Benoitone]

Have a look... https://github.com/Frix-x/klippain/blob/Happy_Hare_Dev/macros/base/end_print.cfg
I didn't test but it should work

[Benoitone]

Have a look... https://github.com/Frix-x/klippain/blob/Happy_Hare_Dev/macros/base/end_print.cfg I didn't test but it should work

@tehniemer @Frix-x It's ok like this... I have tested... Do you want to open a PR on main branch?

[Benoitone]

some need modification to make it works...

[Benoitone]

maybe not the correct variable to use...

[Benoitone]

must be remove

[Benoitone]

{% if filter_enabled %}
    {% if printer['fan_generic filter'].speed > 0 %}
        {% set FILTER_TIME = params.FILTER_TIME|default(filter_default_time)|int %}
        START_FILTER SPEED=1
        UPDATE_DELAYED_GCODE ID=_STOP_FILTER_DELAYED DURATION={FILTER_TIME}
    {% endif %}
{% endif %}

[tehniemer]

Have you tested that this line, {% if printer['fan_generic filter'].speed > 0 %}, doesn't throw an error if no filter is enabled in printer.cfg?

[Benoitone]

Have you tested that this line, {% if printer['fan_generic filter'].speed > 0 %}, doesn't throw an error if no filter is enabled in printer.cfg?

that's why i put {% if filter_enabled %} before...

[tehniemer]

That still fails if no filter is enabled in printer.cfg.

[Benoitone]

That still fails if no filter is enabled in printer.cfg.

it works for me when I comment on nevermore_filter from printer.cfg
Your error is stange if you have desactivated nevermore... maybe you have an override of [fan_generic filter]??

[Benoitone]

I can put the PR if you want?

[tehniemer]

it works for me when I comment on nevermore_filter from printer.cfg Your error is stange if you have desactivated nevermore... maybe you have an override of [fan_generic filter]??

You're right, I did have an override I forgot about. Go ahead if you already have a branch created for it.

[Benoitone]

it works for me when I comment on nevermore_filter from printer.cfg Your error is stange if you have desactivated nevermore... maybe you have an override of [fan_generic filter]??

You're right, I did have an override I forgot about. Go ahead if you already have a branch created for it.

As you want... I'm ready to post a PR but if you want it's your idea...
Tell me...

[tehniemer]

@Benoitone I'll do it.