Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _TIP_SHAPING from End/cancel print macros #357

Merged
merged 9 commits into from
Dec 15, 2023
Merged

Remove _TIP_SHAPING from End/cancel print macros #357

merged 9 commits into from
Dec 15, 2023

Conversation

tehniemer
Copy link
Contributor

I'm not sure why this is called here, but it leaves an undesirable string that can cause issues with homing Z if not removed manually.

Surion79 and others added 8 commits November 21, 2023 11:10
@Surion79
added Ocotpus Pro v1.1 template (Frix-x#349)
a5ea3df
@tehniemer
Remove _TIP_SHAPING from End/cancel print macros
a6b0859 
I'm not sure why this is called here, but it leaves an undesirable string that can cause issues with homing Z if not removed manually.
@tehniemer
Add wipe and variable for charging nozzle to prime line macro
d86f6b0 
Added a wipe after priming and a user configurable variable to set the pre-prime extrude distance, essentially charging the nozzle.
@tehniemer
Add user configurable variables for retract distances in macros
175f350 
Added two new variables for retract, one for the cancel and end print macros and another for the nozzle cleaning macro.
@tehniemer
Merge pull request #5 from tehniemer/retract-length
a1f9377 
Add user configurable variables for retract distances in macros
@tehniemer
Merge pull request #6 from tehniemer/PrimeLine
90d310c 
Add wipe and variable for charging nozzle to prime line macro
@tehniemer
Merge branch 'dev' into noTipShaping
8f4e16a
@tehniemer
Revert "Merge branch 'dev' into noTipShaping"
5c9f1ed 
This reverts commit 8f4e16a, reversing
changes made to a6b0859.
@Frix-x Frix-x deleted the branch Frix-x:develop November 29, 2023 09:47
@Frix-x Frix-x closed this Nov 29, 2023
@Frix-x Frix-x reopened this Nov 29, 2023
@Frix-x
Copy link
Owner

Frix-x commented Nov 29, 2023

Hello,

I'd like to explain the rationale behind the TIP_SHAPING call: at the end of a print, we retract the filament above the heatbreak, this macro allow creating a clean, well-shaped tip that's ready for easy reinsertion later on.

There are two key benefits to this approach:

  1. Since the filament is retracted beyond the heat-affected zone, it doesn't stick inside the nozzle. This makes filament changes easy, even when the printer is cold. Simply open the extruder latch and pull the filament out. I use this method daily.
  2. It also helps in preventing filament degradation during the start_print process, which can sometimes be pretty long and involve periods with the nozzle hot without printing. By keeping the filament above the hot zone until the final purge, it avoids the risk of cooking and clogging the filament inside the nozzle.

On my side it's not a problem since even if the first homing is wrong due to this small string, It's usually cleaned during the purge or clean process above the brush before the final measurement that is done at printing temperature on my machine. But as I don't have a TAP, I agree that it could be problematic.

Does anyone else see this as a problem ? (@Surion79 @Benoitone @elpopo-eng ?)

@Frix-x Frix-x added the question Further information is requested label Nov 29, 2023
@Surion79
Copy link
Collaborator

I had the undesired string as well, but lately not at all. tip shaping is more than just pulling it up.
it does push and pull the filament in increasing increments.

image

so such a string can be possible. and with any kind of endstop which measures nozzle, it would be an issue, if you don't clear the nozzle before doing "the final" preprint homing on z. when i had the string issue i had to remove it all the time for the tap home. I do wonder if the ruby nozzle is helping me in this case.

@tehniemer
Copy link
Contributor Author

tehniemer commented Nov 29, 2023 •
edited
Loading

Filament retract happens after the TIP_SHAPING call at the end of the print, and this PR doesn't make any changes to retract settings.

I know the commit history is a mess, but after the revert it's just this one in this PR, or is intended to be.

@Frix-x
Copy link
Owner

Frix-x commented Dec 13, 2023 •
edited
Loading

Filament retract happens after the TIP_SHAPING call at the end of the print, and this PR doesn't make any changes to retract settings.

I know the commit history is a mess, but after the revert it's just this one in this PR, or is intended to be.

Yes you're right, but the TIP_SHAPING was added on purpose by myself long time ago to get a clean and nice tip shape in order to facilitate the reinsertion of the filament later on. But I'm fine with removing it if it cause more trouble: as it's easy to manually cut the tip before reinsertion as well.

I just need to validate that it will not cause problem to ERCF users since I know that the TIP_SHAPING part is usually very important for them. But maybe this is already handled correctly by HappyHare. @Benoitone @Surion79 do you have infos about this? If it's needed for you, we can also put it in a "if mmu enabled, do tip shaping" block.

@Surion79
Copy link
Collaborator

tip_shaping is used only in the constellation with ERCF if the filament is unloaded (ERCF_UNLOAD). I think if someone uses ERCF and does not unload, i tend to think that the user doesn't want to have it reloaded. so i think it is not necessary for ERCF users
@Benoitone what is your take on this?

@Frix-x
Copy link
Owner

Frix-x commented Dec 15, 2023

So, I'll merge this PR now and if the TIP_SHAPING is needed for the MMU/ERCF users, then we will handle this in the HappyHare opened PR directly to restore this feature for these users.

@Frix-x Frix-x merged commit f8b817a into Frix-x:develop Dec 15, 2023
@tehniemer tehniemer deleted the noTipShaping branch December 15, 2023 15:56
@agravelot
Copy link

Dragon hotend have a small lip above the heatbreak, without a proper tip shaping, it can be stuck inside.

Thread on voron discord:
https://discord.com/channels/460117602945990666/830395563094442044/1179962754497511454

@Surion79
Copy link
Collaborator

Dragon hotend have a small lip above the heatbreak, without a proper tip shaping, it can be stuck inside.

Thread on voron discord:

https://discord.com/channels/460117602945990666/830395563094442044/1179962754497511454

Better open an issue. Commenting closed PRs tend to be overseen.

Frix-x added a commit that referenced this pull request Feb 13, 2024
@tehniemer @Surion79 @Frix-x
Remove _TIP_SHAPING from End/cancel print macros (#357)
e88cf79 
Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com>
Co-authored-by: Félix Boisselier <felix@fboisselier.fr>
reineruhry pushed a commit to reineruhry/klippain that referenced this pull request Feb 13, 2024
@tehniemer @Surion79
@Frix-x @reineruhry
Remove _TIP_SHAPING from End/cancel print macros (Frix-x#357)
86ab771 
Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com>
Co-authored-by: Félix Boisselier <felix@fboisselier.fr>
tehniemer added a commit to tehniemer/klippain that referenced this pull request Mar 19, 2024
@tehniemer @gralves2
@Frix-x @Benoitone @Surion79 @aaarsene @claudioguareschi @ksummers92 @Elias23 @nmsmith22389 @reineruhry @lokiagent @arcadien @tolson4 @elpopo-eng @tsk-2222 @mvdveer @akashrpatel @fbeauKmi @Birkemosen @EricZimmerman @magne @infowolfe
Upstream main (#29)
876666b 
* BTT S2DW V1.0 and similar RP2040 + lis2dw boards (Frix-x#439)

* Add Octopus Pro 1.0 MCU definition as duplicate of Octopus MCU

* fix typo in BTT_Octopus_Pro_v1.1.cfg (Frix-x#460)

* Turn on filter only if it was used during printing. (Frix-x#380)


Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com>

* added parameters to park (Frix-x#391)

* M8P v2.0 SPI fix (Frix-x#389)


Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

* Add per material filament sensor management (Frix-x#381)

* Remove _TIP_SHAPING from End/cancel print macros (Frix-x#357)


Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com>
Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

* Klipper SET_PRINT_STATS_INFO compatibility (Frix-x#392)


Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

* Fix error with turning on filter only if it was used during printing. (Frix-x#406)

Fix issue discovered after merging Frix-x#380

* fix missing variable to cancel_print (Frix-x#408)

* filament sensor status checks universal (Frix-x#411)

* proper Shake&Tune integration in Klippain

* add mellow SB2040 v2 and SB2040 Pro toolhead boards (Frix-x#417)

* correct overriders misspelling (Frix-x#425)

* check if heatsoak is configured to verbose message (Frix-x#424)

* typo

* Add pin definitions for Fysetc S6 V2.X

* add TR8x2 leadscrew config for trident

* Add older version of Fysetc mini12864 display

* HappyHare & other related dev (Frix-x#371)

* HappyHare MMU integration in Klippain

* Spoolman support

* Multiple MCU templates added or modified, especially MMU templates

* LED system rework to support the LED_effects plugin and rainbow barf, etc... ( Frix-x#416 )

* TMC Autotune moonraker updater predefined config (add your motor defs to your overrides.cfg or mcu.cfg)

---------

Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com>
Co-authored-by: claudioguareschi <33001685+claudioguareschi@users.noreply.github.com>
Co-authored-by: Félix Boisselier <felix@fboisselier.fr>
Co-authored-by: ksummers92 <66363414+ksummers92@users.noreply.github.com>

* fix status leds at startup (Frix-x#448)

* Status leds on startup fix

* display menu and V0 Display (Frix-x#420)

* Better display menu adapted to Klippain

* V0 display support

* Klippain boot logo

---------

Co-authored-by: Elias Huwyler <elias.huwyler@ti8m.ch>

* improved display management structure

* fixed MMU includes for HappyHare symlink

* Add BLTouch support (Frix-x#450)

* fixed nozzle and status led on/off.  (Frix-x#454)

* reverted update manager to main branch

* followed naming scheme for bltouch include as virtual

* moved the machine.cfg include and included additional thermistor defs

* Mellow fly super8 template (Frix-x#463)

* Support for TMC5160 on Z Axis (Frix-x#469)

* added fix to prevent issues when updating Klippain without MMU (Frix-x#462)

* Add configs for Fysetc SB Can TH boards (Frix-x#464)


Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

* fix: make prime line height a variable parameter (Frix-x#466)

Fix Frix-x#465

* fix for extrude when temperature is too low (Frix-x#480)

* Add BTT Kraken MCU support (Frix-x#476)

* Update Fysetc_Spider_v3.x.cfg to fix fan ports (Frix-x#474)

* fix BTT_MMB pin (Frix-x#486)

* added fix for rsense for TMC5160 (Frix-x#489)

* Add support for dockable probes with separate retainer (Frix-x#401)

This is needed for probes like https://github.com/kevinakasam/KlackEnder-Probe

* fix for rsense on TMC5160 Z (Frix-x#490)

* Create stale action workflow (Frix-x#449)


Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

* fixed K-Shake&Tune integration

* Avoid cooling hotend in extruder_preheating Frix-x#495 (Frix-x#496)

* Add a park front macro for toolhead maintenance (Frix-x#494)

* Update MMU include order to allow overriding default HH defs (Frix-x#497)

* avoid led effect flashing on startup if leds desabled on startup (Frix-x#500)

* Added BTT SKR2 board template (Frix-x#503)

* fixed the regression introduced in startup call

* fix typo in stale.yml

* fixed probe pin for BTT_SB2209_RP2040_v1.0 (Frix-x#507)

* LDO Nitehawk MCU template and tachometer management (Frix-x#505)


Co-authored-by: Meindert <19568018+mvdveer@users.noreply.github.com>
Co-authored-by: Akash Patel <akashrpatel@yahoo.com>

* update primeline to make it adaptive (Frix-x#498)


Co-authored-by: Frédéric Beaucamp <88246672+fbeauKmi@users.noreply.github.com>
Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

* fixed missing adaptive primeline variable

* remplaced CANCEL_PRINT by PARK in the automated error management gcode

* fixed typo in LDO Nitehawk manufacturer template

* Add support for Manta_M5P v1.0 and 0.9 degree steppers on Trident Z axis (Frix-x#514)

* fix homing check for PARK in error gcode (Frix-x#513)

* fix typo in Fysetc_ERCF_ERB.cfg (Frix-x#519)

* Update BTT_Kraken_v1.0.cfg, RGB1 fix

listed as PF10, but should be PF12 (pf10 is mcu_min7 already, an endstop)

verified rest of pins as well

* reverted PARK and PARK_FRONT to fail if axis are not homed

* fix PARK with overriden param E (Frix-x#515)

* install and uninstall scripts improvement (Frix-x#511)

* Don't fail uninstall if the backup folder has been removed
* Make uninstall work when backup has sub-directories
* Make sure we don't fail making a backup when there is no current user config folder

* added Mellow Fly Gemini v3 MCU template (Frix-x#527)

* fix pinout for Fysetc_ERB board (Frix-x#530)

* updated homing_override to improve sensorless homing (Frix-x#531)

by using M400 vs the old 2 second dwell time that is not required anymore

* fixed v0_display pin and improved overrides docs (Frix-x#535)

* Update rpi_temp.cfg

Format with _ so a space is in the name, like other temps

* Update cabinet_temp.cfg

* switched to the new minimum_cruise_ratio Klipper parameter

* commented the default minimum_cruise_ratio to not break older Klipper versions

---------

Co-authored-by: Gustavo Ribeiro Alves <145077902+gralves2@users.noreply.github.com>
Co-authored-by: Andrew Wickham <andrewwickham@westfieldgrp.com>
Co-authored-by: Félix Boisselier <felix@fboisselier.fr>
Co-authored-by: Benoitone <63300355+Benoitone@users.noreply.github.com>
Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com>
Co-authored-by: Arsène Thieffry <arsene.thieffry@gmail.com>
Co-authored-by: claudioguareschi <33001685+claudioguareschi@users.noreply.github.com>
Co-authored-by: ksummers92 <66363414+ksummers92@users.noreply.github.com>
Co-authored-by: Elias Huwyler <elias.huwyler@gmail.com>
Co-authored-by: Elias Huwyler <elias.huwyler@ti8m.ch>
Co-authored-by: Neil Smith <8648114+nmsmith22389@users.noreply.github.com>
Co-authored-by: Reiner Uhry <24939566+reineruhry@users.noreply.github.com>
Co-authored-by: lokiagent <75763148+lokiagent@users.noreply.github.com>
Co-authored-by: Arcadien <aurelien.labrosse@gmail.com>
Co-authored-by: Tyler Olson <tolson@dlinc.io>
Co-authored-by: Felix Boisselier <f.boisselier@irepa-laser.com>
Co-authored-by: elpopo <68954733+elpopo-eng@users.noreply.github.com>
Co-authored-by: tsk-2222 <111063724+tsk-2222@users.noreply.github.com>
Co-authored-by: Meindert <19568018+mvdveer@users.noreply.github.com>
Co-authored-by: Akash Patel <akashrpatel@yahoo.com>
Co-authored-by: Frédéric Beaucamp <88246672+fbeauKmi@users.noreply.github.com>
Co-authored-by: Birkemosen <Birkemosen@users.noreply.github.com>
Co-authored-by: Eric <saericzimmerman@gmail.com>
Co-authored-by: Magne Rasmussen <magne.rasmussen@gmail.com>
Co-authored-by: Parker <infowolfe@gmail.com>
ksummers92 added a commit to ksummers92/klippain that referenced this pull request Jun 22, 2024
@ksummers92 @Surion79
@Frix-x @Benoitone @EricZimmerman @dhazelett @gralves2 @tehniemer @aaarsene @claudioguareschi @Elias23 @nmsmith22389 @reineruhry @lokiagent @arcadien @tolson4 @elpopo-eng @tsk-2222 @mvdveer @akashrpatel @fbeauKmi @Birkemosen @magne @infowolfe @Svennixx @cdedwards @ndanyluk
Happy hare main backup (#10)
0efb4d5 
* Fysetc Catalyst Config

* added respond on idle_timeout

* sherpa mini config (Frix-x#385)


Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

* switch moonraker update management to dev channel (Frix-x#390)

* Update orbiter2.0.cfg (Frix-x#405)

Add comment about required current. At the default of 0.45 on the Orbiter 2 motor, very poor performance will occur including significant underextrusion on infill, etc.

* chore(mcu): properly label CAN H/L (Frix-x#418)

TX and RX are not helpful, looking at the back of the m8p v2 shows that RX is high, and TX is low.

* added back the proper idle timeout behavior

* BTT S2DW V1.0 and similar RP2040 + lis2dw boards (Frix-x#439)

* Add Octopus Pro 1.0 MCU definition as duplicate of Octopus MCU

* fix typo in BTT_Octopus_Pro_v1.1.cfg (Frix-x#460)

* Turn on filter only if it was used during printing. (Frix-x#380)


Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com>

* added parameters to park (Frix-x#391)

* M8P v2.0 SPI fix (Frix-x#389)


Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

* Add per material filament sensor management (Frix-x#381)

* Remove _TIP_SHAPING from End/cancel print macros (Frix-x#357)


Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com>
Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

* Klipper SET_PRINT_STATS_INFO compatibility (Frix-x#392)


Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

* Fix error with turning on filter only if it was used during printing. (Frix-x#406)

Fix issue discovered after merging Frix-x#380

* fix missing variable to cancel_print (Frix-x#408)

* filament sensor status checks universal (Frix-x#411)

* proper Shake&Tune integration in Klippain

* add mellow SB2040 v2 and SB2040 Pro toolhead boards (Frix-x#417)

* correct overriders misspelling (Frix-x#425)

* check if heatsoak is configured to verbose message (Frix-x#424)

* typo

* Add pin definitions for Fysetc S6 V2.X

* add TR8x2 leadscrew config for trident

* Add older version of Fysetc mini12864 display

* HappyHare & other related dev (Frix-x#371)

* HappyHare MMU integration in Klippain

* Spoolman support

* Multiple MCU templates added or modified, especially MMU templates

* LED system rework to support the LED_effects plugin and rainbow barf, etc... ( Frix-x#416 )

* TMC Autotune moonraker updater predefined config (add your motor defs to your overrides.cfg or mcu.cfg)

---------

Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com>
Co-authored-by: claudioguareschi <33001685+claudioguareschi@users.noreply.github.com>
Co-authored-by: Félix Boisselier <felix@fboisselier.fr>
Co-authored-by: ksummers92 <66363414+ksummers92@users.noreply.github.com>

* fix status leds at startup (Frix-x#448)

* Status leds on startup fix

* display menu and V0 Display (Frix-x#420)

* Better display menu adapted to Klippain

* V0 display support

* Klippain boot logo

---------

Co-authored-by: Elias Huwyler <elias.huwyler@ti8m.ch>

* improved display management structure

* fixed MMU includes for HappyHare symlink

* Add BLTouch support (Frix-x#450)

* fixed nozzle and status led on/off.  (Frix-x#454)

* reverted update manager to main branch

* followed naming scheme for bltouch include as virtual

* moved the machine.cfg include and included additional thermistor defs

* Mellow fly super8 template (Frix-x#463)

* Support for TMC5160 on Z Axis (Frix-x#469)

* added fix to prevent issues when updating Klippain without MMU (Frix-x#462)

* Add configs for Fysetc SB Can TH boards (Frix-x#464)


Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

* fix: make prime line height a variable parameter (Frix-x#466)

Fix Frix-x#465

* fix for extrude when temperature is too low (Frix-x#480)

* Add BTT Kraken MCU support (Frix-x#476)

* Update Fysetc_Spider_v3.x.cfg to fix fan ports (Frix-x#474)

* fix BTT_MMB pin (Frix-x#486)

* added fix for rsense for TMC5160 (Frix-x#489)

* Add support for dockable probes with separate retainer (Frix-x#401)

This is needed for probes like https://github.com/kevinakasam/KlackEnder-Probe

* fix for rsense on TMC5160 Z (Frix-x#490)

* Create stale action workflow (Frix-x#449)


Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

* fixed K-Shake&Tune integration

* Avoid cooling hotend in extruder_preheating Frix-x#495 (Frix-x#496)

* Add a park front macro for toolhead maintenance (Frix-x#494)

* Update MMU include order to allow overriding default HH defs (Frix-x#497)

* avoid led effect flashing on startup if leds desabled on startup (Frix-x#500)

* Added BTT SKR2 board template (Frix-x#503)

* fixed the regression introduced in startup call

* fix typo in stale.yml

* fixed probe pin for BTT_SB2209_RP2040_v1.0 (Frix-x#507)

* LDO Nitehawk MCU template and tachometer management (Frix-x#505)


Co-authored-by: Meindert <19568018+mvdveer@users.noreply.github.com>
Co-authored-by: Akash Patel <akashrpatel@yahoo.com>

* update primeline to make it adaptive (Frix-x#498)


Co-authored-by: Frédéric Beaucamp <88246672+fbeauKmi@users.noreply.github.com>
Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

* fixed missing adaptive primeline variable

* remplaced CANCEL_PRINT by PARK in the automated error management gcode

* fixed typo in LDO Nitehawk manufacturer template

* Add support for Manta_M5P v1.0 and 0.9 degree steppers on Trident Z axis (Frix-x#514)

* fix homing check for PARK in error gcode (Frix-x#513)

* fix typo in Fysetc_ERCF_ERB.cfg (Frix-x#519)

* Update BTT_Kraken_v1.0.cfg, RGB1 fix

listed as PF10, but should be PF12 (pf10 is mcu_min7 already, an endstop)

verified rest of pins as well

* reverted PARK and PARK_FRONT to fail if axis are not homed

* fix PARK with overriden param E (Frix-x#515)

* install and uninstall scripts improvement (Frix-x#511)

* Don't fail uninstall if the backup folder has been removed
* Make uninstall work when backup has sub-directories
* Make sure we don't fail making a backup when there is no current user config folder

* added Mellow Fly Gemini v3 MCU template (Frix-x#527)

* fix pinout for Fysetc_ERB board (Frix-x#530)

* updated homing_override to improve sensorless homing (Frix-x#531)

by using M400 vs the old 2 second dwell time that is not required anymore

* fixed v0_display pin and improved overrides docs (Frix-x#535)

* Update rpi_temp.cfg

Format with _ so a space is in the name, like other temps

* Update cabinet_temp.cfg

* switched to the new minimum_cruise_ratio Klipper parameter

* commented the default minimum_cruise_ratio to not break older Klipper versions

* added Beacon accelerometer support (Frix-x#552)

* Happy hare v2.5 merge (#8)

* make Klippain compatible with HH v2.5

* start print for HH > v2.5

* move HHv2.5 init in _KLIPPAIN_MMU_INIT

* add some info in mmu.md for 2.5

* add sync fonction with HH>2.5

* add eject slicer option for HH>2.5

* typo error

* Update end_print.cfg

Change EJECT to boolean for MMU_END

* show HH version on startup

* added custom4..9 in start_print (Frix-x#539)

* updated beeper sections (Frix-x#549)

by switching to pwm_cycle_time instead of output pin

* removed M204 in favor of SET_VELOCITY_LIMIT (Frix-x#555)

* support for LDO Picobilical (Frix-x#533)

* removed M204 for SET_VELOCITY_LIMIT (Frix-x#554)

* removed last M204 for SET_VELOCITY_LIMIT (Frix-x#553)

* added Beacon accelerometer support (Frix-x#552)

* deprecate HH<v2.5 and small typos

* removed old artifacts from TMC2240 init feature

Please use https://github.com/andrewmcgr/klipper_tmc_autotune instead!

* error on changes in _INIT_CHECK_MMU

---------

Co-authored-by: Benoitone <63300355+Benoitone@users.noreply.github.com>
Co-authored-by: Félix Boisselier <felix@fboisselier.fr>
Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com>
Co-authored-by: Colten Edwards <cd.edwards@sasktel.net>
Co-authored-by: Nick Danyluk <ndanyluk7@gmail.com>
Co-authored-by: Svennixx <xsvenhd@hotmail.com>

* Align hardware/mmu.cfg with upstream

* Update nozzle brushing to accomodate offset for situations in which standard nozzle brushing parameters lead to undesired interactions.

* Modify starting move prior to brush procedure to accomodate for brush_offset

* Fix brush center calculation

* Add some debugging messages

* ???

* Fixed brush stroke maths

* Removed unneccessary if statement

* Update Shake&Tune path

This is due to a change in Shake&Tune v3.0.0

---------

Co-authored-by: Surion79 <102791900+Surion79@users.noreply.github.com>
Co-authored-by: Félix Boisselier <felix@fboisselier.fr>
Co-authored-by: Benoitone <63300355+Benoitone@users.noreply.github.com>
Co-authored-by: Eric <saericzimmerman@gmail.com>
Co-authored-by: Devon Hazelett <dhazelett@users.noreply.github.com>
Co-authored-by: Gustavo Ribeiro Alves <145077902+gralves2@users.noreply.github.com>
Co-authored-by: Andrew Wickham <andrewwickham@westfieldgrp.com>
Co-authored-by: tehniemer <jrniemand@gmail.com>
Co-authored-by: Arsène Thieffry <arsene.thieffry@gmail.com>
Co-authored-by: claudioguareschi <33001685+claudioguareschi@users.noreply.github.com>
Co-authored-by: Elias Huwyler <elias.huwyler@gmail.com>
Co-authored-by: Elias Huwyler <elias.huwyler@ti8m.ch>
Co-authored-by: Neil Smith <8648114+nmsmith22389@users.noreply.github.com>
Co-authored-by: Reiner Uhry <24939566+reineruhry@users.noreply.github.com>
Co-authored-by: lokiagent <75763148+lokiagent@users.noreply.github.com>
Co-authored-by: Arcadien <aurelien.labrosse@gmail.com>
Co-authored-by: Tyler Olson <tolson@dlinc.io>
Co-authored-by: Felix Boisselier <f.boisselier@irepa-laser.com>
Co-authored-by: elpopo <68954733+elpopo-eng@users.noreply.github.com>
Co-authored-by: tsk-2222 <111063724+tsk-2222@users.noreply.github.com>
Co-authored-by: Meindert <19568018+mvdveer@users.noreply.github.com>
Co-authored-by: Akash Patel <akashrpatel@yahoo.com>
Co-authored-by: Frédéric Beaucamp <88246672+fbeauKmi@users.noreply.github.com>
Co-authored-by: Birkemosen <Birkemosen@users.noreply.github.com>
Co-authored-by: Magne Rasmussen <magne.rasmussen@gmail.com>
Co-authored-by: Parker <infowolfe@gmail.com>
Co-authored-by: Svennixx <xsvenhd@hotmail.com>
Co-authored-by: Colten Edwards <cd.edwards@sasktel.net>
Co-authored-by: Nick Danyluk <ndanyluk7@gmail.com>
ksummers92 added a commit to ksummers92/klippain that referenced this pull request Jun 22, 2024
@ksummers92 @meteyou
@Frix-x @Surion79 @Benoitone @EricZimmerman @dhazelett @gralves2 @tehniemer @aaarsene @claudioguareschi @Elias23 @nmsmith22389 @reineruhry @lokiagent @arcadien @tolson4 @elpopo-eng @tsk-2222 @mvdveer @akashrpatel @fbeauKmi @Birkemosen @magne @infowolfe @Svennixx @dev-aphex @Minims
Upstream main (#14)
5c86079 
* feat: add LDO Leviathan main board (Frix-x#365)

Signed-off-by: Stefan Dej <meteyou@gmail.com>

* fix fans pins in BTT_Manta_M8P_v2.0.cfg

* fix wrong LDO Leviathan cfg location

* added Octopus Pro v1.1 template (Frix-x#349) (Frix-x#367)

Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com>

* Fysetc Catalyst Config

* added respond on idle_timeout

* sherpa mini config (Frix-x#385)


Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

* switch moonraker update management to dev channel (Frix-x#390)

* Update orbiter2.0.cfg (Frix-x#405)

Add comment about required current. At the default of 0.45 on the Orbiter 2 motor, very poor performance will occur including significant underextrusion on infill, etc.

* chore(mcu): properly label CAN H/L (Frix-x#418)

TX and RX are not helpful, looking at the back of the m8p v2 shows that RX is high, and TX is low.

* added back the proper idle timeout behavior

* BTT S2DW V1.0 and similar RP2040 + lis2dw boards (Frix-x#439)

* Add Octopus Pro 1.0 MCU definition as duplicate of Octopus MCU

* fix typo in BTT_Octopus_Pro_v1.1.cfg (Frix-x#460)

* Turn on filter only if it was used during printing. (Frix-x#380)


Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com>

* added parameters to park (Frix-x#391)

* M8P v2.0 SPI fix (Frix-x#389)


Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

* Add per material filament sensor management (Frix-x#381)

* Remove _TIP_SHAPING from End/cancel print macros (Frix-x#357)


Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com>
Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

* Klipper SET_PRINT_STATS_INFO compatibility (Frix-x#392)


Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

* Fix error with turning on filter only if it was used during printing. (Frix-x#406)

Fix issue discovered after merging Frix-x#380

* fix missing variable to cancel_print (Frix-x#408)

* filament sensor status checks universal (Frix-x#411)

* proper Shake&Tune integration in Klippain

* add mellow SB2040 v2 and SB2040 Pro toolhead boards (Frix-x#417)

* correct overriders misspelling (Frix-x#425)

* check if heatsoak is configured to verbose message (Frix-x#424)

* typo

* Add pin definitions for Fysetc S6 V2.X

* add TR8x2 leadscrew config for trident

* Add older version of Fysetc mini12864 display

* HappyHare & other related dev (Frix-x#371)

* HappyHare MMU integration in Klippain

* Spoolman support

* Multiple MCU templates added or modified, especially MMU templates

* LED system rework to support the LED_effects plugin and rainbow barf, etc... ( Frix-x#416 )

* TMC Autotune moonraker updater predefined config (add your motor defs to your overrides.cfg or mcu.cfg)

---------

Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com>
Co-authored-by: claudioguareschi <33001685+claudioguareschi@users.noreply.github.com>
Co-authored-by: Félix Boisselier <felix@fboisselier.fr>
Co-authored-by: ksummers92 <66363414+ksummers92@users.noreply.github.com>

* fix status leds at startup (Frix-x#448)

* Status leds on startup fix

* display menu and V0 Display (Frix-x#420)

* Better display menu adapted to Klippain

* V0 display support

* Klippain boot logo

---------

Co-authored-by: Elias Huwyler <elias.huwyler@ti8m.ch>

* improved display management structure

* fixed MMU includes for HappyHare symlink

* Add BLTouch support (Frix-x#450)

* fixed nozzle and status led on/off.  (Frix-x#454)

* reverted update manager to main branch

* followed naming scheme for bltouch include as virtual

* moved the machine.cfg include and included additional thermistor defs

* Mellow fly super8 template (Frix-x#463)

* Support for TMC5160 on Z Axis (Frix-x#469)

* added fix to prevent issues when updating Klippain without MMU (Frix-x#462)

* Add configs for Fysetc SB Can TH boards (Frix-x#464)


Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

* fix: make prime line height a variable parameter (Frix-x#466)

Fix Frix-x#465

* fix for extrude when temperature is too low (Frix-x#480)

* Add BTT Kraken MCU support (Frix-x#476)

* Update Fysetc_Spider_v3.x.cfg to fix fan ports (Frix-x#474)

* fix BTT_MMB pin (Frix-x#486)

* added fix for rsense for TMC5160 (Frix-x#489)

* Add support for dockable probes with separate retainer (Frix-x#401)

This is needed for probes like https://github.com/kevinakasam/KlackEnder-Probe

* fix for rsense on TMC5160 Z (Frix-x#490)

* Create stale action workflow (Frix-x#449)


Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

* fixed K-Shake&Tune integration

* Avoid cooling hotend in extruder_preheating Frix-x#495 (Frix-x#496)

* Add a park front macro for toolhead maintenance (Frix-x#494)

* Update MMU include order to allow overriding default HH defs (Frix-x#497)

* avoid led effect flashing on startup if leds desabled on startup (Frix-x#500)

* Added BTT SKR2 board template (Frix-x#503)

* fixed the regression introduced in startup call

* fix typo in stale.yml

* fixed probe pin for BTT_SB2209_RP2040_v1.0 (Frix-x#507)

* LDO Nitehawk MCU template and tachometer management (Frix-x#505)


Co-authored-by: Meindert <19568018+mvdveer@users.noreply.github.com>
Co-authored-by: Akash Patel <akashrpatel@yahoo.com>

* update primeline to make it adaptive (Frix-x#498)


Co-authored-by: Frédéric Beaucamp <88246672+fbeauKmi@users.noreply.github.com>
Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

* fixed missing adaptive primeline variable

* remplaced CANCEL_PRINT by PARK in the automated error management gcode

* fixed typo in LDO Nitehawk manufacturer template

* Add support for Manta_M5P v1.0 and 0.9 degree steppers on Trident Z axis (Frix-x#514)

* fix homing check for PARK in error gcode (Frix-x#513)

* fix typo in Fysetc_ERCF_ERB.cfg (Frix-x#519)

* Update BTT_Kraken_v1.0.cfg, RGB1 fix

listed as PF10, but should be PF12 (pf10 is mcu_min7 already, an endstop)

verified rest of pins as well

* reverted PARK and PARK_FRONT to fail if axis are not homed

* fix PARK with overriden param E (Frix-x#515)

* install and uninstall scripts improvement (Frix-x#511)

* Don't fail uninstall if the backup folder has been removed
* Make uninstall work when backup has sub-directories
* Make sure we don't fail making a backup when there is no current user config folder

* added Mellow Fly Gemini v3 MCU template (Frix-x#527)

* fix pinout for Fysetc_ERB board (Frix-x#530)

* updated homing_override to improve sensorless homing (Frix-x#531)

by using M400 vs the old 2 second dwell time that is not required anymore

* fixed v0_display pin and improved overrides docs (Frix-x#535)

* Update rpi_temp.cfg

Format with _ so a space is in the name, like other temps

* Update cabinet_temp.cfg

* switched to the new minimum_cruise_ratio Klipper parameter

* commented the default minimum_cruise_ratio to not break older Klipper versions

* added Beacon accelerometer support (Frix-x#552)

* Update Shake&Tune path

This is due to a change in Shake&Tune v3.0.0

* fixed max_z bug in PARK macro

* Update BTT_SKR_2.cfg to fix EXP1_4 typo (Frix-x#578)

* Nozzle cleaning parameters update (Frix-x#569)

* add built in adxl sensor from nitehawk sb board (Frix-x#602)

* add: mcu Fystec Cheetah v3 (Frix-x#604)

---------

Signed-off-by: Stefan Dej <meteyou@gmail.com>
Co-authored-by: Stefan Dej <meteyou@gmail.com>
Co-authored-by: Félix Boisselier <felix@fboisselier.fr>
Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com>
Co-authored-by: Benoitone <63300355+Benoitone@users.noreply.github.com>
Co-authored-by: Eric <saericzimmerman@gmail.com>
Co-authored-by: Devon Hazelett <dhazelett@users.noreply.github.com>
Co-authored-by: Gustavo Ribeiro Alves <145077902+gralves2@users.noreply.github.com>
Co-authored-by: Andrew Wickham <andrewwickham@westfieldgrp.com>
Co-authored-by: tehniemer <jrniemand@gmail.com>
Co-authored-by: Arsène Thieffry <arsene.thieffry@gmail.com>
Co-authored-by: claudioguareschi <33001685+claudioguareschi@users.noreply.github.com>
Co-authored-by: Elias Huwyler <elias.huwyler@gmail.com>
Co-authored-by: Elias Huwyler <elias.huwyler@ti8m.ch>
Co-authored-by: Neil Smith <8648114+nmsmith22389@users.noreply.github.com>
Co-authored-by: Reiner Uhry <24939566+reineruhry@users.noreply.github.com>
Co-authored-by: lokiagent <75763148+lokiagent@users.noreply.github.com>
Co-authored-by: Arcadien <aurelien.labrosse@gmail.com>
Co-authored-by: Tyler Olson <tolson@dlinc.io>
Co-authored-by: Felix Boisselier <f.boisselier@irepa-laser.com>
Co-authored-by: elpopo <68954733+elpopo-eng@users.noreply.github.com>
Co-authored-by: tsk-2222 <111063724+tsk-2222@users.noreply.github.com>
Co-authored-by: Meindert <19568018+mvdveer@users.noreply.github.com>
Co-authored-by: Akash Patel <akashrpatel@yahoo.com>
Co-authored-by: Frédéric Beaucamp <88246672+fbeauKmi@users.noreply.github.com>
Co-authored-by: Birkemosen <Birkemosen@users.noreply.github.com>
Co-authored-by: Magne Rasmussen <magne.rasmussen@gmail.com>
Co-authored-by: Parker <infowolfe@gmail.com>
Co-authored-by: Svennixx <xsvenhd@hotmail.com>
Co-authored-by: dev-aphex <dev-aphex@users.noreply.github.com>
Co-authored-by: Minims <github@minims.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frix-x Frix-x Frix-x approved these changes

Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tehniemer @Frix-x @Surion79 @agravelot