-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1495] Stabilize CI tests #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay so this one is a messy one... It's mostly a result of me having a beer and poking around so there are lots of mistakes and experiments but hopefully we can see some good in it. On hindsight, I really should have broken this PR to smaller ones.
But some of the efforts were experimental and it was really hard to check if a solution worked when there were so many intermittent failures.
Any how, here are some scribbles of a mad man.
emitting working-tree-changed to sockets, manually triggered
. But from UI this was never received for whatever reason. Socket IO does make a claim about temporary failures, which makes sense.ungit.logger.info(...)
or useconst logger = require('../source/utils/logger');
to log out.ungit.__app
is now set tocomponents/app.js
. This is pretty handy for debugging.setApiListener(...)
is to wait for specific api calls and responses to ensure it is called and received expected responseclickOnNode(...)
for some clicks events,currentActionContext()
is expected to be set and this is to add check for itensureRedraw(...)
essentially waits for/gitlog
call to be made and responded, there for drawing git nodes