-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix intermittent test failures #1495
Comments
I know macos clicktests are very flaky with GitHub Actions. On travis (which we need to migrate to .com) they often pass like here https://travis-ci.org/github/FredrikNoren/ungit/builds/772284376. That's why I have added a retry for clicks in 934d152: ungit/clicktests/environment.js Lines 269 to 282 in d612c0f
But since I don't have a mac these issues are very hard to debug for me. |
I think number of tests has gotten bit out of control. I don't there is a much value in testing in so many node versions and OS versions. To me, node works on an OS, then it should be enough. This is because if a test fails on specific OS, then it's a library or node issue, not ungit issue. If we were to have tests within different browsers, then that would be helpful. But not various tests for different OSs. I think we should cut down on appveyor and travis and stick with github actions and make it stable |
# Conflicts: # components/stash/stash.js # package-lock.json # package.json
Closing this issues now. #1505 has more details on current state of click testing. While there are still some outstanding race conditions, tests has stabilized quite a lot. |
Test fails intermittently quite often and considering various combinations of tests we run, test usually never passes.
https://github.com/FredrikNoren/ungit/runs/4005712725?check_suite_focus=true
This maybe simple as doing more retries during tests
The text was updated successfully, but these errors were encountered: