Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1495] Stabilize CI tests #1505

Merged
merged 131 commits into from
Feb 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
131 commits
Select commit Hold shift + click to select a range
0db25e6
Hopefully tests are more stable now...
jung-kim Oct 27, 2021
58f275f
add few waits
jung-kim Oct 27, 2021
0477231
Add mo' waits...
jung-kim Oct 27, 2021
067e61a
mo' waits
jung-kim Oct 28, 2021
ce54630
mo' waits...
jung-kim Oct 29, 2021
a597487
mo' waits
jung-kim Oct 29, 2021
393a481
this is annoying...
jung-kim Oct 31, 2021
752a719
Hmmm
jung-kim Oct 31, 2021
102fe9e
Add proper wait
jung-kim Oct 31, 2021
71fb4c7
Bleh...
jung-kim Oct 31, 2021
7148c38
Adding more sleeps
jung-kim Oct 31, 2021
1ff903c
Add `waitForVisible()` and post commit trigger
jung-kim Oct 31, 2021
12c66b8
Using logger instance rather than default winston
jung-kim Oct 31, 2021
7e22d70
Code clean up and test fix
jung-kim Nov 1, 2021
4f63fe8
Add front end logging and click improvement
jung-kim Nov 2, 2021
690fb48
Add logs and hopefully spec.discard is fixed
jung-kim Nov 3, 2021
cfd7049
fixing few oopses
jung-kim Nov 3, 2021
6076da1
Add wait and mouse wiggle to trigger refreshes
jung-kim Nov 4, 2021
7758725
Add explicit wait
jung-kim Nov 4, 2021
dd7841d
Add util functions
jung-kim Nov 5, 2021
69484e7
Adding more event triggers
jung-kim Nov 5, 2021
b154cb7
Darn it!
jung-kim Nov 5, 2021
7892fe3
Shoot
jung-kim Nov 5, 2021
5eecaa1
test muteGraceTimeDuration to 2sec
jung-kim Nov 6, 2021
7ec5445
few updates
jung-kim Nov 6, 2021
2717601
I'm bit confused...
jung-kim Nov 6, 2021
04dd3c2
Add some timeouts
jung-kim Nov 6, 2021
6e38354
Trying dynamic time out for discards
jung-kim Nov 6, 2021
12d7168
add debug line
jung-kim Nov 6, 2021
13bd4db
Bah
jung-kim Nov 6, 2021
5989915
Merge branch 'master' into #1495
jung-kim Dec 4, 2021
bb4c359
Finally back from vacation!!!
jung-kim Dec 4, 2021
10b3d55
Add more timeout and style fix
jung-kim Dec 4, 2021
85d45ec
Add more timeouts
jung-kim Dec 5, 2021
fd778d9
add more timeouts
jung-kim Dec 5, 2021
dc1a91a
increase timeout
jung-kim Dec 12, 2021
8cbce9e
Using simpler way waitForVisible
jung-kim Dec 12, 2021
65aaf4f
Simplified port finder
jung-kim Dec 14, 2021
6663d83
Using returned selector at click
jung-kim Dec 15, 2021
c619bc7
Bump up unittest timeout
jung-kim Dec 15, 2021
e9a794b
bloody hell
jung-kim Dec 15, 2021
250dea1
Trying scrollintoview
jung-kim Dec 16, 2021
3104259
Waiting for network idle
jung-kim Dec 16, 2021
af04b0d
bleh
jung-kim Dec 16, 2021
8af2123
Increasing grace timeperiod as added more waits
jung-kim Dec 16, 2021
81f9116
Sprinkle in more wait for network idle
jung-kim Dec 16, 2021
84801e4
More wait for network idle!
jung-kim Dec 17, 2021
6f342b0
Getting better
jung-kim Dec 17, 2021
e8fe73a
add another wait
jung-kim Dec 17, 2021
611d71b
Change most wait to network idle as it would be more efficient
jung-kim Dec 17, 2021
26f9979
Merge branch 'master' into #1495
jung-kim Dec 17, 2021
692beb6
Add more network idle checks
jung-kim Dec 18, 2021
298b5a3
WTF is this...?
jung-kim Dec 18, 2021
8d317f3
Adding trigger after refations
jung-kim Dec 20, 2021
cc7e583
Add more coordinations
jung-kim Dec 21, 2021
ea0975c
Apply suggestions from code review
jung-kim Dec 22, 2021
2145024
few fixes
jung-kim Dec 22, 2021
5450523
upgrade npm
jung-kim Jan 11, 2022
dd0166d
Removing wait for network idles and manual triggers
jung-kim Jan 11, 2022
f338219
Add root components
jung-kim Jan 12, 2022
9dac112
experiment
jung-kim Jan 12, 2022
e5d0170
replace `git-directory-changed`
jung-kim Jan 14, 2022
6928729
fixing loggings
jung-kim Jan 14, 2022
e0044e1
Few more fixes
jung-kim Jan 15, 2022
1837351
Formatting
jung-kim Jan 15, 2022
05b821e
Oops
jung-kim Jan 15, 2022
0fb223c
more error handlings
jung-kim Jan 16, 2022
a1aa895
Change on program events to asyncs awaits
jung-kim Jan 16, 2022
d658469
add ensure event refresh func
jung-kim Jan 17, 2022
9283335
fix dialog and add ensure refresh
jung-kim Jan 19, 2022
c1f921e
fix events getting skipped
jung-kim Jan 20, 2022
a03e107
Fix to use ComponentRoot
jung-kim Jan 21, 2022
3b8b973
Fixes for remotes and branches
jung-kim Jan 22, 2022
860c119
submodule fix and clean up
jung-kim Jan 23, 2022
f7af605
Formatting and add ensure refresh for branch
jung-kim Jan 23, 2022
9640018
Few more fixes
jung-kim Jan 25, 2022
9b79019
Adding ensureRefresh() to create file
jung-kim Jan 25, 2022
296a4d0
Add conditional check for page
jung-kim Jan 25, 2022
4c9d520
Fix discard and submodules
jung-kim Jan 26, 2022
23a0016
Adding waits so Knockout bindings have time to properly initialize
jung-kim Jan 27, 2022
0fe7204
styling fix
jung-kim Jan 27, 2022
4e52def
add loggings
jung-kim Jan 27, 2022
ca9afa1
npm run lint
jung-kim Jan 27, 2022
13c7db3
new modal
jung-kim Jan 28, 2022
2a3c7e0
Better build and more modals
jung-kim Jan 29, 2022
956399b
modalForms and modalPromts
jung-kim Jan 30, 2022
df1e0ef
Few fixes and more conversions
jung-kim Jan 30, 2022
6e9ff5d
Fix tests
jung-kim Jan 31, 2022
afac3cd
Merge branch 'master' into tew
jung-kim Jan 31, 2022
5826f72
Fix tests
jung-kim Jan 31, 2022
ebcab28
fix build and merge fixes
jung-kim Feb 1, 2022
be829ef
add try catch for exec npm publish
jung-kim Feb 3, 2022
82c629e
Finalize modals
jung-kim Feb 3, 2022
a3d56bb
Add click func check
jung-kim Feb 3, 2022
0a26f48
Removing old dialogs and check for click events
jung-kim Feb 4, 2022
9808f7e
Revert `ensureClickEventIsBound` and add debug
jung-kim Feb 4, 2022
fceeb81
more reverts
jung-kim Feb 4, 2022
543d0b4
This is me giving up
jung-kim Feb 5, 2022
8e09d51
Adding app to ungit and better api call assert
jung-kim Feb 5, 2022
f8347e5
Change to api response
jung-kim Feb 6, 2022
ac2e0f2
Replace nprogress wait with api response
jung-kim Feb 8, 2022
ee78b92
Lint
jung-kim Feb 9, 2022
0b4d790
ensureRefresh to be more verbose
jung-kim Feb 10, 2022
a60c5a2
going back
jung-kim Feb 10, 2022
4db8a6c
add some timeouts and increase unittest timeout
jung-kim Feb 10, 2022
f2198c7
Checking for response body
jung-kim Feb 10, 2022
5ffd5d7
Graph to redraw on working-tree-changed
jung-kim Feb 11, 2022
d9efee2
Better way of doing api listener
jung-kim Feb 12, 2022
d132258
Add debug message and some cleanups
jung-kim Feb 12, 2022
a8d03bd
more debug
jung-kim Feb 12, 2022
1a8c88e
more debug
jung-kim Feb 12, 2022
526b27b
(╯°□°)╯︵ ┻━┻
jung-kim Feb 12, 2022
c7e7d46
clean up and add sleep
jung-kim Feb 12, 2022
aa36919
Lint
jung-kim Feb 13, 2022
eae5094
Cleaning up ensure refresh()
jung-kim Feb 13, 2022
390e52d
cleaning up ensureRefresh() pt2
jung-kim Feb 13, 2022
9069971
Add timeout to submodule test and more cleanup
jung-kim Feb 13, 2022
bf5fc3c
Update to individual throttling at components pt1
jung-kim Feb 13, 2022
b8f05eb
Update to individual throttling at components pt2
jung-kim Feb 13, 2022
5c19de3
Add retries to the unittests
jung-kim Feb 17, 2022
e74101d
Proper close
jung-kim Feb 18, 2022
d2680f5
Lint and and ensure branches fetch on first load
jung-kim Feb 19, 2022
32bbef7
Add debug
jung-kim Feb 19, 2022
4bf8e0d
Add check for origin remote set
jung-kim Feb 20, 2022
964f4ad
Add more timeouts for init to finish
jung-kim Feb 20, 2022
4bf9ddf
Lint...
jung-kim Feb 20, 2022
c735aaa
Regenerate package-lock.json and revert unittest revert
jung-kim Feb 21, 2022
0b690bd
Remove timeouts from unittest and add wait after ref dialog open
jung-kim Feb 21, 2022
b7f5fb1
Increase timeout for unittest
jung-kim Feb 21, 2022
49ec7b8
remove debugs add retries for auth clicktests
jung-kim Feb 21, 2022
32e6f86
Add error logging
jung-kim Feb 24, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
{
"root": true,
"extends": ["eslint:recommended", "plugin:prettier/recommended"],
"extends": [
"eslint:recommended",
"plugin:prettier/recommended"
],
"parserOptions": {
"ecmaVersion": 2020
},
Expand All @@ -10,8 +13,19 @@
},
"rules": {
"array-callback-return": "error",
"no-unused-vars": ["error", { "args": "none" }],
"no-unused-vars": [
"error",
{
"args": "none"
}
],
"prefer-const": "warn",
"quotes": ["warn", "single", { "avoidEscape": true }]
"quotes": [
"warn",
"single",
{
"avoidEscape": true
}
]
}
}
}
6 changes: 3 additions & 3 deletions .mochaclicktest.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"spec": "clicktests/spec.*.js",
"file": "./source/utils/winston.js",
"timeout": 35000,
"file": "./source/utils/logger.js",
"timeout": 20000,
"bail": true,
"exit": true
}
}
6 changes: 3 additions & 3 deletions .mochatest.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"spec": "test/spec.*.js",
"file": "./source/utils/winston.js",
"timeout": 5000,
"file": "./source/utils/logger.js",
"timeout": 12000,
"exit": true
}
}
9 changes: 2 additions & 7 deletions bin/credentials-helper
Original file line number Diff line number Diff line change
@@ -1,22 +1,17 @@
#!/usr/bin/env node
const winston = require('../source/utils/winston');
const http = require('http');
const socketId = process.argv[2];
const portAndRootPath = process.argv[3];
const remote = process.argv[4];
const action = process.argv[5];

winston.info(`Credentials helper invoked; portAndRootPath:${portAndRootPath} socketId:${socketId}`);

if (action == 'get') {
winston.info('Getting credentials');
http
.get(
`http://localhost:${portAndRootPath}/api/credentials?socketId=${socketId}&remote=${encodeURIComponent(
remote
)}`,
(res) => {
winston.info('Got credentials');
let rawData = '';
res.on('data', (chunk) => {
rawData += chunk;
Expand All @@ -29,8 +24,8 @@ if (action == 'get') {
}
)
.on('error', (err) => {
winston.error("Error getting credentials, couldn't query server", err);
console.error("Error getting credentials, couldn't query server", err);
});
} else {
winston.info(`Unhandled action: ${action}`);
console.info(`Unhandled action: ${action}`);
}
1 change: 0 additions & 1 deletion bin/ungit
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
const startLaunchTime = Date.now();

// eslint-disable-next-line no-unused-vars -- Imported for side effects
const winston = require('../source/utils/winston');
const config = require('../source/config');
const open = require('open');
const path = require('path');
Expand Down
Loading