Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create README files at assay folder level, and clean up inst/ folder #233

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from
Open

Create README files at assay folder level, and clean up inst/ folder #233

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
576036b
add README creation to use_visc_report()
kelliemac Sep 4, 2024
790e2af
remove README creation from visc_pdf_document and visc_word_document
kelliemac Sep 4, 2024
39efc4b
save README at assay level
kelliemac Sep 4, 2024
cf986e5
Update NEWS.md
kelliemac Sep 4, 2024
7397051
add back report level READMEs but with different naming convention to…
kelliemac Jan 10, 2025
87880ef
clarify when and how assay level readme is created
kelliemac Jan 10, 2025
7867acc
rename assay level readme and fix formatting of report history table
kelliemac Jan 10, 2025
35adacc
Update assay_level_README_template.md
kelliemac Jan 10, 2025
ae1a821
Update assay_level_README_template.md
kelliemac Jan 10, 2025
27299d5
Update assay_level_README_template.md
kelliemac Jan 10, 2025
9ba9ff6
Create report_level_README_template.md
kelliemac Jan 10, 2025
bcbac1c
reorganize inst folder
kelliemac Jan 10, 2025
263763f
update news
kelliemac Jan 10, 2025
15cdaf9
revert unintentional change to VISCtemplates.Rproj
kelliemac Jan 10, 2025
6e57c0c
reorganize inst
kelliemac Jan 10, 2025
ed9a038
make everything work with the new inst folder organization
kelliemac Jan 11, 2025
e01e009
move use_visc_readme back to original location
kelliemac Jan 11, 2025
40108c8
simplify some of the changes
kelliemac Jan 11, 2025
3305baf
simplify PR even more
kelliemac Jan 11, 2025
23e66d7
rename some files
kelliemac Jan 11, 2025
c272617
simplify code changes
kelliemac Jan 11, 2025
7ad5a7a
resolve merge conflicts with develop
kelliemac Jan 11, 2025
91e43c3
actually finish resolving the merge conflict
kelliemac Jan 11, 2025
3be81bf
update project readme to describe where files are located
kelliemac Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
actually finish resolving the merge conflict
  • Loading branch information
@kelliemac
kelliemac committed Jan 11, 2025
commit 91e43c3bd99c2b9f436cb5d36c4206a55ebe8ea1
4 changes: 0 additions & 4 deletions R/use_visc_report.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ use_visc_report <- function(report_name = "VDCnnn_assay_PTreport",
usethis::ui_done(
glue::glue("Created {{report_type}} VISC report at '{{file.path(path, report_name)}}'")
)
<<<<<<< HEAD

# create readme for report folder
usethis::use_template(
Expand All @@ -186,9 +185,6 @@ use_visc_report <- function(report_name = "VDCnnn_assay_PTreport",

# add draft methods
if (report_type != 'empty'){
=======
if (report_type != 'empty') {
>>>>>>> develop
use_visc_methods(path = file.path(path, report_name), assay = report_type,
interactive = interactive)
}
Expand Down
Loading