-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create README files at assay folder level, and clean up inst/ folder #233
base: develop
Are you sure you want to change the base?
Conversation
@mayerbry to review this PR! Alicia gave verbal approval at our meeting today. |
Per group discussion on 1/7, ok to move templated README to assay level, and also create a blank README file for each report. |
… distinguish from assay level READMEs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #233 +/- ##
===========================================
+ Coverage 82.10% 82.50% +0.39%
===========================================
Files 8 8
Lines 352 360 +8
===========================================
+ Hits 289 297 +8
Misses 63 63 ☔ View full report in Codecov by Sentry. |
since I moved around some of the relevant files, I will go ahead and address #241 now too |
I also added a note about using git tags instead of hashes, in line with #238 |
@mayerbry and @slager can you please review this PR when you have a chance? I increased the scope a little bit because I got frustrated with the organization of files in the please focus on the following in your review:
thank you!!! |
Description
Instead of creating a README file for each PT report at the time of knitting to visc_pdf_document or visc_word_document, the README file will now be at the assay level and created at the first time that use_visc_report() is called within an assay folder.
Related Issues
Related to #92
Checklist
devtools::document