create NNlibCUDA sub-package #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarloLucibello
commented
Mar 6, 2021
CarloLucibello
commented
Mar 6, 2021
|
@DhairyaLGandhi could you add buildkite to the repo and get rid of AppVeyor? |
|
Tests are passing locally on top of JuliaGPU/CUDA.jl#753. This is pretty much done. Before merging, we should test it against JuliaGPU/CUDA.jl#753 (once it is merged in master) using buildkite (bump on @DhairyaLGandhi for activating it) |
|
CUDA master removed NNlib, we should hurry up with this. @DhairyaLGandhi can you activate buildkite for this repo? |
CarloLucibello
commented
Mar 11, 2021
This was referenced Mar 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to discussion in JuliaGPU/CUDA.jl#738 and on zulip.
The idea is to create a package within the same repo of NNlib.jl to make maintenance easier.
This a port and factorization of the nnlib.jl file and related in CUDA.jl, so that CUDA.jl can drop the NNlib dependence (pr JuliaGPU/CUDA.jl#753)
Besides this PR, Flux.jl should remove the dependence on
CUDA.batchnormand use the new cudnn wrapper interface.The CI pipeline is copied from https://github.com/JuliaGPU/KernelAbstractions.jl
cc @maleadt @denizyuret
THINGS TO DO AFTER MERGE: