-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove NNlib #753
remove NNlib #753
Conversation
cuDNN introduced a new interface which I wrapped in CUDA/lib/cudnn/normalization.jl. They still support the old interface though, so feel free to move batchnorm.jl to whereever needed. |
this should be ready. @denizyuret could you take a look and see I didn't remove too much stuff? |
Looks good to me. I assume you are moving these to whereever they are needed? (NNlibCUDA, Flux etc) |
yes. @maleadt this should be ready (assuming the buildkite's julia 1.6 debug fail is unrelated) |
Thanks! That failure is unrelated, and should be addressed by #756. Let's merge this after that PR. |
This functionality is now available under the NNlibCUDA subpackage of NNlib.jl
Codecov Report
@@ Coverage Diff @@
## master #753 +/- ##
==========================================
- Coverage 78.78% 78.20% -0.58%
==========================================
Files 124 121 -3
Lines 7512 7245 -267
==========================================
- Hits 5918 5666 -252
+ Misses 1594 1579 -15
Continue to review full report at Codecov.
|
remove dependence on NNlib.jl as discussed in different places.
Most stuff removed will end up in FluxML/NNlib.jl#286
@denizyuret should the
batchnorm
function stay or go?