-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cuda 3.0 support #1571
Cuda 3.0 support #1571
Conversation
@jonathan-laurent @maleadt could you confirm that this branch works fine for AlphaZero and CUDA 3. And also whether you've tested the subpackage from FluxML/NNlib.jl#286 |
you can test the NNlibCUDA´s subpackage with
|
It´s a bit tricky to support both julia 1.5 and julia 1.6 at this point (NNlibCUDA requires julia 1.6). Should we drop julia 1.6 support? |
the Manifest here is adding CUDA 2.6 actually |
Now that we have device overrides, |
What exactly should I do to test this? I tried the following without success:
|
You'd need to check out a local copy and instantiate the manifest in the branch. You also need https://github.com/FluxML/NNlibCUDA.jl |
AlphaZero.jl works fine with CUDA 3.0 and this branch. |
I think this is good to go, anyone have thoughts? |
the NNlibCUDA compat bound is missing and the Manifest could be removed. Beside that, looks good! |
Thanks, added the bound, and I'd like to keep the manifest around for now, so I think we are good to go here. |
Is the plan to merge this in the next minor release of Flux? (I imagine this cannot be part of a patch release if you are dropping support for Julia <1.6). |
Yeah, I was considering merging and releasing it now. Its allowed within semver to limit Julia versions, and we aren't breaking any Flux API so we are good. Any downstream breaking changes would need depending on CUDA explicitly so we are covered with a patch release. |
Its not a blocker, but good to have it be complete. On 1.6 (which is what Flux will bump Julia to), we should see the correct bounds. |
cc @maleadt , @jonathan-laurent