Fixed IL Weaver for prediction failing #962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thod inside a .asmdef'd project
|
Does not look like it has been yet, thank you! |
|
I upgraded fishnet and I can confirm the issue is still present, where this PR does fix it |
|
Added in 4.6.13, thanks! |
FirstGearGames
pushed a commit
that referenced
this pull request
Sep 28, 2025
- Fixed scenes unloading on host when other clients were still loading the scene. - Fixed NetworkTransform incorrectly marking very small movements as sent #930. - Fixed NetworkTrafficStatistics NullReferenceException affecting users perhaps with invalid Library caches #963. - Fixed predicted spawning Ids being added twice for clientHost #933. - Fixed IsKinematic not being applied from RigidbodyState/2D #960 - Fixed codegen failing prediction method generation related to assembly definitions #962. - Fixed space introduced within links in commented code #964. - Added PredictionManager.ReduceReconcilesWithFramerate. - Added PredictoinManager.MinimumClientReconcileFramerate. - Added detection for duplicate DefaultPrefabObject collections. - Added implicit operator for NetworkBahviour to NetworkObjet #967.
FirstGearGames
pushed a commit
that referenced
this pull request
Sep 28, 2025
- Fixed scenes unloading on host when other clients were still loading the scene. - Fixed NetworkTransform incorrectly marking very small movements as sent #930. - Fixed NetworkTrafficStatistics NullReferenceException affecting users perhaps with invalid Library caches #963. - Fixed predicted spawning Ids being added twice for clientHost #933. - Fixed IsKinematic not being applied from RigidbodyState/2D #960 - Fixed codegen failing prediction method generation related to assembly definitions #962. - Fixed space introduced within links in commented code #964. - Added PredictionManager.ReduceReconcilesWithFramerate. - Added PredictoinManager.MinimumClientReconcileFramerate. - Added detection for duplicate DefaultPrefabObject collections. - Added implicit operator for NetworkBahviour to NetworkObjet #967.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed IL Weaver for prediction failing when compiling a prediction method inside a .asmdef'd project
There is a extremely small, I really mean miniscule chance that it's been fixed already since I'm on a month old release, but let's not kid ourselves, no one wants to touch IL weaving code, so I doubt it.
Anyways this fixed a building issue I had with my project, all the replication methods were in a .asmdeffed project. After adding some imports it all builds fine.