Avoid using problematic rspec-mocks 3.11.2 #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version of rspec-mocks breaks CI for Ruby 2.7, 3.0 and 3.1 on the following tests: * ./spec/datadog/core/configuration_spec.rb:377 (Ruby 2.7) * ./spec/datadog/core_spec.rb:35 (Ruby 2.7) * ./spec/ddtrace/transport/http/builder_spec.rb:250 (Ruby 3.0, 3.1) References: * <https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/7560/workflows/24205733-d9fb-4781-962c-87499bad162d/jobs/280394> * <https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/7560/workflows/24205733-d9fb-4781-962c-87499bad162d/jobs/280387> * <https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/7560/workflows/24205733-d9fb-4781-962c-87499bad162d/jobs/280396> I have not yet reported this upstream, but wanted to first unblock our CI.
We already have something similar on the `Gemfile` for the gem but did not copy it to the integration apps. Bundler on Ruby 2.2 gets confused sometimes and tries to install a more modern `byebug`/`pry-byebug` than it should: <https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/7563/workflows/84415e5e-c561-4312-8e18-ff4d59394471/jobs/280478>
ivoanjo
force-pushed
the
ivoanjo/fix-ci-issue
branch
from
720611d
to
99aa6cc
Compare
|
For some reason, the Ruby 2.2 integration app started complaining about byebug. I assume that maybe it had something cached, and this change "disturbed" the cache, so I did a tiny fix for that as well. |
This was referenced Oct 25, 2022
Merged
lloeki
added a commit
that referenced
this pull request
Oct 26, 2022
ivoanjo
added a commit
that referenced
this pull request
Oct 27, 2022
The same issue we ran into in #2327 is present on the newly-released rspec-mocks 3.12.0. I have not yet reported this upstream, but want to unblock our CI.
lloeki
pushed a commit
that referenced
this pull request
Oct 27, 2022
The same issue we ran into in #2327 is present on the newly-released rspec-mocks 3.12.0. I have not yet reported this upstream, but want to unblock our CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a restriction on our
Gemfile(only used for testing) to not userspec-mocks3.11.2.Motivation
This version of rspec-mocks breaks CI for Ruby 2.7, 3.0 and 3.1 on the following tests:
References:
Additional Notes
I have not yet reported this upstream, but wanted to first unblock our CI.
How to test the change?
Validate that CI is green.