Workaround issue with rspec-mocks 3.12.0 #2337
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same issue we ran into in #2327 is present on the newly-released rspec-mocks 3.12.0. I have not yet reported this upstream, but want to unblock our CI.
TonyCTHsu
approved these changes
Oct 27, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The same issue we ran into in #2327 is present on the newly-released rspec-mocks 3.12.0.
This PR adds a restriction on our
Gemfile(only used for testing) to not userspec-mocks3.12.2.Motivation
This version of rspec-mocks breaks CI for Ruby 2.7, 3.0 and 3.1 on the following tests:
References:
Additional Notes
I have not yet reported this upstream, but wanted to first unblock our CI.
How to test the change?
Validate that CI is green.