-
Notifications
You must be signed in to change notification settings - Fork 469
chore(telemetry): add item for instrumentation config id #8783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksBenchmark execution time: 2024-03-26 21:02:18 Comparing candidate commit 7308171 in PR branch Found 11 performance improvements and 14 performance regressions! Performance is the same for 176 metrics, 9 unstable metrics. scenario:coreapiscenario-context_with_data_listeners_and_all_listeners
scenario:coreapiscenario-context_with_data_only_all_listeners
scenario:coreapiscenario-core_dispatch_with_results_listeners
scenario:coreapiscenario-core_dispatch_with_results_only_all_listeners
scenario:httppropagationextract-b3_headers
scenario:httppropagationextract-datadog_tracecontext_tracestate_propagated_on_trace_id_match
scenario:httppropagationextract-tracecontext_headers
scenario:httppropagationextract-wsgi_empty_headers
scenario:httppropagationextract-wsgi_valid_headers_basic
scenario:httppropagationinject-with_all
scenario:httppropagationinject-with_dd_origin
scenario:httppropagationinject-with_priority_and_origin
scenario:httppropagationinject-with_sampling_priority
scenario:httppropagationinject-with_tags
scenario:httppropagationinject-with_tags_max_size
scenario:otelspan-start-finish
scenario:otelspan-start-finish-telemetry
scenario:sethttpmeta-obfuscation-regular-case-implicit-query
scenario:sethttpmeta-obfuscation-send-querystring-disabled
scenario:sethttpmeta-obfuscation-worst-case-implicit-query
scenario:sethttpmeta-useragentvariant_not_exists_2
scenario:span-start-finish
scenario:tracer-large
scenario:tracer-medium
scenario:tracer-small
|
7308171 to
3147431
Compare
Same as DataDog/dd-trace-py#8783 but for Java.
When enabling library injection remotely, we'd like to see which services have been instrumented as a result. To do this we are proposing to submit the configuration ID that was used to instrument the service.
0111a57 to
8b1320b
Compare
Datadog ReportBranch report: ✅ 0 Failed, 498 Passed, 6 Skipped, 0s Wall Time |
* feat(telemetry): adding instrumentation_config_id Similar to DataDog/dd-trace-py#8783
* feat(telemetry): adding instrumentation_config_id Similar to DataDog/dd-trace-py#8783
* feat(telemetry): adding instrumentation_config_id Similar to DataDog/dd-trace-py#8783
* feat(telemetry): adding instrumentation_config_id Similar to DataDog/dd-trace-py#8783
* feat(telemetry): adding instrumentation_config_id Similar to DataDog/dd-trace-py#8783
* feat(telemetry): adding instrumentation_config_id Similar to DataDog/dd-trace-py#8783
* feat(telemetry): adding instrumentation_config_id Similar to DataDog/dd-trace-py#8783
When enabling library injection remotely through the UI, we'd like to show which
services have been instrumented as a result. To do this we are proposing
to submit the remote configuration ID that was used to instrument the service.
Checklist
changelog/no-changelogis set@DataDog/apm-tees.@DataDog/security-design-and-guidance.Reviewer Checklist