Skip to content

Conversation

@Kyle-Verhoog
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog commented Mar 26, 2024

When enabling library injection remotely through the UI, we'd like to show which
services have been instrumented as a result. To do this we are proposing
to submit the remote configuration ID that was used to instrument the service.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@pr-commenter
Copy link

pr-commenter bot commented Mar 26, 2024

Benchmarks

Benchmark execution time: 2024-03-26 21:02:18

Comparing candidate commit 7308171 in PR branch kylev/install-source with baseline commit 9707da1 in branch main.

Found 11 performance improvements and 14 performance regressions! Performance is the same for 176 metrics, 9 unstable metrics.

scenario:coreapiscenario-context_with_data_listeners_and_all_listeners

  • 🟩 max_rss_usage [-802.590KB; -730.952KB] or [-3.657%; -3.331%]

scenario:coreapiscenario-context_with_data_only_all_listeners

  • 🟥 max_rss_usage [+681.639KB; +763.839KB] or [+3.219%; +3.607%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

  • 🟥 max_rss_usage [+677.382KB; +754.170KB] or [+3.201%; +3.564%]

scenario:coreapiscenario-core_dispatch_with_results_only_all_listeners

  • 🟩 max_rss_usage [-784.103KB; -712.985KB] or [-3.581%; -3.256%]

scenario:httppropagationextract-b3_headers

  • 🟩 max_rss_usage [-733.340KB; -503.243KB] or [-3.356%; -2.303%]

scenario:httppropagationextract-datadog_tracecontext_tracestate_propagated_on_trace_id_match

  • 🟩 max_rss_usage [-769.952KB; -559.200KB] or [-3.519%; -2.556%]

scenario:httppropagationextract-tracecontext_headers

  • 🟩 max_rss_usage [-720.678KB; -619.533KB] or [-3.300%; -2.837%]

scenario:httppropagationextract-wsgi_empty_headers

  • 🟥 max_rss_usage [+520.950KB; +726.692KB] or [+2.466%; +3.441%]

scenario:httppropagationextract-wsgi_valid_headers_basic

  • 🟥 max_rss_usage [+689.523KB; +779.713KB] or [+3.257%; +3.683%]

scenario:httppropagationinject-with_all

  • 🟥 max_rss_usage [+704.133KB; +758.958KB] or [+3.337%; +3.596%]

scenario:httppropagationinject-with_dd_origin

  • 🟥 max_rss_usage [+683.756KB; +737.146KB] or [+3.242%; +3.495%]

scenario:httppropagationinject-with_priority_and_origin

  • 🟥 max_rss_usage [+690.554KB; +746.732KB] or [+3.275%; +3.542%]

scenario:httppropagationinject-with_sampling_priority

  • 🟥 max_rss_usage [+713.370KB; +760.371KB] or [+3.380%; +3.603%]

scenario:httppropagationinject-with_tags

  • 🟥 max_rss_usage [+733.048KB; +783.701KB] or [+3.483%; +3.723%]

scenario:httppropagationinject-with_tags_max_size

  • 🟥 max_rss_usage [+713.955KB; +766.339KB] or [+3.386%; +3.634%]

scenario:otelspan-start-finish

  • 🟩 max_rss_usage [-759.965KB; -684.284KB] or [-3.286%; -2.959%]

scenario:otelspan-start-finish-telemetry

  • 🟥 max_rss_usage [+960.218KB; +1033.715KB] or [+4.331%; +4.662%]

scenario:sethttpmeta-obfuscation-regular-case-implicit-query

  • 🟥 max_rss_usage [+628.498KB; +782.165KB] or [+2.906%; +3.617%]

scenario:sethttpmeta-obfuscation-send-querystring-disabled

  • 🟥 max_rss_usage [+715.043KB; +783.683KB] or [+3.305%; +3.622%]

scenario:sethttpmeta-obfuscation-worst-case-implicit-query

  • 🟥 max_rss_usage [+669.950KB; +746.446KB] or [+3.094%; +3.448%]

scenario:sethttpmeta-useragentvariant_not_exists_2

  • 🟩 max_rss_usage [-742.999KB; -663.567KB] or [-3.356%; -2.998%]

scenario:span-start-finish

  • 🟩 max_rss_usage [-688.276KB; -611.795KB] or [-3.146%; -2.797%]

scenario:tracer-large

  • 🟩 max_rss_usage [-766.914KB; -694.949KB] or [-3.355%; -3.041%]

scenario:tracer-medium

  • 🟩 max_rss_usage [-782.771KB; -701.620KB] or [-3.589%; -3.217%]

scenario:tracer-small

  • 🟩 max_rss_usage [-727.756KB; -664.065KB] or [-3.334%; -3.042%]

@Kyle-Verhoog Kyle-Verhoog force-pushed the kylev/install-source branch from 7308171 to 3147431 Compare April 22, 2024 18:36
@Kyle-Verhoog Kyle-Verhoog added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 22, 2024
@Kyle-Verhoog Kyle-Verhoog changed the title chore: add telemetry item for instrumentation config id chore(telemetry): add telemetry item for instrumentation config id Apr 22, 2024
@Kyle-Verhoog Kyle-Verhoog changed the title chore(telemetry): add telemetry item for instrumentation config id chore(telemetry): add item for instrumentation config id Apr 22, 2024
@Kyle-Verhoog Kyle-Verhoog changed the title chore(telemetry): add item for instrumentation config id chore(telemetry): add item for instrumentation config id Apr 22, 2024
Kyle-Verhoog added a commit to DataDog/dd-trace-java that referenced this pull request Apr 29, 2024
stanistan added a commit to stanistan/dd-trace-js that referenced this pull request Apr 30, 2024
@Kyle-Verhoog Kyle-Verhoog marked this pull request as ready for review May 1, 2024 09:55
@Kyle-Verhoog Kyle-Verhoog requested a review from a team as a code owner May 1, 2024 09:55
@Kyle-Verhoog Kyle-Verhoog requested a review from emmettbutler May 1, 2024 09:55
When enabling library injection remotely, we'd like to see which
services have been instrumented as a result. To do this we are proposing
to submit the configuration ID that was used to instrument the service.
@Kyle-Verhoog Kyle-Verhoog force-pushed the kylev/install-source branch from 0111a57 to 8b1320b Compare May 2, 2024 12:55
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented May 2, 2024

Datadog Report

Branch report: kylev/install-source
Commit report: 7df4ebe
Test service: dd-trace-py

✅ 0 Failed, 498 Passed, 6 Skipped, 0s Wall Time

@Kyle-Verhoog Kyle-Verhoog enabled auto-merge (squash) May 2, 2024 23:01
@Kyle-Verhoog Kyle-Verhoog merged commit faedc35 into main May 2, 2024
@Kyle-Verhoog Kyle-Verhoog deleted the kylev/install-source branch May 2, 2024 23:23
stanistan added a commit to DataDog/dd-trace-js that referenced this pull request May 6, 2024
stanistan added a commit to DataDog/dd-trace-js that referenced this pull request May 9, 2024
* feat(telemetry): adding instrumentation_config_id

Similar to DataDog/dd-trace-py#8783
rochdev pushed a commit to DataDog/dd-trace-js that referenced this pull request May 14, 2024
* feat(telemetry): adding instrumentation_config_id

Similar to DataDog/dd-trace-py#8783
rochdev pushed a commit to DataDog/dd-trace-js that referenced this pull request May 14, 2024
* feat(telemetry): adding instrumentation_config_id

Similar to DataDog/dd-trace-py#8783
rochdev pushed a commit to DataDog/dd-trace-js that referenced this pull request May 14, 2024
* feat(telemetry): adding instrumentation_config_id

Similar to DataDog/dd-trace-py#8783
rochdev pushed a commit to DataDog/dd-trace-js that referenced this pull request May 14, 2024
* feat(telemetry): adding instrumentation_config_id

Similar to DataDog/dd-trace-py#8783
rochdev pushed a commit to DataDog/dd-trace-js that referenced this pull request May 14, 2024
* feat(telemetry): adding instrumentation_config_id

Similar to DataDog/dd-trace-py#8783
rochdev pushed a commit to DataDog/dd-trace-js that referenced this pull request May 14, 2024
* feat(telemetry): adding instrumentation_config_id

Similar to DataDog/dd-trace-py#8783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants