Skip to content

Commit 54a9272

Browse files
committed
feat(telemetry): adding instrumentation_config_id
Simialr to DataDog/dd-trace-py#8783
1 parent 5518693 commit 54a9272

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

packages/dd-trace/src/config.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ function checkIfBothOtelAndDdEnvVarSet () {
6060
log.warn(`both ${ddVar} and ${otelVar} environment variables are set`)
6161
getCounter('otel.env.hiding', ddVar, otelVar,
6262
otelVar === 'OTEL_TRACES_SAMPLER' &&
63-
process.env.OTEL_TRACES_SAMPLER_ARG
63+
process.env.OTEL_TRACES_SAMPLER_ARG
6464
? 'OTEL_TRACES_SAMPLER_ARG'
6565
: undefined).inc()
6666
}
@@ -516,6 +516,7 @@ class Config {
516516
this._setValue(defaults, 'tracing', true)
517517
this._setValue(defaults, 'url', undefined)
518518
this._setValue(defaults, 'version', pkg.version)
519+
this._setValue(defaults, 'instrumentation_config_id', undefined)
519520
}
520521

521522
_applyEnvironment () {
@@ -547,6 +548,7 @@ class Config {
547548
DD_IAST_REQUEST_SAMPLING,
548549
DD_IAST_TELEMETRY_VERBOSITY,
549550
DD_INSTRUMENTATION_TELEMETRY_ENABLED,
551+
DD_INSTRUMENTATION_CONFIG_ID,
550552
DD_LOGS_INJECTION,
551553
DD_OPENAI_LOGS_ENABLED,
552554
DD_OPENAI_SPAN_CHAR_LIMIT,
@@ -669,7 +671,7 @@ class Config {
669671
? false
670672
: undefined
671673
this._setBoolean(env, 'runtimeMetrics', DD_RUNTIME_METRICS_ENABLED ||
672-
otelSetRuntimeMetrics)
674+
otelSetRuntimeMetrics)
673675
const OTEL_TRACES_SAMPLER_MAPPING = {
674676
always_on: '1.0',
675677
always_off: '0.0',
@@ -695,6 +697,7 @@ class Config {
695697
DD_INSTRUMENTATION_TELEMETRY_ENABLED, // to comply with instrumentation telemetry specs
696698
!(this._isInServerlessEnvironment() || JEST_WORKER_ID)
697699
))
700+
this._setString(env, 'instrumentation_config_id', DD_INSTRUMENTATION_CONFIG_ID)
698701
this._setBoolean(env, 'telemetry.debug', DD_TELEMETRY_DEBUG)
699702
this._setBoolean(env, 'telemetry.dependencyCollection', DD_TELEMETRY_DEPENDENCY_COLLECTION_ENABLED)
700703
this._setValue(env, 'telemetry.heartbeatInterval', maybeInt(Math.floor(DD_TELEMETRY_HEARTBEAT_INTERVAL * 1000)))
@@ -780,7 +783,7 @@ class Config {
780783
this._setBoolean(opts, 'startupLogs', options.startupLogs)
781784
this._setTags(opts, 'tags', tags)
782785
this._setBoolean(opts, 'telemetry.logCollection', options.iastOptions &&
783-
(options.iastOptions === true || options.iastOptions.enabled === true))
786+
(options.iastOptions === true || options.iastOptions.enabled === true))
784787
this._setBoolean(opts, 'traceId128BitGenerationEnabled', options.traceId128BitGenerationEnabled)
785788
this._setBoolean(opts, 'traceId128BitLoggingEnabled', options.traceId128BitLoggingEnabled)
786789
this._setString(opts, 'version', options.version || tags.version)

packages/dd-trace/test/config.spec.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ describe('Config', () => {
136136

137137
it('should correctly map OTEL_RESOURCE_ATTRIBUTES', () => {
138138
process.env.OTEL_RESOURCE_ATTRIBUTES =
139-
'deployment.environment=test1,service.name=test2,service.version=5,foo=bar1,baz=qux1'
139+
'deployment.environment=test1,service.name=test2,service.version=5,foo=bar1,baz=qux1'
140140
const config = new Config()
141141

142142
expect(config).to.have.property('env', 'test1')
@@ -199,6 +199,7 @@ describe('Config', () => {
199199
expect(config).to.have.property('spanAttributeSchema', 'v0')
200200
expect(config).to.have.property('spanComputePeerService', false)
201201
expect(config).to.have.property('spanRemoveIntegrationFromService', false)
202+
expect(config).to.have.property('instrumentation_config_id', undefined)
202203
expect(config).to.have.deep.property('serviceMapping', {})
203204
expect(config).to.have.nested.deep.property('tracePropagationStyle.inject', ['datadog', 'tracecontext'])
204205
expect(config).to.have.nested.deep.property('tracePropagationStyle.extract', ['datadog', 'tracecontext'])
@@ -410,6 +411,7 @@ describe('Config', () => {
410411
process.env.DD_INSTRUMENTATION_INSTALL_ID = '68e75c48-57ca-4a12-adfc-575c4b05fcbe'
411412
process.env.DD_INSTRUMENTATION_INSTALL_TYPE = 'k8s_single_step'
412413
process.env.DD_INSTRUMENTATION_INSTALL_TIME = '1703188212'
414+
process.env.DD_INSTRUMENTATION_CONFIG_ID = 'abcedf123'
413415

414416
const config = new Config()
415417

@@ -433,6 +435,7 @@ describe('Config', () => {
433435
expect(config).to.have.property('spanAttributeSchema', 'v1')
434436
expect(config).to.have.property('spanRemoveIntegrationFromService', true)
435437
expect(config).to.have.property('spanComputePeerService', true)
438+
expect(config).to.have.property('instrumentation_config_id', 'abcdef123')
436439
expect(config.tags).to.include({ foo: 'bar', baz: 'qux' })
437440
expect(config.tags).to.include({ service: 'service', version: '1.0.0', env: 'test' })
438441
expect(config).to.have.deep.nested.property('sampler', {
@@ -538,7 +541,8 @@ describe('Config', () => {
538541
{ name: 'iast.maxContextOperations', value: 4, origin: 'env_var' },
539542
{ name: 'iast.deduplicationEnabled', value: false, origin: 'env_var' },
540543
{ name: 'iast.redactionEnabled', value: false, origin: 'env_var' },
541-
{ name: 'iast.telemetryVerbosity', value: 'DEBUG', origin: 'env_var' }
544+
{ name: 'iast.telemetryVerbosity', value: 'DEBUG', origin: 'env_var' },
545+
{ name: 'instrumentation_config_id', value: 'abcdef123', origin: 'env_var' }
542546
)
543547
})
544548

0 commit comments

Comments
 (0)