Skip to content

Adding support for reporting remote config id #7012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 10, 2024
Merged

Adding support for reporting remote config id #7012

merged 9 commits into from
May 10, 2024

Conversation

@stanistan
Copy link
Member

@stanistan stanistan commented May 9, 2024 •
edited
Loading

What Does This Do

Adds support for the instrumentation_config_id from the outer environment (remote config) so it can then be reported via standard telemetry.

https://datadoghq.atlassian.net/browse/APMON-888

Motivation

^^^

Additional Notes

This is also being added to other language libraries where this data might be set through
an injection / container environment:

Closes #6968.

@stanistan stanistan requested a review from a team as a code owner May 9, 2024 18:09
@stanistan stanistan requested review from PerfectSlayer and ygree May 9, 2024 18:09
@stanistan stanistan mentioned this pull request May 9, 2024
Closed
@stanistan stanistan added the comp: telemetry Telemetry label May 9, 2024
@pr-commenter
Copy link

pr-commenter bot commented May 9, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master stanistan/remote-config-id-actual
git_commit_date 1715279552 1715280794
git_commit_sha 6df14c1 7e04be4
release_version 1.35.0-SNAPSHOT~6df14c1b0f 1.35.0-SNAPSHOT~7e04be4ba9
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715332931 1715332931
ci_job_id 508339710 508339710
ci_pipeline_id 33989781 33989781
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~7e04be4ba9, baseline=1.35.0-SNAPSHOT~6df14c1b0f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1088959
Total [baseline] (8.565 s) : 0, 8564892
Agent [candidate] (1.084 s) : 0, 1084145
Total [candidate] (8.577 s) : 0, 8577075
section iast
Agent [baseline] (1.2 s) : 0, 1200332
Total [baseline] (9.008 s) : 0, 9007832
Agent [candidate] (1.205 s) : 0, 1205356
Total [candidate] (9.126 s) : 0, 9125594
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.2 s) : 0, 1200342
Total [baseline] (8.961 s) : 0, 8961268
Agent [candidate] (1.205 s) : 0, 1204520
Total [candidate] (8.975 s) : 0, 8975374
section iast_TELEMETRY_OFF
Agent [baseline] (1.208 s) : 0, 1207869
Total [baseline] (9.012 s) : 0, 9012337
Agent [candidate] (1.204 s) : 0, 1203565
Total [candidate] (9.024 s) : 0, 9023896
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.089 s -
Agent iast 1.2 s 111.372 ms (10.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.2 s 111.382 ms (10.2%)
Agent iast_TELEMETRY_OFF 1.208 s 118.91 ms (10.9%)
Total tracing 8.565 s -
Total iast 9.008 s 442.94 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 8.961 s 396.376 ms (4.6%)
Total iast_TELEMETRY_OFF 9.012 s 447.444 ms (5.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent iast 1.205 s 121.211 ms (11.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.205 s 120.375 ms (11.1%)
Agent iast_TELEMETRY_OFF 1.204 s 119.42 ms (11.0%)
Total tracing 8.577 s -
Total iast 9.126 s 548.52 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.975 s 398.299 ms (4.6%)
Total iast_TELEMETRY_OFF 9.024 s 446.821 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~7e04be4ba9, baseline=1.35.0-SNAPSHOT~6df14c1b0f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.729 ms) : 0, 682729
BytebuddyAgent [candidate] (678.417 ms) : 0, 678417
GlobalTracer [baseline] (312.886 ms) : 0, 312886
GlobalTracer [candidate] (312.921 ms) : 0, 312921
AppSec [baseline] (49.93 ms) : 0, 49930
AppSec [candidate] (49.81 ms) : 0, 49810
Remote Config [baseline] (671.085 µs) : 0, 671
Remote Config [candidate] (664.572 µs) : 0, 665
Telemetry [baseline] (7.759 ms) : 0, 7759
Telemetry [candidate] (7.729 ms) : 0, 7729
section iast
BytebuddyAgent [baseline] (793.342 ms) : 0, 793342
BytebuddyAgent [candidate] (795.752 ms) : 0, 795752
GlobalTracer [baseline] (290.623 ms) : 0, 290623
GlobalTracer [candidate] (291.778 ms) : 0, 291778
AppSec [baseline] (51.65 ms) : 0, 51650
AppSec [candidate] (50.35 ms) : 0, 50350
IAST [baseline] (22.599 ms) : 0, 22599
IAST [candidate] (25.564 ms) : 0, 25564
Remote Config [baseline] (1.302 ms) : 0, 1302
Remote Config [candidate] (634.28 µs) : 0, 634
Telemetry [baseline] (6.582 ms) : 0, 6582
Telemetry [candidate] (6.78 ms) : 0, 6780
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (793.08 ms) : 0, 793080
BytebuddyAgent [candidate] (795.257 ms) : 0, 795257
GlobalTracer [baseline] (290.866 ms) : 0, 290866
GlobalTracer [candidate] (291.558 ms) : 0, 291558
AppSec [baseline] (49.338 ms) : 0, 49338
AppSec [candidate] (50.785 ms) : 0, 50785
IAST [baseline] (25.585 ms) : 0, 25585
IAST [candidate] (24.539 ms) : 0, 24539
Remote Config [baseline] (682.437 µs) : 0, 682
Remote Config [candidate] (1.368 ms) : 0, 1368
Telemetry [baseline] (6.543 ms) : 0, 6543
Telemetry [candidate] (6.683 ms) : 0, 6683
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (797.859 ms) : 0, 797859
BytebuddyAgent [candidate] (796.041 ms) : 0, 796041
GlobalTracer [baseline] (293.084 ms) : 0, 293084
GlobalTracer [candidate] (291.153 ms) : 0, 291153
AppSec [baseline] (49.23 ms) : 0, 49230
AppSec [candidate] (49.601 ms) : 0, 49601
IAST [baseline] (26.088 ms) : 0, 26088
IAST [candidate] (23.53 ms) : 0, 23530
Remote Config [baseline] (578.843 µs) : 0, 579
Remote Config [candidate] (596.553 µs) : 0, 597
Telemetry [baseline] (6.477 ms) : 0, 6477
Telemetry [candidate] (8.071 ms) : 0, 8071
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~7e04be4ba9, baseline=1.35.0-SNAPSHOT~6df14c1b0f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079565
Total [baseline] (10.505 s) : 0, 10504979
Agent [candidate] (1.077 s) : 0, 1077370
Total [candidate] (10.524 s) : 0, 10524125
section appsec
Agent [baseline] (1.201 s) : 0, 1201164
Total [baseline] (10.513 s) : 0, 10513034
Agent [candidate] (1.197 s) : 0, 1196506
Total [candidate] (10.519 s) : 0, 10518805
section iast
Agent [baseline] (1.21 s) : 0, 1210440
Total [baseline] (10.784 s) : 0, 10784057
Agent [candidate] (1.22 s) : 0, 1219750
Total [candidate] (10.815 s) : 0, 10815426
section profiling
Agent [baseline] (1.272 s) : 0, 1271516
Total [baseline] (10.616 s) : 0, 10616300
Agent [candidate] (1.27 s) : 0, 1270151
Total [candidate] (10.595 s) : 0, 10595324
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent appsec 1.201 s 121.599 ms (11.3%)
Agent iast 1.21 s 130.875 ms (12.1%)
Agent profiling 1.272 s 191.952 ms (17.8%)
Total tracing 10.505 s -
Total appsec 10.513 s 8.055 ms (0.1%)
Total iast 10.784 s 279.078 ms (2.7%)
Total profiling 10.616 s 111.32 ms (1.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent appsec 1.197 s 119.136 ms (11.1%)
Agent iast 1.22 s 142.38 ms (13.2%)
Agent profiling 1.27 s 192.782 ms (17.9%)
Total tracing 10.524 s -
Total appsec 10.519 s -5.32 ms (-0.1%)
Total iast 10.815 s 291.301 ms (2.8%)
Total profiling 10.595 s 71.199 ms (0.7%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~7e04be4ba9, baseline=1.35.0-SNAPSHOT~6df14c1b0f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.52 ms) : 0, 675520
BytebuddyAgent [candidate] (674.361 ms) : 0, 674361
GlobalTracer [baseline] (311.746 ms) : 0, 311746
GlobalTracer [candidate] (311.012 ms) : 0, 311012
AppSec [baseline] (49.646 ms) : 0, 49646
AppSec [candidate] (49.446 ms) : 0, 49446
Remote Config [baseline] (666.391 µs) : 0, 666
Remote Config [candidate] (656.196 µs) : 0, 656
Telemetry [baseline] (7.666 ms) : 0, 7666
Telemetry [candidate] (7.562 ms) : 0, 7562
section appsec
BytebuddyAgent [baseline] (701.774 ms) : 0, 701774
BytebuddyAgent [candidate] (698.321 ms) : 0, 698321
GlobalTracer [baseline] (296.181 ms) : 0, 296181
GlobalTracer [candidate] (294.711 ms) : 0, 294711
AppSec [baseline] (149.578 ms) : 0, 149578
AppSec [candidate] (149.678 ms) : 0, 149678
Remote Config [baseline] (620.149 µs) : 0, 620
Remote Config [candidate] (615.834 µs) : 0, 616
Telemetry [baseline] (8.837 ms) : 0, 8837
Telemetry [candidate] (9.071 ms) : 0, 9071
IAST [baseline] (19.283 ms) : 0, 19283
IAST [candidate] (19.354 ms) : 0, 19354
section iast
BytebuddyAgent [baseline] (800.466 ms) : 0, 800466
BytebuddyAgent [candidate] (805.947 ms) : 0, 805947
GlobalTracer [baseline] (292.572 ms) : 0, 292572
GlobalTracer [candidate] (295.0 ms) : 0, 295000
AppSec [baseline] (49.05 ms) : 0, 49050
AppSec [candidate] (48.716 ms) : 0, 48716
Remote Config [baseline] (1.338 ms) : 0, 1338
Remote Config [candidate] (1.333 ms) : 0, 1333
Telemetry [baseline] (6.616 ms) : 0, 6616
Telemetry [candidate] (6.702 ms) : 0, 6702
IAST [baseline] (25.904 ms) : 0, 25904
IAST [candidate] (27.239 ms) : 0, 27239
section profiling
ProfilingAgent [baseline] (95.43 ms) : 0, 95430
ProfilingAgent [candidate] (95.614 ms) : 0, 95614
BytebuddyAgent [baseline] (678.972 ms) : 0, 678972
BytebuddyAgent [candidate] (678.248 ms) : 0, 678248
GlobalTracer [baseline] (382.035 ms) : 0, 382035
GlobalTracer [candidate] (381.576 ms) : 0, 381576
AppSec [baseline] (50.529 ms) : 0, 50529
AppSec [candidate] (50.026 ms) : 0, 50026
Remote Config [baseline] (713.825 µs) : 0, 714
Remote Config [candidate] (725.518 µs) : 0, 726
Telemetry [baseline] (7.422 ms) : 0, 7422
Telemetry [candidate] (7.472 ms) : 0, 7472
Profiling [baseline] (95.455 ms) : 0, 95455
Profiling [candidate] (95.64 ms) : 0, 95640
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-10T08:52:53 2024-05-10T08:59:40
git_branch master stanistan/remote-config-id-actual
git_commit_date 1715279552 1715280794
git_commit_sha 6df14c1 7e04be4
release_version 1.35.0-SNAPSHOT~6df14c1b0f 1.35.0-SNAPSHOT~7e04be4ba9
start_time 2024-05-10T08:52:39 2024-05-10T08:59:27
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715331923 1715331923
ci_job_id 508339711 508339711
ci_pipeline_id 33989781 33989781
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~7e04be4ba9, baseline=1.35.0-SNAPSHOT~6df14c1b0f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.344 ms) : 1325, 1364
.   : milestone, 1344,
appsec (1.726 ms) : 1703, 1750
.   : milestone, 1726,
appsec_no_iast (1.717 ms) : 1694, 1741
.   : milestone, 1717,
iast (1.477 ms) : 1454, 1499
.   : milestone, 1477,
profiling (1.505 ms) : 1481, 1530
.   : milestone, 1505,
tracing (1.474 ms) : 1450, 1498
.   : milestone, 1474,
section candidate
no_agent (1.345 ms) : 1325, 1364
.   : milestone, 1345,
appsec (1.722 ms) : 1699, 1746
.   : milestone, 1722,
appsec_no_iast (1.701 ms) : 1677, 1725
.   : milestone, 1701,
iast (1.481 ms) : 1458, 1504
.   : milestone, 1481,
profiling (1.521 ms) : 1496, 1547
.   : milestone, 1521,
tracing (1.475 ms) : 1452, 1499
.   : milestone, 1475,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.344 ms [1.325 ms, 1.364 ms] -
appsec 1.726 ms [1.703 ms, 1.75 ms] 382.097 µs (28.4%)
appsec_no_iast 1.717 ms [1.694 ms, 1.741 ms] 372.92 µs (27.7%)
iast 1.477 ms [1.454 ms, 1.499 ms] 132.54 µs (9.9%)
profiling 1.505 ms [1.481 ms, 1.53 ms] 161.222 µs (12.0%)
tracing 1.474 ms [1.45 ms, 1.498 ms] 129.513 µs (9.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.325 ms, 1.364 ms] -
appsec 1.722 ms [1.699 ms, 1.746 ms] 377.822 µs (28.1%)
appsec_no_iast 1.701 ms [1.677 ms, 1.725 ms] 356.246 µs (26.5%)
iast 1.481 ms [1.458 ms, 1.504 ms] 136.693 µs (10.2%)
profiling 1.521 ms [1.496 ms, 1.547 ms] 176.715 µs (13.1%)
tracing 1.475 ms [1.452 ms, 1.499 ms] 130.938 µs (9.7%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~7e04be4ba9, baseline=1.35.0-SNAPSHOT~6df14c1b0f
    dateFormat X
    axisFormat %s
section baseline
no_agent (371.544 µs) : 352, 391
.   : milestone, 372,
iast (470.74 µs) : 450, 491
.   : milestone, 471,
iast_FULL (536.412 µs) : 516, 557
.   : milestone, 536,
iast_GLOBAL (496.118 µs) : 474, 518
.   : milestone, 496,
iast_HARDCODED_SECRET_DISABLED (467.785 µs) : 447, 488
.   : milestone, 468,
iast_INACTIVE (445.087 µs) : 424, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (468.441 µs) : 447, 490
.   : milestone, 468,
tracing (441.098 µs) : 420, 462
.   : milestone, 441,
section candidate
no_agent (368.273 µs) : 348, 388
.   : milestone, 368,
iast (470.966 µs) : 450, 492
.   : milestone, 471,
iast_FULL (534.544 µs) : 514, 555
.   : milestone, 535,
iast_GLOBAL (490.882 µs) : 470, 512
.   : milestone, 491,
iast_HARDCODED_SECRET_DISABLED (474.904 µs) : 454, 496
.   : milestone, 475,
iast_INACTIVE (442.688 µs) : 422, 463
.   : milestone, 443,
iast_TELEMETRY_OFF (466.174 µs) : 445, 487
.   : milestone, 466,
tracing (439.818 µs) : 419, 460
.   : milestone, 440,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.544 µs [351.82 µs, 391.269 µs] -
iast 470.74 µs [450.384 µs, 491.097 µs] 99.196 µs (26.7%)
iast_FULL 536.412 µs [515.759 µs, 557.066 µs] 164.868 µs (44.4%)
iast_GLOBAL 496.118 µs [474.178 µs, 518.057 µs] 124.573 µs (33.5%)
iast_HARDCODED_SECRET_DISABLED 467.785 µs [447.424 µs, 488.146 µs] 96.241 µs (25.9%)
iast_INACTIVE 445.087 µs [424.144 µs, 466.031 µs] 73.543 µs (19.8%)
iast_TELEMETRY_OFF 468.441 µs [447.303 µs, 489.578 µs] 96.896 µs (26.1%)
tracing 441.098 µs [420.031 µs, 462.165 µs] 69.553 µs (18.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.273 µs [348.378 µs, 388.168 µs] -
iast 470.966 µs [450.344 µs, 491.587 µs] 102.692 µs (27.9%)
iast_FULL 534.544 µs [513.832 µs, 555.257 µs] 166.271 µs (45.1%)
iast_GLOBAL 490.882 µs [470.1 µs, 511.664 µs] 122.609 µs (33.3%)
iast_HARDCODED_SECRET_DISABLED 474.904 µs [453.882 µs, 495.927 µs] 106.631 µs (29.0%)
iast_INACTIVE 442.688 µs [421.981 µs, 463.396 µs] 74.415 µs (20.2%)
iast_TELEMETRY_OFF 466.174 µs [445.409 µs, 486.94 µs] 97.901 µs (26.6%)
tracing 439.818 µs [419.259 µs, 460.377 µs] 71.545 µs (19.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master stanistan/remote-config-id-actual
git_commit_date 1715279552 1715280794
git_commit_sha 6df14c1 7e04be4
release_version 1.35.0-SNAPSHOT~6df14c1b0f 1.35.0-SNAPSHOT~7e04be4ba9
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1715332529 1715332529
ci_job_id 508339712 508339712
ci_pipeline_id 33989781 33989781
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~7e04be4ba9, baseline=1.35.0-SNAPSHOT~6df14c1b0f
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.393 s) : 15393000, 15393000
.   : milestone, 15393000,
appsec (15.327 s) : 15327000, 15327000
.   : milestone, 15327000,
iast (18.694 s) : 18694000, 18694000
.   : milestone, 18694000,
iast_GLOBAL (17.694 s) : 17694000, 17694000
.   : milestone, 17694000,
profiling (16.0 s) : 16000000, 16000000
.   : milestone, 16000000,
tracing (15.163 s) : 15163000, 15163000
.   : milestone, 15163000,
section candidate
no_agent (15.15 s) : 15150000, 15150000
.   : milestone, 15150000,
appsec (15.069 s) : 15069000, 15069000
.   : milestone, 15069000,
iast (18.89 s) : 18890000, 18890000
.   : milestone, 18890000,
iast_GLOBAL (17.778 s) : 17778000, 17778000
.   : milestone, 17778000,
profiling (15.013 s) : 15013000, 15013000
.   : milestone, 15013000,
tracing (14.84 s) : 14840000, 14840000
.   : milestone, 14840000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.393 s [15.393 s, 15.393 s] -
appsec 15.327 s [15.327 s, 15.327 s] -66.0 ms (-0.4%)
iast 18.694 s [18.694 s, 18.694 s] 3.301 s (21.4%)
iast_GLOBAL 17.694 s [17.694 s, 17.694 s] 2.301 s (14.9%)
profiling 16.0 s [16.0 s, 16.0 s] 607.0 ms (3.9%)
tracing 15.163 s [15.163 s, 15.163 s] -230.0 ms (-1.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.15 s [15.15 s, 15.15 s] -
appsec 15.069 s [15.069 s, 15.069 s] -81.0 ms (-0.5%)
iast 18.89 s [18.89 s, 18.89 s] 3.74 s (24.7%)
iast_GLOBAL 17.778 s [17.778 s, 17.778 s] 2.628 s (17.3%)
profiling 15.013 s [15.013 s, 15.013 s] -137.0 ms (-0.9%)
tracing 14.84 s [14.84 s, 14.84 s] -310.0 ms (-2.0%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~7e04be4ba9, baseline=1.35.0-SNAPSHOT~6df14c1b0f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.465 ms) : 1454, 1477
.   : milestone, 1465,
appsec (2.202 ms) : 2168, 2236
.   : milestone, 2202,
iast (1.861 ms) : 1826, 1895
.   : milestone, 1861,
iast_GLOBAL (1.912 ms) : 1876, 1947
.   : milestone, 1912,
profiling (1.834 ms) : 1802, 1867
.   : milestone, 1834,
tracing (1.824 ms) : 1792, 1856
.   : milestone, 1824,
section candidate
no_agent (1.458 ms) : 1446, 1469
.   : milestone, 1458,
appsec (2.192 ms) : 2157, 2226
.   : milestone, 2192,
iast (1.869 ms) : 1835, 1904
.   : milestone, 1869,
iast_GLOBAL (1.904 ms) : 1868, 1939
.   : milestone, 1904,
profiling (1.846 ms) : 1812, 1880
.   : milestone, 1846,
tracing (1.821 ms) : 1789, 1853
.   : milestone, 1821,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.454 ms, 1.477 ms] -
appsec 2.202 ms [2.168 ms, 2.236 ms] 736.735 µs (50.3%)
iast 1.861 ms [1.826 ms, 1.895 ms] 395.451 µs (27.0%)
iast_GLOBAL 1.912 ms [1.876 ms, 1.947 ms] 446.498 µs (30.5%)
profiling 1.834 ms [1.802 ms, 1.867 ms] 369.079 µs (25.2%)
tracing 1.824 ms [1.792 ms, 1.856 ms] 359.048 µs (24.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.446 ms, 1.469 ms] -
appsec 2.192 ms [2.157 ms, 2.226 ms] 734.128 µs (50.4%)
iast 1.869 ms [1.835 ms, 1.904 ms] 411.635 µs (28.2%)
iast_GLOBAL 1.904 ms [1.868 ms, 1.939 ms] 446.039 µs (30.6%)
profiling 1.846 ms [1.812 ms, 1.88 ms] 388.362 µs (26.6%)
tracing 1.821 ms [1.789 ms, 1.853 ms] 363.654 µs (24.9%)

@PerfectSlayer PerfectSlayer changed the title feat(telemetry): Adding support for reporting remote config id Adding support for reporting remote config id May 10, 2024
@stanistan stanistan merged commit 20aa262 into master May 10, 2024
@stanistan stanistan deleted the stanistan/remote-config-id-actual branch May 10, 2024 13:05
@github-actions github-actions bot added this to the 1.35.0 milestone May 10, 2024
Kyle-Verhoog
Kyle-Verhoog reviewed May 10, 2024
View reviewed changes
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to follow up with having it read the env var or is that auto-magically done by configProvider.getString?

@mcculls
Copy link
Contributor

mcculls commented May 10, 2024

@Kyle-Verhoog no need - calling configProvider.getString ends up recording the configuration value via a collector, which telemetry then reports to the agent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kyle-Verhoog Kyle-Verhoog Kyle-Verhoog left review comments

@mcculls mcculls mcculls approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: telemetry Telemetry

Projects

None yet

Milestone

1.35.0

Development

Successfully merging this pull request may close these issues.

5 participants

@stanistan @mcculls @PerfectSlayer @Kyle-Verhoog