-
Notifications
You must be signed in to change notification settings - Fork 467
fix(wrapt): do not use wrapt 2.x yet [backport 3.16] #14964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
## Description <!-- Provide an overview of the change and motivation for the change --> We have a bug report that there are recursion errors with wrapt 2.x on our psycopg integration. I'd still like to study if we can recreate the error in a test but don't want this investigation to block this known issue. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> --------- Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com> Co-authored-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com> Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> (cherry picked from commit 492135a)
7181031 to
b92e798
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 243 ± 3 ms. The average import time from base is: 242 ± 2 ms. The import time difference between this PR and base is: 0.8 ± 0.1 ms. Import time breakdownThe following import paths have appeared:
|
Backport 492135a from #14955 to 3.16.
Description
We have a bug report that there are recursion errors with wrapt 2.x on our psycopg integration. I'd still like to study if we can recreate the error in a test but don't want this investigation to block this known issue.
Testing
Risks
Additional Notes