fix(wrapt): do not use wrapt 2.x yet #14955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wantsui
changed the title
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 240 ± 2 ms. The average import time from base is: 244 ± 6 ms. The import time difference between this PR and base is: -4.1 ± 0.2 ms. Import time breakdownThe following import paths have appeared:
|
juanjux
changed the title
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
brettlangdon
approved these changes
Oct 21, 2025
P403n1x87
reviewed
Oct 21, 2025
P403n1x87
reviewed
Oct 21, 2025
P403n1x87
reviewed
Oct 21, 2025
P403n1x87
reviewed
Oct 21, 2025
emmettbutler
approved these changes
Oct 21, 2025
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.14 3.14
# Navigate to the new working tree
cd .worktrees/backport-3.14
# Create a new branch
git switch --create backport-14955-to-3.14
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 492135a4950e798b276cb91df3fac438cac6c2e4
# Push it to GitHub
git push --set-upstream origin backport-14955-to-3.14
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.14Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.15 3.15
# Navigate to the new working tree
cd .worktrees/backport-3.15
# Create a new branch
git switch --create backport-14955-to-3.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 492135a4950e798b276cb91df3fac438cac6c2e4
# Push it to GitHub
git push --set-upstream origin backport-14955-to-3.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.15Then, create a pull request where the |
dd-octo-sts bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
## Description <!-- Provide an overview of the change and motivation for the change --> We have a bug report that there are recursion errors with wrapt 2.x on our psycopg integration. I'd still like to study if we can recreate the error in a test but don't want this investigation to block this known issue. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> --------- Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com> Co-authored-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com> Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> (cherry picked from commit 492135a)
brettlangdon
added a commit
that referenced
this pull request
Oct 21, 2025
## Description <!-- Provide an overview of the change and motivation for the change --> We have a bug report that there are recursion errors with wrapt 2.x on our psycopg integration. I'd still like to study if we can recreate the error in a test but don't want this investigation to block this known issue. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> --------- Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com> Co-authored-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com> Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> (cherry picked from commit 492135a)
brettlangdon
added a commit
that referenced
this pull request
Oct 21, 2025
<!-- Provide an overview of the change and motivation for the change --> We have a bug report that there are recursion errors with wrapt 2.x on our psycopg integration. I'd still like to study if we can recreate the error in a test but don't want this investigation to block this known issue. <!-- Describe your testing strategy or note what tests are included --> <!-- Note any risks associated with this change, or "None" if no risks --> <!-- Any other information that would be helpful for reviewers --> --------- Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com> Co-authored-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com> Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> (cherry picked from commit 492135a)
brettlangdon
added a commit
that referenced
this pull request
Oct 21, 2025
<!-- Provide an overview of the change and motivation for the change --> We have a bug report that there are recursion errors with wrapt 2.x on our psycopg integration. I'd still like to study if we can recreate the error in a test but don't want this investigation to block this known issue. <!-- Describe your testing strategy or note what tests are included --> <!-- Note any risks associated with this change, or "None" if no risks --> <!-- Any other information that would be helpful for reviewers --> --------- Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com> Co-authored-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com> Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> (cherry picked from commit 492135a)
|
Think we may have also hit this as well with ddtrace 2.21.0 works doesn't work |
brettlangdon
added a commit
that referenced
this pull request
Oct 21, 2025
Backport 492135a from #14955 to 3.16. ## Description <!-- Provide an overview of the change and motivation for the change --> We have a bug report that there are recursion errors with wrapt 2.x on our psycopg integration. I'd still like to study if we can recreate the error in a test but don't want this investigation to block this known issue. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com> Co-authored-by: wantsui <wan.tsui@datadoghq.com> Co-authored-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com> Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
brettlangdon
added a commit
that referenced
this pull request
Oct 21, 2025
## Description We have a bug report that there are recursion errors with wrapt 2.x on our psycopg integration. I'd still like to study if we can recreate the error in a test but don't want this investigation to block this known issue. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com> Co-authored-by: wantsui <wan.tsui@datadoghq.com> Co-authored-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
brettlangdon
added a commit
that referenced
this pull request
Oct 21, 2025
## Description We have a bug report that there are recursion errors with wrapt 2.x on our psycopg integration. I'd still like to study if we can recreate the error in a test but don't want this investigation to block this known issue. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com> Co-authored-by: wantsui <wan.tsui@datadoghq.com> Co-authored-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
|
With a stack trace like |
|
Thanks for the report @nijave ! I've flagged for my team. |
gnufede
pushed a commit
that referenced
this pull request
Oct 23, 2025
<!-- Provide an overview of the change and motivation for the change --> We have a bug report that there are recursion errors with wrapt 2.x on our psycopg integration. I'd still like to study if we can recreate the error in a test but don't want this investigation to block this known issue. <!-- Describe your testing strategy or note what tests are included --> <!-- Note any risks associated with this change, or "None" if no risks --> <!-- Any other information that would be helpful for reviewers --> --------- Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com> Co-authored-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com> Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
|
@nijave our recommendation at this time is to upgrade to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have a bug report that there are recursion errors with wrapt 2.x on our psycopg integration. I'd still like to study if we can recreate the error in a test but don't want this investigation to block this known issue.
Testing
Risks
Additional Notes