Repository navigation
feat(otel): otel sampling support in distributed tracing - #10117
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Overall package sizeSelf size: 9.33 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.5.1 | 127.66 kB | 513.61 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
✅ All CI checks and tests passed. Datadog automation helped this PR pass. 🎉 All green!🧪 All tests passed 🔄 Datadog retried 1 test - 1 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: 2194615 | Docs | View more details | Give us feedback! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49eb6259f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
BenchmarksBenchmark execution time: 2026-10-01 09:02:17 Comparing candidate commit 2194615 in PR branch Found 12 performance improvements and 0 performance regressions! Performance is the same for 2309 metrics, 10 unstable metrics.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42005a60a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
# Conflicts: # .github/CODEOWNERS # packages/dd-trace/src/opentracing/propagation/text_map.js # packages/dd-trace/test/opentracing/propagation/text_map.spec.js
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 660cb44f39
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10117 +/- ##
===========================================
+ Coverage 82.30% 98.84% +16.54%
===========================================
Files 1036 1047 +11
Lines 161965 168795 +6830
Branches 74 74
===========================================
+ Hits 133304 166852 +33548
+ Misses 28661 1943 -26718
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vpellan
added
the
AI Generated
The extract-datadog microbenchmark reproduced a 6.22% regression versus master (713.82 vs 672.04 ns/op). Avoiding general integer parsing for canonical single-digit mechanisms reduced it to 2.08% (691.80 vs 677.73 ns/op), below the requested 5% ceiling. Node 22.23.2, 11 alternating measured samples per revision, startup excluded. Retain the existing parser for every other input. Cover digit boundaries, multi-digit mechanisms, and permissive or invalid fallback inputs.
a0d66c5 to
525dc3b
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 525dc3b269
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
…10473) * fix(propagation): enforce tracestate limits and bound pruning work Tracestate permits 32 vendor members, not 32 fields within each member. Preserve unknown OTel fields when sampling updates exceed the 256-character member limit, and remove optional Datadog fields before required fields. Repeated optional-field classification makes overflow pruning quadratic. On Node.js 22.23.2, full injection with LLMObs overflow falls from 2.36–2.39 microseconds to 2.09–2.13 microseconds across two fresh processes. * fix(propagation): retain standalone trace source in tracestate Standalone AppSec uses the propagated trace source to retain a keep decision downstream. When an optional tag overflows W3C tracestate, pruning that source resets the extracted sampling priority and can drop the security trace. LLMObs application and session attribution must remain together. Pruning only one would change downstream grouping.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ae63fe38a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 103d532883
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
103d532 to
ef1ddb9
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b427c4e3fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
Restore the parseInt fallback changed to Number in 5911351. Preserve integer-prefix parsing and leave empty values without a mechanism while retaining the single-digit fast path. Extend the existing regression matrix for decimal, exponent, hex-like, and whitespace inputs.
2 participants
What does this PR do?
Add support for OTel sampling in distributed tracing, by reading and emitting
ot.thandot.rvtags. These tags will be forwarded to services using OTel SDKs, that should forward them to the backend.Motivation
Distributed tracing will work between DD-instrumented services and OTel-instrumented services, downstream OTel services will be able to forward the
thfield it to the collector and backend, which will calculate metrics correctlyAdditional Notes
Locally passes DataDog/system-tests#7518