Skip to content

[nodejs] test(otel): enable otel tracestate sampling tests for nodejs - #7913

Merged
vpellan merged 3 commits into
mainfrom
vpellan/nodejs-otel-tracestate-enable
Oct 5, 2026
Merged

vpellan merged 3 commits into
mainfrom
vpellan/nodejs-otel-tracestate-enable

Conversation

@vpellan

@vpellan vpellan commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Motivation

This PR has been merged: DataDog/dd-trace-js#10117

Changes

Enable otel tracestate sampling tests for nodejs

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Tests, manifest, weblog are modified -> you'll need a review from system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.
    • Framework is modified, or non obvious usage of it -> get a review from system-tests-core (slack)

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

@vpellan
vpellan requested a review from a team as a code owner October 1, 2026 09:43
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-01T09:47:18.224608Z d8b9ffe PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/nodejs.yml                                                    @DataDog/system-tests-reviewers
mirror_images.lock.yaml                                                 @DataDog/system-tests-core
mirror_images.yaml                                                      @DataDog/system-tests-core
utils/build/docker/base-images.lock.json                                @DataDog/system-tests-reviewers
utils/build/docker/nodejs/express/app.js                                @DataDog/system-tests-reviewers

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d8b9ffe9be

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread manifests/nodejs.yml
Comment thread manifests/nodejs.yml
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Tests

✅ All CI checks and tests passed.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2f16d6d | Docs | View more details | Give us feedback!

@vpellan
vpellan added this pull request to stack #7935 October 5, 2026 08:58
@vpellan
vpellan force-pushed the vpellan/nodejs-otel-tracestate-enable branch from d8b9ffe to 3a1e6d1 Compare October 5, 2026 11:33
The Express weblog binds to 0.0.0.0, but localhost can resolve to ::1. Use IPv4 for the downstream request and returned URL so force-keep checks reach their propagation assertions. Validated Express 5 SAMPLING with dd-trace-js 36d3463: 21 passed, 1 skipped, 2 xpassed; format.sh --check passed.
@vpellan
vpellan requested a review from a team as a code owner October 5, 2026 12:35
@vpellan
vpellan merged commit 864977e into main Oct 5, 2026
102 checks passed
@vpellan
vpellan deleted the vpellan/nodejs-otel-tracestate-enable branch October 5, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants