Repository navigation
[nodejs] test(otel): enable otel tracestate sampling tests for nodejs - #7913
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8b9ffe9be
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🔗 Commit SHA: 2f16d6d | Docs | View more details | Give us feedback! |
d8b9ffe to
3a1e6d1
Compare
The Express weblog binds to 0.0.0.0, but localhost can resolve to ::1. Use IPv4 for the downstream request and returned URL so force-keep checks reach their propagation assertions. Validated Express 5 SAMPLING with dd-trace-js 36d3463: 21 passed, 1 skipped, 2 xpassed; format.sh --check passed.
Motivation
This PR has been merged: DataDog/dd-trace-js#10117
Changes
Enable otel tracestate sampling tests for nodejs
Workflow
system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.system-tests-core(slack)🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟