Repository navigation
test(otel): port otel tracestate sampling rate scenarios to parametric - #7518
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 19 commits intoAug 19, 2026
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 19 commits into
gh-worker-dd-mergequeue-cf854d[bot] merged 19 commits into
Conversation
Contributor
|
|
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 53116d8 | Docs | View more details | Give us feedback! |
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
MilanGarnier
marked this pull request as ready for review
August 14, 2026 15:04
MilanGarnier
requested review from
ZStriker19,
christophe-papazian and
claponcet
and removed request for
a team
August 14, 2026 15:04
MilanGarnier
force-pushed
the
milan.garnier/otel-tracestate-ot-th
branch
from
August 18, 2026 08:26
b02e7fd to
90f5085
Compare
cbeauchesne
approved these changes
Aug 19, 2026
vpellan
reviewed
Aug 19, 2026
gh-worker-dd-mergequeue-cf854d
Bot
merged commit Aug 19, 2026
3005271
into
main
2812 of 2814 checks passed
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
milan.garnier/otel-tracestate-ot-th
branch
August 19, 2026 18:45
gh-worker-dd-mergequeue-cf854d Bot
pushed a commit
to DataDog/dd-trace-py
that referenced
this pull request
Sep 3, 2026
## Description
<!-- Provide an overview of the change and motivation for the change.
Implementation detail and rationale belong here, not in the release note -
release notes are customer-facing (see docs/releasenotes.rst). -->
Add support for OTel sampling in distributed tracing, by reading and emitting `ot.th` and `ot.rv` tags. These tags will be forwarded to services using OTel SDKs, that should forward them to the backend.
## Testing
<!-- Describe your testing strategy or note what tests are included -->
Locally passes DataDog/system-tests#7518
## Risks
<!-- Note any risks associated with this change, or "None" if no risks -->
## Additional Notes
<!-- Any other information that would be helpful for reviewers -->
Co-authored-by: victor.pellan <victor.pellan@datadoghq.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/parametric/test_otel_tracestate_sampling.py; retain the rate-0.5 end-to-end sampling regression.tests/otel/utils.py; the OTLP end-to-end cases consume those values without changing their assertions.otel_sampling_rate_*scenarios.missing_feature.Validation
./format.sh: mypy, ruff, YAML, manifest parsing, and AI Guard checks pass. ShellCheck is blocked by the unrelated directory error atutils/build/docker/internal_server/app.sh.git diff --checkNo broad test suite was run.