feat: added LM portals #4496 #4500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds new analysis portals (and corresponding publication metadata) to the LM project edits in the baseProjectEdits constant.
- Introduces
analysisPortalsentries for multiple LungMAP datasets. - Adds
publicationsarrays for experiments with associated literature. - Updates the
constants.tsfile to include newentryIdblocks and dataset URLs.
Comments suppressed due to low confidence (1)
app/viewModelBuilders/azul/hca-dcp/common/projectMapper/projectEdits/constants.ts:1753
- New analysis portal and publication entries were added but no tests were updated to cover these additions. Consider adding or updating unit tests to ensure that the new portals are correctly mapped and rendered.
{
| ], | ||
| entryId: "fdadee7e-2097-45d5-bf81-cc280bd8348e", | ||
| }, | ||
| { |
There was a problem hiding this comment.
[nitpick] There's a lot of repeated structure when defining each entry (analysisPortals, entryId, publications). Consider creating a helper function or a factory to build these entries to reduce duplication and improve readability.
frano-m
force-pushed
the
mim/4496-lm-portals
branch
from
341c28a to
30fc64e
Compare
NoopDog
approved these changes
Jun 17, 2025
frano-m
force-pushed
the
mim/4496-lm-portals
branch
from
30fc64e to
2f16504
Compare
NoopDog
force-pushed
the
mim/4496-lm-portals
branch
from
2f16504 to
c8a7c96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #4496.
Reviewers
@noop.
Changes