Merge bitcoin/bitcoin#27477: test: add regression tests for #27468 (invalid URI segfaults)

[DashCoreAutoGuix]

Summary

Backport of Bitcoin Core PR bitcoin#27477 - adds regression tests for invalid URI handling in the REST interface.

Original Bitcoin commit: 467fa89

Changes

• Adds test cases for invalid URI handling (% symbol at end of request)
• Tests three REST endpoints: /headers/, /blockfilterheaders/basic/, and /mempool/contents.json
• Validates proper error message: "URI parsing failed, it likely contained RFC 3986 invalid characters"

Dash Adaptations

• None required - test-only change that applies cleanly to Dash
• Resolved minor conflict in test positioning while preserving Dash's expected_filter structure

Testing

• Python syntax validated
• Functional test interface_rest.py modified

Test Plan

• Run test/functional/interface_rest.py to verify new test cases pass
• Verify CI passes

---

Part of Bitcoin Core v0.25 backport batch 412

Generated with Claude Code

[coderabbitai]

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

139 files out of 292 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch backport-0.25-batch-412-pr-27477

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[DashCoreAutoGuix]

🔧 Validation FIXED: Applied dependency bugfix to resolve test failures

Issue Found

This PR (bitcoin#27477) adds regression tests for invalid URI handling (Bitcoin PR bitcoin#27477), but the test suite was failing because the underlying C++ bugfix from Bitcoin PR bitcoin#27468 was not included in the batch.

Root Cause

• The tests expect the REST server to return HTTP 400 with an error message when given invalid URIs (e.g., containing % at the end)
• Without the bugfix, dashd was crashing (segfaulting) instead of gracefully handling the error
• This caused the test to fail with: http.client.RemoteDisconnected: Remote end closed connection without response

Fix Applied

Cherry-picked the bugfix commit from PR bitcoin#27468 (commit: 3a26b19df25):

C++ Changes

• src/httpserver.cpp: Added nullptr check in GetQueryParameterFromUri() before dereferencing
• src/rest.cpp: Gracefully handle URI parsing failures and return HTTP 400
• src/test/httpserver_tests.cpp: Added C++ unit tests for invalid URI handling

Test Changes

• Preserved all 3 regression tests from this PR that validate the fix across multiple REST endpoints

Validation Results

✅ Backport Validation: PASS (100% size match, all files present)
✅ Fix Applied: Dependency bugfix successfully integrated
🔄 CI Status: Tests should now pass - waiting for CI to re-run

Next Steps

CI will automatically re-run with the fix. The interface_rest.py test should now pass since the server will properly handle invalid URIs instead of crashing.

---

Automated validation and fix by Claude Code verification agent

[PastaPastaPasta]

PR diff is 84,963 lines; needs rebased to only include proper commits

[DashCoreAutoGuix]

Verification Analysis for PR #1135

✅ Backport Quality: EXCELLENT

The backport of Bitcoin PR bitcoin#27477 is faithful and complete:

1. Bitcoin PR test: add regression tests for #27468 (invalid URI segfaults) bitcoin/bitcoin#27477 changes: All 3 regression test cases correctly added to test/functional/interface_rest.py (lines 284-287)
2. Bitcoin PR bugfix: rest: avoid segfault for invalid URI bitcoin/bitcoin#27468 dependency: Validation commit 1176d3a8a8 correctly cherry-picked the prerequisite C++ bugfix:
   • src/httpserver.cpp: nullptr check added (lines 685-687)
   • src/rest.cpp: try-catch blocks added (lines 226-230, 406-410)
   • src/test/httpserver_tests.cpp: unit test added (lines 38-40)
3. Bitcoin PR test: Fix intermittent issue in interface_rest.py bitcoin/bitcoin#29467 bonus: Test stability fix for unbroadcastcount included (lines 339-341)
4. CI Status: All 53 checks passed ✅

⚠️ Branch Structure Issue

The PR branch contains 942 files changed due to merging many other Dash PRs (dashpay#7013, dashpay#7014, dashpay#7017, etc.) that shouldn't be part of this PR. The base branch backport-0.25-batch-412 appears outdated.

Required action: The branch needs to be rebased to contain only:

• The merge commit for Bitcoin PR test: add regression tests for #27468 (invalid URI segfaults) bitcoin/bitcoin#27477
• The merge commits for Bitcoin PRs test: Fix intermittent issue in interface_rest.py bitcoin/bitcoin#29467 (test fix)
• The validation commit adding Bitcoin PR bugfix: rest: avoid segfault for invalid URI bitcoin/bitcoin#27468 (bugfix dependency)
• Any other commits from the batch that belong in this PR

This requires manual intervention with git rebase/force-push to clean up the branch history.

📋 Summary

• Backport correctness: Perfect ✅
• CI status: All passing ✅
• Branch hygiene: Needs rebase ⚠️
• Recommendation: NEEDS-MANUAL (branch cleanup required)