fix: include QDebug directly

[PastaPastaPasta]

Issue being fixed or feature implemented

QT packages shipped with Debian 13 currently doesn't build, due to missing QDebug include.

What was done?

directly include

How Has This Been Tested?

Builds on Debian 13 w/ system packages

Breaking Changes

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[knst]

utACK 3cce090

[coderabbitai]

Walkthrough

A single header inclusion was added to src/qt/bitcoin.cpp: #include <QDebug> was inserted following the #include <QApplication> line. This addition enables Qt debug logging functionality within the file. No functional logic or control-flow modifications were made.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Verify that QDebug is actually utilized within the file or if this is a preparatory change for future debug logging
• Confirm the header include placement follows the project's include ordering conventions

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding a direct QDebug include to fix a build issue on Debian 13.
Description check	✅ Passed	The description is related to the changeset, explaining the issue (missing QDebug on Debian 13), the fix applied (direct include), and testing performed.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a2c14b and 3cce090.

📒 Files selected for processing (1)

• src/qt/bitcoin.cpp (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

src/**/*.{cpp,h,hpp,cc}

📄 CodeRabbit inference engine (CLAUDE.md)

Dash Core implementation must be written in C++20, requiring at least Clang 16 or GCC 11.1

Files:

• src/qt/bitcoin.cpp

src/qt/**/*.{cpp,h}

📄 CodeRabbit inference engine (CLAUDE.md)

GUI implementation in src/qt/ must use Qt 5

Files:

• src/qt/bitcoin.cpp

🧠 Learnings (2)

📓 Common learnings

Learnt from: knst
Repo: dashpay/dash PR: 6871
File: contrib/guix/libexec/build.sh:358-360
Timestamp: 2025-10-05T20:38:28.457Z
Learning: In the Dash repository, when backporting code from Bitcoin Core, typos and minor issues in comments should be kept as-is to reduce merge conflicts in future backports, even if they remain unfixed in Bitcoin Core's master branch.

Learnt from: PastaPastaPasta
Repo: dashpay/dash PR: 6804
File: src/qt/proposalwizard.cpp:40-42
Timestamp: 2025-08-11T17:16:36.654Z
Learning: In the Dash repository, when a PR adds new files that are not from Bitcoin backports, these files must be added to the list in test/util/data/non-backported.txt. This applies to newly created files like qt/proposalwizard.{h,cpp} and forms/proposalwizard.ui. Limited exemptions may exist for subtrees and similar cases.

Learnt from: knst
Repo: dashpay/dash PR: 6916
File: src/univalue/include/univalue.h:81-88
Timestamp: 2025-10-25T07:08:51.918Z
Learning: For backport PRs from bitcoin/bitcoin, bitcoin-core/gui, etc., backported changes should match the original upstream PRs even if they appear strange, modify vendored code, or seem to violate coding guidelines. Still flag genuine issues like bugs, undefined behavior, crashes, compilation errors, or linter failures.

📚 Learning: 2025-11-24T16:41:22.457Z

Learnt from: CR
Repo: dashpay/dash PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:41:22.457Z
Learning: Applies to src/qt/**/*.{cpp,h} : GUI implementation in src/qt/ must use Qt 5

Applied to files:

• src/qt/bitcoin.cpp

🔇 Additional comments (1)

src/qt/bitcoin.cpp (1)

51-52: LGTM! Appropriate fix for Debian 13 build issue.

The addition of #include <QDebug> is correctly placed within the Qt includes section in alphabetical order. The file actively uses qDebug() (lines 340, 359, 397) and qInfo() (line 406), which require this header. On some Qt configurations—including Debian 13's system packages—this include is not transitively pulled in through other headers, making the explicit inclusion necessary to resolve the build failure.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

[kwvg]

utACK 3cce090

[UdjinM6]

utACK 3cce090