pdf export filename qith quotes fails in chrome#2883
Merged
raycarrick-ed merged 2 commits intomasterfrom Apr 21, 2021
Merged
Conversation
briri
approved these changes
Apr 20, 2021
Contributor
|
looks good @raycarrick-ed just a very minor rubocop complaint then go ahead and merge after that |
space and quotes apparently not right
Contributor
|
Is this actually enough as a check? I can imagine that tomorrow other characters will emerge. What if someone adds emoticons? I think that a filename like e.g. a title like |
nicolasfranck
added a commit
to DMPbelgium/roadmap
that referenced
this pull request
Oct 15, 2021
portagenetwork
pushed a commit
to portagenetwork/roadmap
that referenced
this pull request
Feb 24, 2022
pdf export filename with quotes fails in chrome
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filename for pdf export is derived from plan title. If it has quotes in it, this fails in chrome. This removes the quotes.