Skip to content

PR for release v3.3.1#289

Merged
briri merged 161 commits intomainfrom
development
Aug 17, 2021
Merged

PR for release v3.3.1#289
briri merged 161 commits intomainfrom
development

Conversation

@briri
Copy link
Collaborator

@briri briri commented Aug 17, 2021

Researchers:

  • Your project start and end dates and grant information now appear on the coversheet of the PDF export DMPRoadmap #2972
  • Fixed an issue with sharing plans DMPRoadmap #2874
  • Fixed a bug that was preventing plans with a quote in the title from being exported DMPRoadmap #2883
  • Fixed an issue with user's appearing on the collaborators list even after they have been removed DMPRoadmap #2954

Admins:

Developers:

  • Fixed a bug that was generating a 500 error if a user left the email address blank when submitting the 'add collaborator' form
  • Fixed issues with the workflow for inviting users DMPRoadmap #2863, DMPRoadmap #2946
  • Modifications to maDMP functionality based on recent PRs to DMPRoadmap (contained some refactoring)
    • Rename fos table (FieldOfScience model) to research_domains (including plans.fos_id -> plans.research_domain_id
    • Rename repositories.url -> respoitories.homepage
    • Move re3data uri from the identifiers table to repositories.uri (see corresponding rake task: rails dmptool_specific:transfer_re3data_ids)
    • Rename licenses.url -> licenses.uri
    • Added new config settings that enable/disable maDMP functionality
    • Update API V1 to support new maDMP data
  • Fix for confusing override of org.plans
  • Updated gem and JS dependencies
  • Ran rake task to fix nil versionable_id values on phases, sections, questions, and question_options tables DMPRoadmap #2950

briri and others added 30 commits December 15, 2020 08:36
…tomization before attempting the transfer and then unpublishing it
briri added 29 commits August 4, 2021 11:27
Added tests

added tests for new external_api services

Added test for new presenter

change migration classname

fixes for rubocop and rspec

offerings to the rubocop gods

cleanup of unused code and added config for license opts

fixed tests

cleaned up schema

Fix for postgres regex matching

Fix for postgres regex matching

trying to fix postgres

updated config to disable research_outputs by default

updated plans_controller to work with new Plan.grant setter method

removed debug lines

fixed typo in plan model and added dependent destroy on a few associations

removed debug lines

fixed bug in v1 api due to removed Plan.api_client column

updated plan spec factory so that :creator ensures the owner's org matches the plan.org

added api_client association back to plans model. Added some Mysql vs Postgres helper methods to the ApplicationRecord base class

making rubocop happy

fix typo

making rubocop happy

trying to fix postgres :/

Hopefully fibally fixed postgres

Hopefully fibally fixed postgres

Hopefully fibally fixed postgres
@briri briri merged commit 9ce3a5a into main Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants