Merged
Conversation
…nvitation lose their plan share
…tomization before attempting the transfer and then unpublishing it
…ging the updated_at col when updating
…to versionable_id-fix
…p into roadmap-development
Added tests added tests for new external_api services Added test for new presenter change migration classname fixes for rubocop and rspec offerings to the rubocop gods cleanup of unused code and added config for license opts fixed tests cleaned up schema Fix for postgres regex matching Fix for postgres regex matching trying to fix postgres updated config to disable research_outputs by default updated plans_controller to work with new Plan.grant setter method removed debug lines fixed typo in plan model and added dependent destroy on a few associations removed debug lines fixed bug in v1 api due to removed Plan.api_client column updated plan spec factory so that :creator ensures the owner's org matches the plan.org added api_client association back to plans model. Added some Mysql vs Postgres helper methods to the ApplicationRecord base class making rubocop happy fix typo making rubocop happy trying to fix postgres :/ Hopefully fibally fixed postgres Hopefully fibally fixed postgres Hopefully fibally fixed postgres
…p into development
…o point to v2 helpers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Researchers:
Admins:
Developers:
fostable (FieldOfScience model) toresearch_domains(includingplans.fos_id->plans.research_domain_idrepositories.url->respoitories.homepageidentifierstable torepositories.uri(see corresponding rake task:rails dmptool_specific:transfer_re3data_ids)licenses.url->licenses.uriorg.plans