Skip to content

pdf export filename qith quotes fails in chrome #2883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raycarrick-ed merged 2 commits into from
Apr 21, 2021
Merged

pdf export filename qith quotes fails in chrome #2883

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81387dc
pdf export filename qith quotes fails in chrome
raycarrick-ed Apr 20, 2021
2f8a30a
Fixes for rubocop
raycarrick-ed Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/controllers/plan_exports_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ def file_name
ret = @plan.title
Zaru.sanitize! ret
ret = ret.strip.gsub(/\s+/, "_")
ret = ret.gsub(/"/, "")
# limit the filename length to 100 chars. Windows systems have a MAX_PATH allowance
# of 255 characters, so this should provide enough of the title to allow the user
# to understand which DMP it is and still allow for the file to be saved to a deeply
Expand Down