Add remaining fields to Personal Details edit page #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chubberlisk
force-pushed
the
122-personal-details-more-fields
branch
from
2592159
to
164832c
Compare
tvararu
force-pushed
the
122-personal-details-more-fields
branch
from
59fa114
to
43793c0
Compare
chubberlisk
force-pushed
the
122-personal-details-more-fields
branch
from
43793c0
to
c1e9c4b
Compare
- Add second nationality field - Add conditionally revealed `english_language_details` and `other_language_details`
chubberlisk
force-pushed
the
122-personal-details-more-fields
branch
from
c1e9c4b
to
673c29b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is a follow-up to #287, which introduced the model/controller/view, but didn't go so far as to implement every single field because then it would be quite long.
Changes proposed in this pull request
detailselementenglish_language_detailsandother_language_detailstext fields with word countGuidance to review
Nothing in particular 👀
Link to Trello card
122 - Allow users to fill in "Personal details" with validation
After screenshot
The alignment of the conditional content has been fixed upstream and will reach us soon™ via Dependabot: x-govuk/govuk-form-builder#50