Fix alignment of conditional content beneath radio buttons and checkboxes #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokogiri documents, by default, only allow for a single root element. As we're going to be moving the conditional content to the same level as the associated form control container we need to use Nokogiri::HTML::DocumentFragment to parse our parsed_subject memoized helper as it supports multi-root 'fragments' of HTML Refs #48
The custom matcher is required because using the normal css selectors it's impossible to ensure the element we find is at the root of the fragment. Refs #48
This bug was caused by the conditional content being inserted at the wrong level, it was a child of the `govuk-checkboxes__item` but should have been a sibling. Fixes #48
peteryates
deleted the
move-conditional-content-to-same-level-as-controlling-element
branch
peteryates
added a commit
that referenced
this pull request
Jan 9, 2020
…ame-level-as-controlling-element Fix alignment of conditional content beneath radio buttons and checkboxes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditional content, as explained in #48, was inserted in the wrong place causing it to render incorrectly. It has been moved so it's now in the correct position: