Skip to content

Commit

Permalink
Add translation strings for second nationality and english main language
Browse files Browse the repository at this point in the history
  • Loading branch information
Wen Ting Wang committed Oct 10, 2019
1 parent 5d16601 commit 164832c
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
6 changes: 3 additions & 3 deletions app/views/candidate_interface/personal_details/edit.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
</span>
</summary>
<div class="govuk-details__text">
<%= f.govuk_text_field 'nationalities', label: { text: 'Second nationality' }, multiple: true %>
<%= f.govuk_text_field 'nationalities', label: { text: t('application_form.personal_details.second_nationality.label'), }, multiple: true %>
</div>
</details>

Expand All @@ -37,14 +37,14 @@
<%= f.govuk_radio_button :english_main_language, 'yes',
label: { text: 'Yes' } do %>
<%= f.govuk_text_area :english_language_details,
label: { text: 'If you are bilingual or very familiar with languages other than English, you can tell us about them here.' },
label: { text: t('application_form.personal_details.english_main_language.yes_label') },
max_words: 200 %>
<% end %>
<%= f.govuk_radio_button :english_main_language, 'no',
label: { text: 'No' } do %>
<%= f.govuk_text_area :other_language_details,
label: { text: 'Please tell us about your English language qualifications (including grades or scores), and give details of other languages you are fluent in.' },
label: { text: t('application_form.personal_details.english_main_language.no_label') },
max_words: 200 %>
<% end %>
<% end %>
Expand Down
4 changes: 4 additions & 0 deletions config/locales/application_form.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ en:
hint_text: For example, 31 3 1980
nationality:
label: Nationality
second_nationality:
label: Second nationality
english_main_language:
label: Is English your main language?
yes_label: If you are bilingual or very familiar with languages other than English, you can tell us about them here.
no_label: Please tell us about your English language qualifications (including grades or scores), and give details of other languages you are fluent in.
complete_form_button: Continue
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def when_i_fill_in_the_form
fill_in t('application_form.personal_details.nationality.label'), with: 'British'
find('details').click
within('details') do
fill_in 'Second nationality', with: 'American' # TODO replace with translation
fill_in t('application_form.personal_details.second_nationality.label'), with: 'American' # TODO replace with translation
end

choose 'Yes'
Expand Down

0 comments on commit 164832c

Please sign in to comment.