-
Notifications
You must be signed in to change notification settings - Fork 1
feat(plate-balancing) : Support plate-balancing example in dairlib #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
57cd440
to
1bcc69c
Compare
3c1e562
to
bbd5e25
Compare
1bcc69c
to
e1f2869
Compare
I'm confused about why we use yaml string here instead of normal yaml. |
Pls remove commented codes. |
Missing documentation |
We'll need some documentation for input ports and output ports. |
e1f2869
to
720d12b
Compare
Pls add documentation. |
Using the difference in dimension of lambda and number of force basis to determine the contact model is generally not a safe way. Could we store the type of contact model in the |
a1a373d
to
80dd8e5
Compare
FYI, building with different drake versions doesnt seem to be an issue so far between dairlib and c3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 19 files reviewed, 6 unresolved discussions (waiting on @xuanhien070594)
systems/publishers/force_publisher.h
line 16 at r1 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
Missing documentation
Done.
systems/publishers/force_publisher.cc
line 16 at r1 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
We'll need some documentation for input ports and output ports.
Done.
systems/publishers/output_publisher.h
line 46 at r1 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
Pls remove commented codes.
Done.
systems/publishers/output_publisher.h
line 17 at r2 (raw file):
Previously, xuanhien070594 (Hien Bui) wrote…
Pls add documentation.
Done.
Should the name be |
cff8615
to
0ff39d9
Compare
0ff39d9
to
207d6ab
Compare
Fixes : #11
Support for : DAIRLab/dairlib#376
This change is