Repository navigation
ci: restore per-version coverage, add tui-less core job, spare main from cancel - #36
Closed
CryptoJones wants to merge 1 commit into
Closed
CryptoJones wants to merge 1 commit into
CryptoJones wants to merge 1 commit into
Conversation
…rom cancel Three CI-hardening fixes: - Never cancel in-progress runs on the default branch (#24): cancel-in-progress is now `${{ github.ref != 'refs/heads/main' }}`, so a fast follow-up push to main can't cancel the prior commit's test/security run. - Matrix lint/typecheck/security over 3.11/3.12/3.13 again (#25). pip-audit, mypy, and ruff had been narrowed to a single 3.12 job, so a CVE or typing regression that only surfaces under a version-marked dependency on 3.11/3.13 could merge green. gitleaks runs once (repo contents are version-independent). - Add a `core-install` job that syncs WITHOUT the tui extra (#20): every other job installs --extra tui, so an accidental top-level textual/selectolax import in a core module would pass CI but break `pip install perplexity-agent`. The job import-checks the core modules and runs the non-tui test subset. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jun 12, 2026
Owner
Author
|
Superseded by #47 (re-targeted onto v0.2.0; the original was built on a now-stale pre-v0.2.0 base and conflicts). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the CI-hardening cluster.
#24 —
cancel-in-progresscancelled main runscancel-in-progressis now${{ github.ref != 'refs/heads/main' }}. Superseded runs are still cancelled on feature branches/PRs to save minutes, but a fast follow-up push tomainno longer cancels the prior commit's test/security run — every commit that lands keeps a completed record.#25 — audit/typecheck/lint narrowed to 3.12 only
lint,typecheck, andsecurityare matrixed over 3.11/3.12/3.13 again. They had been collapsed to a single 3.12 job, so a CVE in (or a typing regression under) a dependency resolved only via apython_versionmarker on 3.11/3.13 could merge green.pip-auditandmypynow resolve and run per interpreter. gitleaks runs once (if: matrix.python-version == '3.12') since repo contents don't vary by Python.#20 — no CI coverage of a tui-less core install
New
core-installjob syncsuv sync --extra devwithout--extra tui— exactly whatpip install perplexity-agentgives. It import-checks every core module (catching an accidental top-leveltextual/selectolaximport) and runs the non-tui test subset (--ignore=tests/test_tui.py). Verified locally: core modules import clean, 66 non-tui tests collect, and the no-selectolaxextract_textfallback satisfies the fetch tests.Closes #20, closes #24, closes #25.
🤖 Generated with Claude Code