Skip to content

CI no longer exercises a tui-less core install (every job syncs --extra tui) #20

Description

@CryptoJones

Location: .github/workflows/ci.yml:61

The previous workflow ran the suite against uv sync --extra dev (no tui extra). Every new job (lint, typecheck, test, security) syncs --extra dev --extra tui.

Failure scenario: if a core module (server.py, __main__.py) gains an accidental top-level import of textual/selectolax (e.g. via from .fetch import ... or from .tui import ...), plain pip install perplexity-agent users get ImportError at server startup while CI stays green. The _run_tui missing-extra error path is also never exercised against a real core env.

Suggested fix: keep one matrix leg (or a dedicated job) on uv sync --extra dev only.

Found by /code-review (high effort).

Activity

  1. CryptoJones commented on Jun 15, 2026

    @CryptoJones
    OwnerAuthor

    Fixed: dedicated core-install CI job syncs --extra dev only, imports core modules, and runs non-tui tests (ci.yml:114).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions