fixes the duration field #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
americk0
requested review from
a team and
DevOpsDave
and removed request for
a team
DevOpsDave
previously approved these changes
Nov 1, 2024
americk0
added
the
release/patch
DevOpsDave
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log Items
alks sessions openDescription
Prior to this fix, the
-Dor--durationflags toalks sessions openweren't capturing the number passed along with the flag, but instead populated the field with a boolean value oftrueif the flag was present, andfalseotherwise, and internally javascript was coercing this value to a number (true=> 1,false=> 0). This meant that regardless of the duration specified, the duration was always being set to 1 hour. This code change fixes that