Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes the duration field #278

Merged
merged 3 commits into from
Nov 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions changelog.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@

Thanks for upgrading to the latest version of the ALKS CLI!

* Updates readme
* Adds deprecation warnings about role types
* Fixes duration flag for alks sessions open

Have feedback? https://github.com/Cox-Automotive/ALKS-CLI/issues

Expand Down
3 changes: 1 addition & 2 deletions dist/changelog.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@

Thanks for upgrading to the latest version of the ALKS CLI!

* Updates readme
* Adds deprecation warnings about role types
* Fixes duration flag for alks sessions open

Have feedback? https://github.com/Cox-Automotive/ALKS-CLI/issues

Expand Down
2 changes: 1 addition & 1 deletion dist/src/lib/getIamKey.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/src/lib/getIamKey.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/src/lib/program.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/src/lib/program.js.map

Large diffs are not rendered by default.

6 changes: 5 additions & 1 deletion src/lib/getIamKey.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,11 @@ export async function getIamKey(
white.underline(
`Creating new session in "${awsAccount.label ?? awsAccount.alias}" (id=${
awsAccount.id
} alias=${awsAccount.alias}) for ${alksRole}`
} alias=${
awsAccount.alias
}) for ${alksRole} expiring in ${duration} hour${
duration === 1 ? '' : 's'
}`
)
);

Expand Down
2 changes: 1 addition & 1 deletion src/lib/program.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ sessions
'uses your default account from "alks developer configure"'
)
.option(
'-D, --duration',
'-D, --duration <duration>',
'the duration of the session in hours. If the duration is over the max duration allowed for the role, the max duration will be used instead',
'12'
)
Expand Down
Loading