Merge pull request #278 from Cox-Automotive/fix-duration

fixes the duration field
Cox-Automotive · Nov 1, 2024 · 6e1b786 · 6e1b786
2 parents 2ecf99c + e052b8c
commit 6e1b786
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 10 deletions.
diff --git a/changelog.txt b/changelog.txt
@@ -3,8 +3,7 @@
 
 Thanks for upgrading to the latest version of the ALKS CLI!
 
-* Updates readme
-* Adds deprecation warnings about role types
+* Fixes duration flag for alks sessions open
 
 Have feedback? https://github.com/Cox-Automotive/ALKS-CLI/issues
 

diff --git a/dist/changelog.txt b/dist/changelog.txt
@@ -3,8 +3,7 @@
 
 Thanks for upgrading to the latest version of the ALKS CLI!
 
-* Updates readme
-* Adds deprecation warnings about role types
+* Fixes duration flag for alks sessions open
 
 Have feedback? https://github.com/Cox-Automotive/ALKS-CLI/issues
 

diff --git a/dist/src/lib/getIamKey.js b/dist/src/lib/getIamKey.js
diff --git a/dist/src/lib/getIamKey.js.map b/dist/src/lib/getIamKey.js.map
diff --git a/dist/src/lib/program.js b/dist/src/lib/program.js
diff --git a/dist/src/lib/program.js.map b/dist/src/lib/program.js.map
diff --git a/src/lib/getIamKey.ts b/src/lib/getIamKey.ts
@@ -91,7 +91,11 @@ export async function getIamKey(
     white.underline(
       `Creating new session in "${awsAccount.label ?? awsAccount.alias}" (id=${
         awsAccount.id
-      } alias=${awsAccount.alias}) for ${alksRole}`
+      } alias=${
+        awsAccount.alias
+      }) for ${alksRole} expiring in ${duration} hour${
+        duration === 1 ? '' : 's'
+      }`
     )
   );
 

diff --git a/src/lib/program.ts b/src/lib/program.ts
@@ -97,7 +97,7 @@ sessions
     'uses your default account from "alks developer configure"'
   )
   .option(
-    '-D, --duration',
+    '-D, --duration <duration>',
     'the duration of the session in hours. If the duration is over the max duration allowed for the role, the max duration will be used instead',
     '12'
   )