Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Course generation takes 10 times longer on new version #3457

Closed
Martin-L45 opened this issue Sep 23, 2024 · 21 comments · Fixed by #3459
Closed

[Question] Course generation takes 10 times longer on new version #3457

Martin-L45 opened this issue Sep 23, 2024 · 21 comments · Fixed by #3459
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Martin-L45
Copy link

I am playing on a custom 4xmap with very large fields 100+ Hectares. I have never had issues generating a course on this map.
When using the new version it takes about 10 times longer to generate a course approx. 47minutes.
Is this a bug or do you believe it is on my end?
the Version 7420 i am using is the main after issue #3399

logV7420.txt
logV7421.txt

@Martin-L45 Martin-L45 added the question Further information is requested label Sep 23, 2024
@Tensuko
Copy link
Contributor

Tensuko commented Sep 23, 2024

I have not noticed any difference, but I don't have those XXXXL fields.
Addition:
Same settings used?

@Martin-L45
Copy link
Author

Everything is the same.

@Tensuko
Copy link
Contributor

Tensuko commented Sep 23, 2024

But this one is not on the 100+ HA field I hope...
"working width: 1.0"

@pvaiko
Copy link
Contributor

pvaiko commented Sep 23, 2024

@Martin-L45 don't think it is on your end. Does the field have islands? Can you try with island bypass off?

@pvaiko
Copy link
Contributor

pvaiko commented Sep 23, 2024

But this one is not on the 100+ HA field I hope... "working width: 1.0"

That's our island detection.

@Martin-L45
Copy link
Author

Martin-L45 commented Sep 23, 2024

I´ll try with island bypass off
Tool is a 30,6meter seeder

@Martin-L45
Copy link
Author

Without islands it only took about a minute
log.txt

@pvaiko
Copy link
Contributor

pvaiko commented Sep 23, 2024

Thanks, confirmed bug.

@pvaiko pvaiko added bug Something isn't working and removed question Further information is requested labels Sep 23, 2024
@pvaiko pvaiko linked a pull request Sep 23, 2024 that will close this issue
@Tensuko Tensuko added this to the 7.4.2.2 milestone Sep 24, 2024
@cwattyeso
Copy link

May I also add that with the current version of Courseplay loading into a Save Game on a 4X or larger map takes an incredibly long amount of time now, and going into the game menu and performing a save takes an incredibly long amount of time also. Never happened on Version v7.4.1.3 at all. However since 7.4.2.0 this issue has appeared.

@Tensuko
Copy link
Contributor

Tensuko commented Sep 25, 2024

Thats too less informations.

@pvaiko
Copy link
Contributor

pvaiko commented Sep 25, 2024

an incredibly long amount of time
Can you quantify?

I changed the serialization of courses to XML to a more readable and straightforward format with no obscure encoding, it is certainly chattier than the old format but was hoping it is still fast enough.

Do you have a savegame I can look at? With a publicly available map?

@cwattyeso
Copy link

I can provide my save file definitely and also a link to the map I'm playing on. I wondered if the increased loading and saving time was caused by using two root crop harvesters (Only 4 meters working width) and a huge field, because in the map view there is a hell of a lot of courseplay stuff going on in that field. I'm not saying I set the course up optimally for the field, and didn't know the above about deactivating the Island Bypass bit, so maybe the course being loaded upon game start and each time the game is saved is a bit excessive.

@pvaiko
Copy link
Contributor

pvaiko commented Sep 25, 2024

Island bypass should only matter when you generate.

Would be great if we could compare apples to apples, if you now have two 40 km long courses you did not have with 7.4.1.3, that may skew the results a bit...

@Martin-L45
Copy link
Author

Martin-L45 commented Sep 25, 2024

I tried the last commit. (I hope that is ok)

Now it does not detect the islands.

log.txt
Farming Simulator 22 Screenshot 2024 09 25 - 18 42 51 24

@pvaiko
Copy link
Contributor

pvaiko commented Sep 25, 2024

I tried the last commit. (I hope that is ok)

Sure, thanks for testing, I did not have a chance yet to test on a map with a real island. Will look into it.

@cwattyeso
Copy link

cwattyeso commented Sep 25, 2024

Island bypass should only matter when you generate.

Would be great if we could compare apples to apples, if you now have two 40 km long courses you did not have with 7.4.1.3, that may skew the results a bit...

I don't have any saved courses on game since updating Courseplay to current version. I deleted all old 7.4.1.3 as wondered if too much old info was causing the game to take so long to load and save. I now have literally just the one course created and saved on the map and it's still causing the game to load and save slow. If I disable Courseplay in the mod menu before loading, the loading and saving goes back to normal pretty much.

The map I'm playing on is Flatout Farm and can be downloaded from Author's Google Drive Link: https://drive.google.com/file/d/1OaMceN3iVUpeNYSfsorqND8uR-aEH6e9/view

My save game:
savegame13.zip

Harvesters I'm using on the Course are from the Giants ModHub https://www.farming-simulator.com/mod.php?lang=en&country=us&mod_id=253608&title=fs2022

@Martin-L45
Copy link
Author

I tried your last commit.

Perfect course generation. Only about 2 minutes. Detects the island with no issues.
There is a couple of warnings in the log. But i think that is field related.

log.txt

Farming Simulator 22 Screenshot 2024 09 26 - 19 27 18 86

@pvaiko
Copy link
Contributor

pvaiko commented Sep 26, 2024

Thanks, warnings are normal, removed some forgotten debug messages too.

@Martin-L45
Copy link
Author

With multiple tools the result can get a bit weird. But by adjusting number of headlands and starting position i can get a good course.
Farming Simulator 22 Screenshot 2024 09 26 - 20 15 33 22
Farming Simulator 22 Screenshot 2024 09 26 - 20 22 21 99
Farming Simulator 22 Screenshot 2024 09 26 - 20 26 52 07

@Tensuko
Copy link
Contributor

Tensuko commented Sep 26, 2024

There is always a limit :)

@Martin-L45
Copy link
Author

very true.
And that is no problem when i can generate a course in 2minutes. Compared to 47minutes.😊

Tensuko added a commit that referenced this issue Sep 28, 2024
- Plow fixes for SP and MP as well as rotation enhancements #3413
- MP and SP Hud Mode selection bugs fixed #3451
- Fix for #3454
- Fix for #3463
- Fix for #3469
- Faster course generation, load and save #3457 #3461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants