Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG_SP]Pathfinder turn doesn't take headland to drive to the next start of the row and after game restart, transition WP seems to change into a turn WP. #3399

Closed
Martin-L45 opened this issue Sep 4, 2024 · 20 comments · Fixed by #3411
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Martin-L45
Copy link

Martin-L45 commented Sep 4, 2024

READ FIRST
https://github.com/Courseplay/Courseplay_FS22/wiki

Steps to reproduce
Steps to reproduce the behavior.

Actual behavior
A clear and concise description of what happen.

When moving to the next part of the field the tool does not stay inside the field border.

Expected behavior
A clear and concise description of what you expected to happen.

The vehicle and tool stay in the field. If possible follow the headland track

Screenshots
If applicable, add screenshots to help explain your problem.

Farming Simulator 22 Screenshot 2024 09 04 - 14 16 44 47
Farming Simulator 22 Screenshot 2024 09 04 - 14 16 44 47

Farming Simulator 22 Screenshot 2024 09 04 - 14 16 04 25

Courseplay version
Version used:

7.4.2.0 with fix for #3388

Log
Please attach a log with all debug channels active.
For help with the debug channels,
please check out the readme at the github front page.

log.txt

Map
Map played on.
Alma Missouri

Vehicles/ implements involved
Which vehicle or implement?
Mod yes/no ?
Ingame 9rx and 1775nt planter

Relevant script mods
Mods like Autodrive or VCA and so on.

@Martin-L45 Martin-L45 added the bug Something isn't working label Sep 4, 2024
@Tensuko
Copy link
Contributor

Tensuko commented Sep 5, 2024

Can you give me a savegame with the course loaded?

@Martin-L45
Copy link
Author

Martin-L45 commented Sep 5, 2024

Its starting to get a bit weird. The behavior of the tractor changes after i save and restart the game.
Before save

Farming Simulator 22 Screenshot 2024 09 05 - 13 52 55 72

Farming Simulator 22 Screenshot 2024 09 05 - 13 53 02 41

After save

Farming Simulator 22 Screenshot 2024 09 05 - 13 54 43 42
Farming Simulator 22 Screenshot 2024 09 05 - 13 55 31 48

link to savegame
https://www.mediafire.com/file/iijakummsaxm1gr/savegame.zip/file

Settings and start point

Farming Simulator 22 Screenshot 2024 09 05 - 14 02 34 68
Farming Simulator 22 Screenshot 2024 09 05 - 14 02 45 59

@Martin-L45
Copy link
Author

Martin-L45 commented Sep 5, 2024

Different equipment similar issue. The vehicle behaves different after save and restart.

Before save

Farming Simulator 22 Screenshot 2024 09 05 - 14 50 00 77

Farming Simulator 22 Screenshot 2024 09 05 - 14 50 08 71

After save and restart. The vehicle is forced into a reverse course. Even when reverse is not allowed.
xml has allowTurnBackward value="false" on both seeder and aircart

Farming Simulator 22 Screenshot 2024 09 05 - 14 52 17 78

Farming Simulator 22 Screenshot 2024 09 05 - 14 52 47 26
Farming Simulator 22 Screenshot 2024 09 05 - 14 53 35 14

@Tensuko
Copy link
Contributor

Tensuko commented Sep 5, 2024

Pretty sure you just catched a different waypoint with start at nearest since the target is a completly different position.

@Martin-L45
Copy link
Author

I´ll try again. and make sure it catches the right track.

@Tensuko
Copy link
Contributor

Tensuko commented Sep 5, 2024

You don't have to, this does not help us anyway.

@Martin-L45
Copy link
Author

I did it anyway 😊
Same result as before. Vehicle is forced into a reverse course.
Let me know if you need anything from me.

@Tensuko
Copy link
Contributor

Tensuko commented Sep 5, 2024

@pvaiko
grafik
grafik
Seems like a Waypoint changed to a turn after restart, that means saveing the course is faulty, maybe transition WP is broken?

@Tensuko
Copy link
Contributor

Tensuko commented Sep 5, 2024

@Martin-L45 This is your "not respect field border"?
grafik

@Martin-L45
Copy link
Author

Yes. It seems to only check for the size of the tractor. not the Working width of the tool it is pulling.

@Tensuko
Copy link
Contributor

Tensuko commented Sep 5, 2024

Yes. It seems to only check for the size of the tractor. not the Working width of the tool it is pulling.

Got nothing to do with that.

@Tensuko Tensuko changed the title [BUG_SP]vehicle does not respect field border when moving to next workarea [BUG_SP]Pathfinder turn doesn't take headland to drive to the next start of the row and after game restart, transition WP seems to change into a turn WP. Sep 5, 2024
@pvaiko
Copy link
Contributor

pvaiko commented Sep 5, 2024

Seems like a Waypoint changed to a turn after restart, that means saveing the course is faulty, maybe transition WP is broken?

Yeah, I'll check that, we are screwing up something when loading the course from the savegame.

@pvaiko
Copy link
Contributor

pvaiko commented Sep 5, 2024

Yes. It seems to only check for the size of the tractor. not the Working width of the tool it is pulling.

Yes, when switching from one block to the other, we just use the pathfinder and definitely ignore the working width. We aren't using the headlands in this case (unlike in turns where the other row is far away), just plain old pathfinding.

@pvaiko
Copy link
Contributor

pvaiko commented Sep 7, 2024

I have to correct myself: we do use the headland, actually, the originally generated connecting path as a 'preferredPath' for the pathfinder, so the pathfinding should apply a negative penalty for anything close to this connecting path.

As a result, the pathfinder course should be around/close to the headland.

@pvaiko pvaiko linked a pull request Sep 8, 2024 that will close this issue
@Tensuko Tensuko added this to the 7.4.2.1 milestone Sep 8, 2024
@Martin-L45
Copy link
Author

Martin-L45 commented Sep 9, 2024

@pvaiko
I have been trying your fix. But i have run into a issue. The tractor gets stuck in this position. It seems to have found a path but i will not drive.

Farming Simulator 22 Screenshot 2024 09 09 - 17 50 18 66

log.txt

https://www.mediafire.com/file/rk9q07k2xaot962/savegame.zip/file

@Tensuko
Copy link
Contributor

Tensuko commented Sep 9, 2024

Just wait untill we are done...

@pvaiko
Copy link
Contributor

pvaiko commented Sep 9, 2024

@pvaiko I have been trying your fix. But i have run into a issue. The tractor gets stuck in this position. It seems to have found a path but i will not drive.

Pull request is still Draft, meaning we are still working on it. Wait until it is ready for review.

@Martin-L45
Copy link
Author

Understood ( i didn't see it was a draft. My mistake)

@Tensuko
Copy link
Contributor

Tensuko commented Sep 10, 2024

You can now try out current main if you want.

@Martin-L45
Copy link
Author

I have just tried every setup i had issues with before. And now i can not get it to fail!!
I must admit this issue got a lot more complicated than i expected when i first opened it.
Awesome work guys.

Tensuko added a commit that referenced this issue Sep 20, 2024
WARNING: While this version is backwards compatible with older savegames, it'll write the courses to the savegame in a new format. Vesions before 7.4.2.0 WILL NOT BE ABLE TO READ the games saved with this version! If you install this version, and decide to revert to an old one, YOU MUST BACK UP YOUR OLD SAVEGAME before!

- Even row width setting does work now #3423
- Fix for a strange waypoint transformation #3399
- Narrow field is now fixed too #3387
- Transition fix #3387
- Another fix for Bale Unloader #3381
- Fix for #3378
- Fix for plows not starting the work after headland #3413
- Vehicles in 180° turns near a diagonal field border are not leaving the field anymore.
- Fix for Multitool #3379

New for Multitool:
- A multitool now contains 2-5 single course for each lane depending on the amount of vehicles you selected.
- That course is switched when switching the lane.
- The old "symetric lane change" got renamed to "switching lanes" and hopefully is more clear about what it does and have to be selected in the generator before generating the course.
- Multitool courses saved by older versions will not work, you'll need to regenerate them!

Known Issue:
After reconnecting to the server, the selected lane setting for multitool gets reset and won't show the correct lane, but the tool keeps working on the correct one. This will be fixed in a later version, as we don't want to wait longer with important fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants