-
Notifications
You must be signed in to change notification settings - Fork 489
add grpc vm interface #2270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
faddat
wants to merge
17
commits into
CosmWasm:main
Choose a base branch
from
faddat:faddat/grpc-wasmd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add grpc vm interface #2270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+324
to
+332
for checksum, metrics := range resp.PinnedMetrics.PerModule { | ||
perModule = append(perModule, wasmvmtypes.PerModuleEntry{ | ||
Checksum: wasmvmtypes.Checksum(checksum), | ||
Metrics: wasmvmtypes.PerModuleMetrics{ | ||
Hits: metrics.Hits, | ||
Size: metrics.Size, | ||
}, | ||
}) | ||
} |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Iteration over map may be a possible source of non-determinism
Comment on lines
+477
to
+485
for checksum, metrics := range resp.PinnedMetrics.PerModule { | ||
perModule = append(perModule, wasmvmtypes.PerModuleEntry{ | ||
Checksum: wasmvmtypes.Checksum(checksum), | ||
Metrics: wasmvmtypes.PerModuleMetrics{ | ||
Hits: metrics.Hits, | ||
Size: metrics.Size, | ||
}, | ||
}) | ||
} |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Iteration over map may be a possible source of non-determinism
* Bump cosmos-sdk v0.53.0 * remove crisis module * fix simulations * Suppress lint errors * Fix golangci-lint warnings * Remove unnecessary loop copy * Updates * [autofix.ci] apply automated fixes * fix: Disable IAVL prunning to prevent dangling goroutines in tests * fix: Try to use newer golangci * Increase resources for lint * Update golangci-lint (CosmWasm#2269) * Remove deprecated golangci-lint configs * Update golangci-lint * Apply linter fixes --------- Co-authored-by: Christoph Otter <chris@confio.gmbh> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Tomasz Kulik <tomek.kulik2@gmail.com>
…nto faddat/grpc-wasmd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add grpc vm interface. Can be used with the grpc virtual machine found here:
to start the vm you do:
the grpc vm will serve on port 50051
wasmd is set to connect to wasmvm using the .proto file's interface. This allows us to secure the boundary between the contract execution environment and our chain binary.