Skip to content

Update golangci-lint #2269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2025
Merged

Update golangci-lint #2269

merged 3 commits into from
May 26, 2025

Conversation

chipshort
Copy link
Collaborator

This seems to fix the linter job failure.

Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.00%. Comparing base (1eaa762) to head (8d4d126).
Report is 1 commits behind head on bump_sdk_v53.

Files with missing lines Patch % Lines
app/app.go 50.00% 2 Missing ⚠️
app/export.go 50.00% 1 Missing ⚠️
tests/wasmibctesting/utils.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           bump_sdk_v53    #2269   +/-   ##
=============================================
  Coverage         45.99%   46.00%           
=============================================
  Files                79       79           
  Lines             10680    10678    -2     
=============================================
  Hits               4912     4912           
+ Misses             5334     5332    -2     
  Partials            434      434           
Files with missing lines Coverage Δ
app/export.go 9.67% <50.00%> (+0.15%) ⬆️
tests/wasmibctesting/utils.go 0.00% <0.00%> (ø)
app/app.go 86.59% <50.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chipshort chipshort force-pushed the co/test-linter-kill branch from fcb2532 to 8d4d126 Compare May 26, 2025 10:34
@chipshort chipshort requested a review from pinosu May 26, 2025 10:34
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM 👍

@pinosu pinosu merged commit 7a94243 into bump_sdk_v53 May 26, 2025
13 of 14 checks passed
@pinosu pinosu deleted the co/test-linter-kill branch May 26, 2025 10:55
pinosu added a commit that referenced this pull request May 26, 2025
* Bump cosmos-sdk v0.53.0

* remove crisis module

* fix simulations

* Suppress lint errors

* Fix golangci-lint warnings

* Remove unnecessary loop copy

* Updates

* [autofix.ci] apply automated fixes

* fix: Disable IAVL prunning to prevent dangling goroutines in tests

* fix: Try to use newer golangci

* Increase resources for lint

* Update golangci-lint (#2269)

* Remove deprecated golangci-lint configs

* Update golangci-lint

* Apply linter fixes

---------

Co-authored-by: Christoph Otter <chris@confio.gmbh>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Tomasz Kulik <tomek.kulik2@gmail.com>
pinosu added a commit that referenced this pull request May 26, 2025
* Bump cosmos-sdk v0.53.0

* remove crisis module

* fix simulations

* Suppress lint errors

* Fix golangci-lint warnings

* Remove unnecessary loop copy

* Updates

* [autofix.ci] apply automated fixes

* fix: Disable IAVL prunning to prevent dangling goroutines in tests

* fix: Try to use newer golangci

* Increase resources for lint

* Update golangci-lint (#2269)

* Remove deprecated golangci-lint configs

* Update golangci-lint

* Apply linter fixes

---------

Co-authored-by: Christoph Otter <chris@confio.gmbh>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Tomasz Kulik <tomek.kulik2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants