-
Notifications
You must be signed in to change notification settings - Fork 489
Bump cosmos-sdk v0.53.0 #2250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump cosmos-sdk v0.53.0 #2250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look alright to me so far, but what's happening with the CI?
I have the same problem with benchmarks tests as CI on my machine. Btw. we need that for IBCv2 implementation on 0.55.x / 0.56.x - I guess we'd need to backport this. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## releases/v0.6x #2250 +/- ##
==================================================
+ Coverage 45.98% 46.00% +0.01%
==================================================
Files 78 79 +1
Lines 10685 10678 -7
==================================================
- Hits 4914 4912 -2
+ Misses 5335 5332 -3
+ Partials 436 434 -2
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for getting this done!
We can avoid the resource upgrade for the linter by upgrading to latest golangci-lint, but that can be handled separately (see #2269).
We should also backport this to the main branch |
sure! should we get also the linter issue fixed in this PR so that when backported has already everything in place? |
Sure, we can do it like that too. I just rebased #2269 on this PR. It merges into here, so if you are happy with it, feel free to merge and then we can backport this whole PR. |
* Remove deprecated golangci-lint configs * Update golangci-lint * Apply linter fixes
* Bump cosmos-sdk v0.53.0 * remove crisis module * fix simulations * Suppress lint errors * Fix golangci-lint warnings * Remove unnecessary loop copy * Updates * [autofix.ci] apply automated fixes * fix: Disable IAVL prunning to prevent dangling goroutines in tests * fix: Try to use newer golangci * Increase resources for lint * Update golangci-lint (#2269) * Remove deprecated golangci-lint configs * Update golangci-lint * Apply linter fixes --------- Co-authored-by: Christoph Otter <chris@confio.gmbh> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Tomasz Kulik <tomek.kulik2@gmail.com>
No description provided.