Skip to content

Bump cosmos-sdk v0.53.0 #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 26, 2025
Merged

Bump cosmos-sdk v0.53.0 #2250

merged 12 commits into from
May 26, 2025

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented May 9, 2025

No description provided.

Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look alright to me so far, but what's happening with the CI?

@kulikthebird
Copy link
Member

kulikthebird commented May 22, 2025

I have the same problem with benchmarks tests as CI on my machine. Btw. we need that for IBCv2 implementation on 0.55.x / 0.56.x - I guess we'd need to backport this.

@kulikthebird kulikthebird requested a review from chipshort May 23, 2025 07:02
Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 93.91304% with 7 lines in your changes missing coverage. Please review.

Project coverage is 46.00%. Comparing base (3565576) to head (7a94243).
Report is 1 commits behind head on releases/v0.6x.

Files with missing lines Patch % Lines
app/upgrades/v060/upgrades.go 0.00% 3 Missing ⚠️
app/app.go 98.16% 2 Missing ⚠️
app/export.go 50.00% 1 Missing ⚠️
tests/wasmibctesting/utils.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           releases/v0.6x    #2250      +/-   ##
==================================================
+ Coverage           45.98%   46.00%   +0.01%     
==================================================
  Files                  78       79       +1     
  Lines               10685    10678       -7     
==================================================
- Hits                 4914     4912       -2     
+ Misses               5335     5332       -3     
+ Partials              436      434       -2     
Files with missing lines Coverage Δ
app/upgrades.go 67.85% <ø> (-16.89%) ⬇️
app/export.go 9.67% <50.00%> (+0.30%) ⬆️
tests/wasmibctesting/utils.go 0.00% <0.00%> (ø)
app/app.go 86.59% <98.16%> (+1.35%) ⬆️
app/upgrades/v060/upgrades.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for getting this done!
We can avoid the resource upgrade for the linter by upgrading to latest golangci-lint, but that can be handled separately (see #2269).

@chipshort
Copy link
Collaborator

We should also backport this to the main branch

@pinosu
Copy link
Contributor Author

pinosu commented May 26, 2025

We should also backport this to the main branch

sure! should we get also the linter issue fixed in this PR so that when backported has already everything in place?

@chipshort
Copy link
Collaborator

sure! should we get also the linter issue fixed in this PR so that when backported has already everything in place?

Sure, we can do it like that too. I just rebased #2269 on this PR. It merges into here, so if you are happy with it, feel free to merge and then we can backport this whole PR.

* Remove deprecated golangci-lint configs

* Update golangci-lint

* Apply linter fixes
@pinosu pinosu merged commit 15d0f29 into releases/v0.6x May 26, 2025
19 checks passed
@pinosu pinosu deleted the bump_sdk_v53 branch May 26, 2025 13:42
pinosu added a commit that referenced this pull request May 26, 2025
* Bump cosmos-sdk v0.53.0

* remove crisis module

* fix simulations

* Suppress lint errors

* Fix golangci-lint warnings

* Remove unnecessary loop copy

* Updates

* [autofix.ci] apply automated fixes

* fix: Disable IAVL prunning to prevent dangling goroutines in tests

* fix: Try to use newer golangci

* Increase resources for lint

* Update golangci-lint (#2269)

* Remove deprecated golangci-lint configs

* Update golangci-lint

* Apply linter fixes

---------

Co-authored-by: Christoph Otter <chris@confio.gmbh>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Tomasz Kulik <tomek.kulik2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants