Skip to content

Rename Features to Capabilities #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 17, 2022
Merged

Rename Features to Capabilities #1387

merged 6 commits into from
Aug 17, 2022

Conversation

webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Aug 17, 2022

Based on #1383

@webmaster128 webmaster128 requested a review from uint August 17, 2022 09:00
@webmaster128 webmaster128 added this to the 1.1.0 milestone Aug 17, 2022
@webmaster128 webmaster128 force-pushed the features-to-capabilities branch from b6faf8f to 0415d2b Compare August 17, 2022 11:29
@@ -641,20 +646,19 @@ mod tests {
)
.unwrap();
let module = deserialize_wasm(&wasm).unwrap();
let supported = [
let available = [
"water".to_string(),
"nutrients".to_string(),
"sun".to_string(),
"freedom".to_string(),
Copy link
Contributor

@uint uint Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the PR, but I love this 😁

Copy link
Contributor

@uint uint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and very thorough. I ran a grep-find to find any leftover places with feature, but didn't find any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants