Skip to content

Use clippy from Rust 1.63.0 in CI #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Use clippy from Rust 1.63.0 in CI #1383

merged 3 commits into from
Aug 17, 2022

Conversation

webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Aug 15, 2022

Most changes here are due to the this new clippy rule: https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

@uint please have a look at the schema-derive change in particular

@uint
Copy link
Contributor

uint commented Aug 17, 2022

I guess you're not adding Eq to the macro expansion since someone might want to use a type that is PartialEq but not Eq in a message struct?

Copy link
Contributor

@uint uint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks good

@webmaster128
Copy link
Member Author

I guess you're not adding Eq to the macro expansion since someone might want to use a type that is PartialEq but not Eq in a message struct?

Yes, that's the idea. Eq is hardly needed. So I'd not make it a requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants