fix(governance): reject malformed production-evidence UTF-8 - #279
fix(governance): reject malformed production-evidence UTF-8#279seonghobae wants to merge 4 commits into
Conversation
|
Warning Review limit reached
Next review available in: 59 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Preserve the reviewed two-path fatal UTF-8 governance evidence hardening while integrating the protected nanoid and Node 24 workflow baselines without destructive history rewriting.
Carry the fatal UTF-8 production-governance evidence hardening across the protected exchange media-type integration while preserving the reviewed two-path diff and non-destructive history.
|
@coderabbitai review Review exact current head |
Rate Limit Exceeded
|
1 participant
Purpose
Harden Noema's production-environment governance collector so malformed GitHub CLI bytes cannot be replacement-decoded into a different but parseable JSON evidence document.
Exact identities
4573a6f7eaf904e19a6e3198c8cabcfd4be40c40778e5eecfaea8b6f0d984e38d460ad450801b690581589cee640146f2c1678a97428cef88f1eb417fix/production-environment-fatal-utf8GREEN implementation
The audit keeps
ghstdout/stderr as bounded raw bytes and decodes them withTextDecoder("utf-8", { fatal: true }). Invalid bytes on successful output or failure diagnostics fail closed with bounded deterministic errors. Token redaction, shell-free subprocess execution, explicit child environment, 2 MiB output ceiling, exact GitHub API version, JSON parsing, and production-policy evaluation remain unchanged.Focused tests prove malformed UTF-8 is rejected instead of replacement-decoded and valid UTF-8 is decoded exactly.
Restack and verification boundary
The branch was merged non-destructively with protected
mainafter #272, #266, and #275. Its current two-path diff remains limited toscripts/production-environment-governance-audit.mjsandtest/production-environment-governance.test.ts.Historical predecessor evidence does not transfer. Application
ci,reviewer-ci, protected-base-eligibleSecurity Scan, and fresh review must complete successfully on unchanged current head581589cee640146f2c1678a97428cef88f1eb417before merge. Pending, queued, skipped, absent, neutral, failed, cancelled, stale, predecessor, status-only, model-only, or rate-limited evidence is non-passing.This repository-owned evidence hardening does not assert that a live
productionenvironment exists or passes. The live control-plane acceptance in issue #40 remains separate.No repair/self-modifying workflow, protection weakening, reviewer or secret invention, audit waiver, release, deployment, or synthetic production-environment claim.