fix(governance): restack fatal UTF-8 production evidence boundary - #344
fix(governance): restack fatal UTF-8 production evidence boundary#344seonghobae wants to merge 2 commits into
Conversation
|
Warning Review limit reached
Next review available in: 58 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Purpose
Restack the bounded production-environment evidence UTF-8 hardening from #279 onto the current protected
mainwithout overwriting later production-governance tests or carrying predecessor validation evidence.Exact construction
mainimmediately before construction:f1846b322290a7ddefe20a6f835884e7c9a0f6a2;581589cee640146f2c1678a97428cef88f1eb417;d07d76c47122cfe9a3d1a92b28a464d94d31e721;bb61a1c9a3583b0ef287872f4e6fa62a9233bcce;41e937d748d8e4a80cb9db706cbf6b5958ef2c25;ccc955fe5c144425eb9b58c6d81e2430c71f8175;The predecessor base-to-current-main comparison showed no intervening protected-main modification to
scripts/production-environment-governance-audit.mjs, so the exact source implementation blob could be overlaid safely. The predecessor's originaltest/production-environment-governance.test.tspath was modified later on protected main by production-rule ambiguity work, so that stale test blob was deliberately not copied. Instead this successor adds a focusedtest/production-environment-governance-utf8.test.ts, preserving all current protected-main tests byte-for-byte.RED → GREEN
The RED commit adds only the focused boundary test against unchanged protected-main production code. It requires an exported fatal decoder that the protected-main source does not yet provide. The GREEN commit then applies the exact bounded source implementation from stable #279.
The audit now keeps
ghstdout/stderr as bounded raw bytes and decodes them withTextDecoder("utf-8", { fatal: true }). Malformed UTF-8 fails closed before JSON evidence can be replacement-decoded into a different parseable document. Existing shell-free subprocess execution, explicit child environment, 2 MiB output ceiling, token redaction, GitHub API version binding, JSON parsing, and production-policy evaluation remain in place.Evidence boundary
No CI, scanner, review, coverage, model, production-environment, deployment, or release evidence from #279 transfers to this successor. Keep this PR Draft until this unchanged exact head has fresh terminal-success application
ci,reviewer-ci, protected-base-eligible centralSecurity Scan, exact 100% owned-production statement/branch/function/line coverage with realistic tests, and zero valid unresolved findings. Pending/queued/skipped/absent/neutral/failed/cancelled/stale/predecessor/status-only/model-only/rate-limited evidence is non-passing.This repository-owned evidence hardening does not claim that a live
productionenvironment exists or passes; issue #40 remains a separate control-plane acceptance gap. No policy weakening, reviewer/secret invention, repair workflow, release, deployment, outbound-license choice, or synthetic production evidence is included.#279 should be closed as superseded only after this successor reaches protected-main truth.