Skip to content

fix(governance): restack fatal UTF-8 production evidence boundary - #344

Closed
seonghobae wants to merge 2 commits into
mainfrom
fix/production-environment-utf8-f1846b
Closed

fix(governance): restack fatal UTF-8 production evidence boundary#344
seonghobae wants to merge 2 commits into
mainfrom
fix/production-environment-utf8-f1846b

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Purpose

Restack the bounded production-environment evidence UTF-8 hardening from #279 onto the current protected main without overwriting later production-governance tests or carrying predecessor validation evidence.

Exact construction

  • protected main immediately before construction: f1846b322290a7ddefe20a6f835884e7c9a0f6a2;
  • stable source fix(governance): reject malformed production-evidence UTF-8 #279 exact head: 581589cee640146f2c1678a97428cef88f1eb417;
  • source implementation blob: d07d76c47122cfe9a3d1a92b28a464d94d31e721;
  • current-main source blob before the change: bb61a1c9a3583b0ef287872f4e6fa62a9233bcce;
  • RED commit: 41e937d748d8e4a80cb9db706cbf6b5958ef2c25;
  • GREEN exact head: ccc955fe5c144425eb9b58c6d81e2430c71f8175;
  • ancestry: 2 commits ahead / 0 behind, merge base exactly the protected-main SHA above.

The predecessor base-to-current-main comparison showed no intervening protected-main modification to scripts/production-environment-governance-audit.mjs, so the exact source implementation blob could be overlaid safely. The predecessor's original test/production-environment-governance.test.ts path was modified later on protected main by production-rule ambiguity work, so that stale test blob was deliberately not copied. Instead this successor adds a focused test/production-environment-governance-utf8.test.ts, preserving all current protected-main tests byte-for-byte.

RED → GREEN

The RED commit adds only the focused boundary test against unchanged protected-main production code. It requires an exported fatal decoder that the protected-main source does not yet provide. The GREEN commit then applies the exact bounded source implementation from stable #279.

The audit now keeps gh stdout/stderr as bounded raw bytes and decodes them with TextDecoder("utf-8", { fatal: true }). Malformed UTF-8 fails closed before JSON evidence can be replacement-decoded into a different parseable document. Existing shell-free subprocess execution, explicit child environment, 2 MiB output ceiling, token redaction, GitHub API version binding, JSON parsing, and production-policy evaluation remain in place.

Evidence boundary

No CI, scanner, review, coverage, model, production-environment, deployment, or release evidence from #279 transfers to this successor. Keep this PR Draft until this unchanged exact head has fresh terminal-success application ci, reviewer-ci, protected-base-eligible central Security Scan, exact 100% owned-production statement/branch/function/line coverage with realistic tests, and zero valid unresolved findings. Pending/queued/skipped/absent/neutral/failed/cancelled/stale/predecessor/status-only/model-only/rate-limited evidence is non-passing.

This repository-owned evidence hardening does not claim that a live production environment exists or passes; issue #40 remains a separate control-plane acceptance gap. No policy weakening, reviewer/secret invention, repair workflow, release, deployment, outbound-license choice, or synthetic production evidence is included.

#279 should be closed as superseded only after this successor reaches protected-main truth.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9b8abafd-4b3a-44c8-9fec-b64c2b1708fc

📥 Commits

Reviewing files that changed from the base of the PR and between f1846b3 and ccc955f.

📒 Files selected for processing (2)
  • scripts/production-environment-governance-audit.mjs
  • test/production-environment-governance-utf8.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant