fix(security): authenticate exchange JSON media type and bytes - #275
Conversation
|
Warning Review limit reached
Next review available in: 91 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review Review exact current head |
Rate Limit Exceeded
|
Purpose
Close the
/exchangerequest-body trust boundary before JSON parsing or credential work. A POST carrying bytes must use the exactapplication/jsonmedia type, be valid UTF-8, remain within the existing 8 KiB streamed limit, and contain at most one escape-equivalent top-leveltarget_repositorymember.Exact identities
e684597212e2379f97c39548ad8a9563edd6a0790c20aa0379b6e566a54ad1bb3e201800614590f2fbcac6936a6e56c26d56a9712ab230f73b5305e3fix/exchange-json-media-type-boundaryGREEN implementation
The request boundary now:
;parameters and accepts exactlyapplication/json;415before body consumption for absent or different media types when a POST body exists;Content-Lengthheader;415response inopenapi.json;The boundary intentionally does not accept
application/*+json, form media types, or body sniffing. Callers either omit the optional body or send the documented JSON representation.Restack and verification boundary
The branch was merged with protected
mainafter #272 and #266 integrated the current package/audit and Node-24 artifact-upload baselines. The new merge tree overlays only the five reviewed PR paths on current protected-main bytes.Prior old-head evidence—126 application test files / 1063 tests, 100% owned production statement/branch/function/line coverage, reviewer-ci success, and protected-base Security Scan success—does not transfer because that application run later failed on the now-remediated predecessor
nanoidaudit. Applicationci,reviewer-ci, protected-base-eligibleSecurity Scan, and fresh review must all complete successfully on unchanged current headfbcac6936a6e56c26d56a9712ab230f73b5305e3before merge.No content sniffing, request-body relaxation, credential-path bypass, audit waiver, protection bypass, version bump, release, or deployment claim.