fix: keep tied organization names unbound - #174
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Verdict
SOUND for the ADR 0021 miss / tie / unique split. Prefer this over #159. Do not merge #159. Do not merge this onto main. Do not fold it into #151, #153, or #179.
score_corporate_entity classifies the three outcomes. get_or_create_corporate_entity returns before inference on a tie, and the lock-reload path also refuses AUTO-. Persist and Keyman share that function. Entity-relationship counterparties still resolve only.
Buyer check
- Open a post whose R&R names
Tied Energywhile two catalog rows share that display name, including after connecting a live orchestrator. The name is text, not a button. NoAUTO-row appears. - Make one of those catalog names unique, persist the summary again, then click. The walk uses that catalog id.
- A unique exact match among other same-named neighbors still walks.
Residuals (not blocking the gate)
CLAUDE.mdhas the 0021 seed;AGENTS.mdon this head does not. Agents that only readAGENTS.mdwill miss “tie is not a miss.”- Version 0.87.1 is also claimed by other open slices (period-report #175, write-clock successors). First merge wins the number; later slices must bump.
- Person-catalog #179 currently titles a different decision “ADR 0021.” This PR owns 0021 as tied organization similarity. #179 must retarget off
mainand take the next free number after this lands. - No Keyman live-inference tie test (Keyman persist tests monkeypatch
get_or_create). NoTied EnergyUI next-action: the popup shows text and does not say what to do next. - CodeRabbit skipped because the base is not the default branch. CLI agent auth is not available in this run.
CI was still queued at review time. Treat a red Full test suite or Frontend job as a fix, not a wait.
Author of this PR is the GitHub MCP login; this run cannot self-approve.
Sent by Cursor Automation: Fix Issues
|
Merge loop: exact remaining blocker is a merge conflict with base |
|
Merge loop: still dirty vs base Conflicting / colliding files to resolve on rebase:
No rebase from this loop. |
f831cbe to
fcf9175
Compare
Classify organization similarity outcomes as unique, miss, or tie. Ties stay unbound before name rewriting and after the creation-lock reload, so live resolution and inference cannot insert a third AUTO catalog row.
fcf9175 to
3e8a7bc
Compare
42ccd73
into
feat/role-responsibility-agent-ontology


Buyer impact
A top-score tie between distinct organization catalog ids is now an explicit
tie, not a genericNonethat can be mistaken for an unseen name. Tied names remain text and cannot enter theAUTO-catalog-creation path.This also closes the Keyman residual: the raw affiliation name is scored before verified abbreviation rewriting. A live rewrite therefore cannot convert an existing tie into an apparent miss and manufacture a third same-named row.
Exact scope
unique,miss, ortie;AGENTS.md;No leftover-pair work, RankWeave work, naruon integration, or TEPP slice is included. No release/version files are rewound or advanced by this stacked fix.
Rebase
Rebased as one commit onto the then-current
feat/role-responsibility-agent-ontologyhead:92b60dd1feb5ed787b04af2139b35a75b42ddd113e8a7bcb7665c52381b9557f198f588fb7acabbfThis PR targets #74's branch only. #74 remains open and must not be merged to
mainas part of this operation.Verification contract
tieand no catalog id;The head push is allowed to trigger normal checks. No workflow was force-cancelled or manually rerun.