Skip to content

feat: record the seeded period report on the analysis-run registry (v0.87.1) - #175

Closed
seonghobae wants to merge 1 commit into
feat/role-responsibility-agent-ontologyfrom
cursor/bc-506b2c9d-b427-4020-9059-2c8c5369fdfd-0182
Closed

feat: record the seeded period report on the analysis-run registry (v0.87.1)#175
seonghobae wants to merge 1 commit into
feat/role-responsibility-agent-ontologyfrom
cursor/bc-506b2c9d-b427-4020-9059-2c8c5369fdfd-0182

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Buyer gap after #141 / #148: make seed already built the Demo Corp period report, but Analysis runs only listed lineage and TEPP. Operators could not open a registry row for the report they already saw on the period-report panel.

This is the landing vehicle for ADR 0022. It rebases #161 onto 69c035b (v0.87.0 granted retention purge + Storybook tokens) so the feature branch is not downgraded to 0.86.4. Do not merge #161 (5437295, dirty vs this tip).

After _seed_demo_period_report writes the scored tables, seed records Period report · Succeeded · Demo Corp on the shared snapshot. The registry row stores digests and counts only — never a theta.

Next action: Run make seed, open Analysis runs, then open Period report · Succeeded · Demo Corp and confirm the cutoff posts. Mean θ stays on the period-report panel.

Boundaries

Tests

  • tests/test_seed_report_run.pyseed() calls the report-run helper after _seed_demo_period_report; insert is analysis_run_report / Succeeded; no theta in params
  • Frontend: succeeded report list/detail has no rebuild, reconstruction, pending-report, or measurement next-action

…0.87.1)

After make seed, Demo Analyst can open Period report · Succeeded ·
Demo Corp on the shared snapshot. The row does not copy a theta.
Rebased onto the v0.87.0 retention/Storybook tip so this slice does
not downgrade the feature branch to 0.86.4.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
@cursor

cursor Bot commented Aug 16, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9bd310f9-8250-4f88-9ec3-b71112ad6432

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ADR 0022 landing is sound. Seed writes the built Demo Corp period report as analysis_run_report / Succeeded on the shared snapshot after _seed_demo_period_report. The registry row stores digests and counts only — no theta, item bank, or provider body. POST /api/analysis-runs stays lineage-or-TEPP. Home next-action for a Succeeded report stays empty. Mean θ stays on the period-report panel.

No blocking product or ADR defect on bf3e7ac.

Non-blocking buyer-fixture gap: the default stubBackend() home list still omits Period report · Succeeded · Demo Corp unless succeededReportRun or failedReportRun is set. After make seed, GET /api/analysis-runs returns that third row. it("shows the seeded analysis run on the home page") calls stubBackend() with no flags and only asserts lineage + TEPP, so a later drop of the seeded report row would not fail the canonical home test.

Follow-up on this run: always include one run-demo-report row; default it to Succeeded; keep failedReportRun as the Failed override; assert the third caption on the seeded home test. Do not add a Request period-report button. Do not copy θ onto the registry row.

Do not merge #161 (dirty vs 69c035b). Do not fold AccName, write-clock, person-catalog, or start-reconstruction onto this slice.

Open in Web View Automation 

Sent by Cursor Automation: Fix Issues

Comment thread frontend/src/App.test.tsx
],
},
...(options?.failedReportRun
...(options?.failedReportRun || options?.succeededReportRun

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking fixture gap for ADR 0022. After make seed, GET /api/analysis-runs returns the Succeeded period-report row. The default stub still omits that row unless succeededReportRun or failedReportRun is set. it("shows the seeded analysis run on the home page") calls stubBackend() with no flags and only asserts lineage + TEPP.

Follow-up: always include one run-demo-report row; default it to Succeeded; keep failedReportRun as the Failed override; assert Period report · Succeeded · Demo Corp in the seeded home test, with no rebuild / reconstruct / measure / θ copy. Do not add a Request period-report button and do not put θ on this row.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Superseded by squash-merge of #197 into #74 (a2e745a, v0.96.0): seeded analysis_run_report / Succeeded is on the registry after make seed. Closing this older v0.87.1 vehicle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants