feat: record the seeded period report on the analysis-run registry (v0.87.1) - #175
Conversation
…0.87.1) After make seed, Demo Analyst can open Period report · Succeeded · Demo Corp on the shared snapshot. The row does not copy a theta. Rebased onto the v0.87.0 retention/Storybook tip so this slice does not downgrade the feature branch to 0.86.4. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
ADR 0022 landing is sound. Seed writes the built Demo Corp period report as analysis_run_report / Succeeded on the shared snapshot after _seed_demo_period_report. The registry row stores digests and counts only — no theta, item bank, or provider body. POST /api/analysis-runs stays lineage-or-TEPP. Home next-action for a Succeeded report stays empty. Mean θ stays on the period-report panel.
No blocking product or ADR defect on bf3e7ac.
Non-blocking buyer-fixture gap: the default stubBackend() home list still omits Period report · Succeeded · Demo Corp unless succeededReportRun or failedReportRun is set. After make seed, GET /api/analysis-runs returns that third row. it("shows the seeded analysis run on the home page") calls stubBackend() with no flags and only asserts lineage + TEPP, so a later drop of the seeded report row would not fail the canonical home test.
Follow-up on this run: always include one run-demo-report row; default it to Succeeded; keep failedReportRun as the Failed override; assert the third caption on the seeded home test. Do not add a Request period-report button. Do not copy θ onto the registry row.
Do not merge #161 (dirty vs 69c035b). Do not fold AccName, write-clock, person-catalog, or start-reconstruction onto this slice.
Sent by Cursor Automation: Fix Issues
| ], | ||
| }, | ||
| ...(options?.failedReportRun | ||
| ...(options?.failedReportRun || options?.succeededReportRun |
There was a problem hiding this comment.
Non-blocking fixture gap for ADR 0022. After make seed, GET /api/analysis-runs returns the Succeeded period-report row. The default stub still omits that row unless succeededReportRun or failedReportRun is set. it("shows the seeded analysis run on the home page") calls stubBackend() with no flags and only asserts lineage + TEPP.
Follow-up: always include one run-demo-report row; default it to Succeeded; keep failedReportRun as the Failed override; assert Period report · Succeeded · Demo Corp in the seeded home test, with no rebuild / reconstruct / measure / θ copy. Do not add a Request period-report button and do not put θ on this row.


Buyer gap after #141 / #148:
make seedalready built the Demo Corp period report, but Analysis runs only listed lineage and TEPP. Operators could not open a registry row for the report they already saw on the period-report panel.This is the landing vehicle for ADR 0022. It rebases #161 onto
69c035b(v0.87.0 granted retention purge + Storybook tokens) so the feature branch is not downgraded to 0.86.4. Do not merge #161 (5437295, dirty vs this tip).After
_seed_demo_period_reportwrites the scored tables, seed records Period report · Succeeded · Demo Corp on the shared snapshot. The registry row stores digests and counts only — never a theta.Next action: Run
make seed, open Analysis runs, then open Period report · Succeeded · Demo Corp and confirm the cutoff posts. Mean θ stays on the period-report panel.Boundaries
feat/role-responsibility-agent-ontology(this stack), notmain. Do not merge before Role, responsibility, and agent ontology (v2.10.0) #74.Tests
tests/test_seed_report_run.py—seed()calls the report-run helper after_seed_demo_period_report; insert isanalysis_run_report/ Succeeded; no theta in params