fix(ui): resolve unique catalog affiliations, omit distinct multiples - #112
Closed
cursor[bot] wants to merge 7 commits into
Closed
fix(ui): resolve unique catalog affiliations, omit distinct multiples#112cursor[bot] wants to merge 7 commits into
cursor[bot] wants to merge 7 commits into
Conversation
…2.0) Related chips still said "Ada West (Person)" even though the payload already had person_side_code. Attach person_side_label from common_lookup_value and use that caption (and accessible name) so the buyer sees Our side / Counterparty, not the ontology class.
Buyer gap: after person chips used Our side / Counterparty, org chips still said Demo Corp (Organization). Hydrate entity_level_label from common_lookup_value so the walk reads Demo Corp (Company). Missing lookups fall back to the code. Never invents a level.
Buyer gap: person chips say Our side / Counterparty and org chips say Company, but post chips still appended (Post). The related walk now shows the post title only.
Related person chips use the primary affiliation organization when one exists. After make seed, Ada West walks to Priya Nair, Northridge Grid (Counterparty) and Demo Corp walks to Ada West, Demo Corp (Our side). Missing affiliations stay omitted.
Related-node chips now treat a resolved corporate_entity as one identity and display its catalog name. Distinct unresolved orgs stay omitted so the seeded Priya path is side-only, matching the 0.75.0 contract. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Author
There was a problem hiding this comment.
Caption contract on this head is the right one: unique catalog identity shows entity_name, aliases collapse, distinct multiples are omitted, and Priya stays side-only after make seed.
#113 (5eeaa7f) carries the same caption rule plus the ADR-0013 payload-literal lock that #109 left as a residual scan. Prefer #113 if both slices should land together; this PR remains the caption-only alternative.
CodeRabbit CLI is not authenticated in this environment. Local affiliation unit tests and frontend tests on #113 passed; this comment does not re-run #112's suite.
Sent by Cursor Automation: Fix Issues
Contributor
This was referenced Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buyer impact
Related-person chips now show an organization only when exactly one identity is known. After
make seed, walk from Demo Corp and you should seeAda West, Demo Corp (Our side). Walk from Ada West and Priya staysPriya Nair (Counterparty)— she has two unresolved orgs, so the chip must not inventNorthridge Gridas a primary. When the one identity is a resolved catalog org, the chip usescorporate_entity.entity_name, not the raw extraction string.Open this instead of merging #92 at
c72317cc. That head dropped catalog identity, left CHANGELOG 0.75.0 advertising the invented Priya caption, and left the live-stack API test asserting it.What to verify
corporate_entity_idcollapse to the catalog name.Local evidence on
e41e5bf: affiliation unit tests 7 passed; frontendApp.test.tsx42 passed; oxlint clean.Merge boundary
Do not merge until exact-head/live-base Tests, Frontend, Semgrep, Security Scan, and required review gates are terminal-success on this head. Do not treat #92's predecessor-head evidence as current. Queued or stale-base checks are non-passing.