Skip to content

feat(ui): add Storybook walk-chip inventory (v0.78.0) - #136

Closed
cursor[bot] wants to merge 10 commits into
mainfrom
cursor/bc-6ed2bf1e-6678-4c2b-a0e8-dc1e5d53fb2c-b477
Closed

feat(ui): add Storybook walk-chip inventory (v0.78.0)#136
cursor[bot] wants to merge 10 commits into
mainfrom
cursor/bc-6ed2bf1e-6678-4c2b-a0e8-dc1e5d53fb2c-b477

Conversation

@cursor

@cursor cursor Bot commented Aug 16, 2026

Copy link
Copy Markdown

Buyer impact

Run cd frontend && pnpm run storybook and open Walk/RelatedNodeChip. Compare Ada West, Demo Corp (Our side), Priya Nair, multiple organizations (Counterparty), and Priya Nair (Counterparty) before you walk a seeded graph. Click a person or organization story to rehearse the next walk. When the caption says multiple organizations, open the Keyman list. Click the post story to open that source.

After make seed, the live walk is unchanged from #132: the related panel still names that next action, and a stale name-plus-ambiguous payload stays plural.

What this PR also locks

  • Repeating chips use RelatedNodeChip plus DTCG tokens in frontend/src/tokens/design-tokens.json (ADR-0016).
  • ADR-0015 stays the proposed affiliation-interval follow-up. This PR does not steal that number or add interval columns.
  • pnpm run build-storybook is a frontend CI step.
  • Blank affiliation and unique-Ada API paths assert affiliation_ambiguous is absent.

Prefer this over

Test plan

  • cd frontend && pnpm run lint && pnpm run test && pnpm run build && pnpm run build-storybook — 56 passed, Storybook 10.5.8 built
  • pytest backend/tests/test_related_node_affiliation_ambiguity.py tests/test_contextual_orchestrator_default_policy.py — 12 passed, 7 subtests
  • Required PR checks

Synthetic fixtures only. No raw LLM API. person_affiliation remains N:N with no primary column and no interval columns.

Open in Web View Automation 

cursoragent and others added 10 commits August 16, 2026 14:43
Keep ADR-0013 and drop the colliding ADR-0005 copies. Record one
Unreleased changelog entry, restore the runtime-adapter and
post-evaluation transport regressions, and correct the leftover
post-chat docstring so it no longer describes a forced route.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Keep post-chat and adjudication off the auto source-scan list so a
docstring mention cannot satisfy the product default. Assert both
checked-judgment clients send mode=verify on the wire.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
The live client already sends mode=auto. Keep the research note
aligned with ADR-0013 so operators do not reintroduce route.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Source scans now demand the executable "mode": "auto" / "mode": "verify"
literals so a docstring mention cannot satisfy ADR-0013. Rephrase the
post-chat contrast sentence so it no longer contains mode="auto".

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Related-node chips use side and entity-level labels instead of ontology
class names. A person chip adds an organization only when exactly one
affiliation is known, so Priya Nair stays Counterparty-only rather than
inventing a Northridge Grid primary. Post chips show the title only.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Treat a resolved corporate_entity as one identity and show entity_name.
Unresolved names that casefold-match that catalog label collapse into
it. Distinct multiples stay omitted so the chip never invents a primary.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Fold the orchestrator-mode changelog into 0.75.0 so a tag from this
head does not ship Unreleased behavior. Omit affiliation when two
catalog orgs are known, keep a unique org if the side is missing, and
put the visible caption in the post chip accessible name.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
A known-plural set now says "multiple organizations" so walking from
Ada West does not look like Priya has no org. Two catalog identities
and case-only unresolved aliases stay distinct or collapse by the
same rule. The chip still never invents a primary.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
When a related-node chip says multiple organizations, the related panel now tells the buyer to read the Keyman list (or extract Keymen) before continuing the walk. A stale name-plus-ambiguous payload still shows the plural signal.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
… head (v0.78.0)

Stack Storybook, DTCG tokens, and RelatedNodeChip on #132 so buyers can compare unique, plural, and missing affiliation chips before walking a seeded graph. ADR-0016 keeps 0015 for affiliation intervals.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
@seonghobae

Copy link
Copy Markdown
Contributor

Superseded by Storybook tokens already on #74 (landed with #145 / later home inventory). Closing this main-targeted duplicate. Do not merge onto main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants